Re: [PATCH mvebu + mvebu/dt64 4/4] arm64: dts: marvell: armada-37xx: move firmware node to generic dtsi file

Gregory CLEMENT
2021-03-12T09:00:19Z

Hello Marek,

> From: Pali Rohár <pali@kernel.org>
>
> Move the turris-mox-rwtm firmware node from Turris MOX' device tree into
> the generic armada-37xx.dtsi file.

I disagree with this patch. This firmware is specific to Turris MOX so
it is not something that should be exposed to all the Armada 3700 based
boards.

If you want you still can create an dtsi for this and include it when
needed.

Gregory

>
> The Turris MOX rWTM firmware can be used on any Armada 37xx device,
> giving them access to the rWTM hardware random number generator, which
> is otherwise unavailable.
>
> This change allows Linux to load the turris-mox-rwtm.ko module on these
> boards.
>
> Tested on ESPRESSObin v5 with both default Marvell WTMI firmware and
> CZ.NIC's firmware. With default WTMI firmware the turris-mox-rwtm fails
> to probe, while with CZ.NIC's firmware it registers the HW random number
> generator.
>
> Signed-off-by: Pali Rohár <pali@kernel.org>
> Signed-off-by: Marek Behún <kabel@kernel.org>
> Cc: <stable@vger.kernel.org> # 5.4+: 46d2f6d0c99f ("arm64: dts: armada-3720-turris-mox: add firmware node")
> ---
> arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dts | 8 --------
> arch/arm64/boot/dts/marvell/armada-37xx.dtsi | 8 ++++++++
> 2 files changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dts b/arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dts
> index d239ab70ed99..8447f303a294 100644
> --- a/arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dts
> +++ b/arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dts
> @@ -107,14 +107,6 @@ sfp: sfp {
> /* enabled by U-Boot if SFP module is present */
> status = "disabled";
> };
> -
> - firmware {
> - turris-mox-rwtm {
> - compatible = "cznic,turris-mox-rwtm";
> - mboxes = <&rwtm 0>;
> - status = "okay";
> - };
> - };
> };
>
> &i2c0 {
> diff --git a/arch/arm64/boot/dts/marvell/armada-37xx.dtsi b/arch/arm64/boot/dts/marvell/armada-37xx.dtsi
> index 7a2df148c6a3..31126f1ffe5b 100644
> --- a/arch/arm64/boot/dts/marvell/armada-37xx.dtsi
> +++ b/arch/arm64/boot/dts/marvell/armada-37xx.dtsi
> @@ -503,4 +503,12 @@ pcie_intc: interrupt-controller {
> };
> };
> };
> +
> + firmware {
> + turris-mox-rwtm {
> + compatible = "cznic,turris-mox-rwtm";
> + mboxes = <&rwtm 0>;
> + status = "okay";
> + };
> + };
> };
> --
> 2.26.2
>

--
Gregory Clement, Bootlin
Embedded Linux and Kernel engineering