From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97DF9C4338F for ; Fri, 23 Jul 2021 13:40:45 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6A4E560EE6 for ; Fri, 23 Jul 2021 13:40:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 6A4E560EE6 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=qU9aw7PPY1ZRpvL3NjUnc6YvtOL1xej9xXRQwKay+qI=; b=dJsalwaKn8MijQ GU1kAUGk2zExM7qBn2odWsDCsxWghR240gFSILapavZ6Rlhd+OV/YoGuP+/wy8WXqwEt61wHsIX60 4NzuXmzC6RwurnWaMO+rQFZyNu1b1gWJ/qRSLRiMN2Ir5fD6BlQKXph4RqidXqi+S156s90v58UHR NcxbAEpZcKwWfjmiBDwV9mV3kIFLxYuQlnKQ5GUdCNkOgzkcDmnZWNEyNAiagYbKGAzw5cl6aspp0 Cgh/TAXK9Csjg1RGpbhRL5XE3h2u7h4QI898fI4McoO/zBbavdKa2K4fFkQIae4P2JxTICXrsVQ/T ADAdgK1DFgxD7V32nztg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m6vOK-004t0K-3Q; Fri, 23 Jul 2021 13:39:05 +0000 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m6vOA-004sxS-RZ for linux-arm-kernel@lists.infradead.org; Fri, 23 Jul 2021 13:38:56 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1627047531; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=CNrCnNEi8YU3NjpLXktV8L2vGTneNrqBq6dOtm+we8Y=; b=Y5G+imUs3tWu4A6G+0OI/TzOINrUSgDLIn5tmms9bxq14J/f4VJLFsa+DcvpwtoPafaqPw nupzLAnJ5UhL1ChVnFjTIMsT+D1CjM1qJywHx2pqyjHCJKkv3G8AtDjiyeHLYmLLOKRosN nWdudvC4BYZ3as7KaPnAmOsB+yCenME= Received: from mail-io1-f72.google.com (mail-io1-f72.google.com [209.85.166.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-597-VGx8bAGGPJS6dpyLNugrYA-1; Fri, 23 Jul 2021 09:38:49 -0400 X-MC-Unique: VGx8bAGGPJS6dpyLNugrYA-1 Received: by mail-io1-f72.google.com with SMTP id v18-20020a5ec1120000b02905286f544a84so1778910iol.1 for ; Fri, 23 Jul 2021 06:38:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=CNrCnNEi8YU3NjpLXktV8L2vGTneNrqBq6dOtm+we8Y=; b=exdGRHo+ZLbdhNpCpKlM9D4byg5CqNVbSH695NaeOZ2u5RUQ0bs0/IjbhjuVL7EflL lne5/bzBQK3PZP/kbZqtz4tsRpByNT67vtDPCqt+q2zSZ9moh01xNktTiPsg5h57//vJ GAfApkBu7Q6NKE4i+SjjwDsX0gchs/QoyFPE/tNHfg1O4nyKgzveRta3FPJVTqIdaSnP 00S6bZawhCwwB1PB2Eyy9HEAcOJ2wQYkPa8s+6BD7QI7lQ7Twh4uXV1cX5a/NxgWAnMb uNRqeOUzx+pzbfZ7nOBdx1X8eLCVj6VhN/AggEtBXRbgKDtSDKIi+CrkzoCkS7/MLXsf EALA== X-Gm-Message-State: AOAM533wK/uymAssUa5joU0kHOWPnZZlusc3OeZMt0nuapDWWOUOMv0s cRqC3muO7BOyv8jpiaKZSCYFbf1u4ys9JUzgM/JP1N8NYzirLi9jyl6Q6GXV+qaMT4yMPj2J4Aw Pp5cZhWfBeyoYACXX654M4cfQcSmXo4+vRgo= X-Received: by 2002:a02:cd0a:: with SMTP id g10mr4243223jaq.18.1627047529244; Fri, 23 Jul 2021 06:38:49 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwek83fSduz7V8CLkiqtAngLuJBjs5iDFj4SG3DhS5HRyk7g8pS0JfJqY3+Yo29wQu7Wx0j/g== X-Received: by 2002:a02:cd0a:: with SMTP id g10mr4243213jaq.18.1627047529098; Fri, 23 Jul 2021 06:38:49 -0700 (PDT) Received: from gator ([204.16.59.133]) by smtp.gmail.com with ESMTPSA id p8sm11466441iol.49.2021.07.23.06.38.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Jul 2021 06:38:48 -0700 (PDT) Date: Fri, 23 Jul 2021 15:38:45 +0200 From: Andrew Jones To: Marc Zyngier Cc: linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@android.com, Srivatsa Vaddagiri , Shanker R Donthineni , will@kernel.org Subject: Re: [PATCH 10/16] KVM: arm64: Add some documentation for the MMIO guard feature Message-ID: <20210723133845.jwp3ljkfnupgv36i@gator> References: <20210715163159.1480168-1-maz@kernel.org> <20210715163159.1480168-11-maz@kernel.org> <20210721211743.hb2cxghhwl2y22yh@gator> <60d8e9e95ee4640cf3b457c53cb4cc7a@kernel.org> MIME-Version: 1.0 In-Reply-To: <60d8e9e95ee4640cf3b457c53cb4cc7a@kernel.org> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=drjones@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210723_063855_032271_C1864044 X-CRM114-Status: GOOD ( 16.09 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jul 23, 2021 at 02:30:13PM +0100, Marc Zyngier wrote: ... > > > + > > > + ============== ======== > > > ====================================== > > > + Function ID: (uint32) 0xC6000004 > > > + Arguments: (uint64) The base of the PG-sized IPA range > > > + that is allowed to be accessed as > > > + MMIO. Must aligned to the PG size (r1) > > > > align > > Hmmm. Ugly mix of tab and spaces. I have no idea what the norm > is here, so I'll just put spaces. I'm sure someone will let me > know if I'm wrong! ;-) Actually, my comment wasn't regarding the alignment of the text. I was commenting that we should change 'aligned' to 'align' in the text. (Sorry, that was indeed ambiguous.) Hmm, it might be better to just add 'be', i.e. 'be aligned'. I'm not sure what to do about the tab/space mixing, but keeping it consistent is good enough for me. Thanks, drew _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel