From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 69C0DC4338F for ; Fri, 23 Jul 2021 21:40:34 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2910A60ED7 for ; Fri, 23 Jul 2021 21:40:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 2910A60ED7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=cCKA0Si3w6NIG/fT6ZWjWclTghiusm/oPILFVsjcS7c=; b=EH0rTa1TJEZP+w 3/9z3aoH3vYOCMflxsKQ7X9rfsg9ZtdJsoJYzi0jLggztsxJ6wrIMFGFIbl77ytUA6en3H2Pdxm8a TfEGEiH+0YcX91UzAXShGI1ghVA4wET8Usd1iLqYdBr2KF8Urd0/hF3Yru6CDr2UlS/hL9Vib2yoo OkSyR2M8Qr+oTtA6a3SSyCFkwYzCu2juE+30XQOmAA48MgvpAIfBqXCGUhC/AmbGyJZ4ho3Dr6Jgs qWzmmoCs1Jay2EiXjQwR1FG4zBIHmq9QbetzmC3EL2wE9CrAKprFTtxUJY1TAV/4KC0tvkeLZ8X/1 0zQyd/XqmqVUbIHxJutg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m72sf-005ygl-2b; Fri, 23 Jul 2021 21:38:53 +0000 Received: from mail-il1-f173.google.com ([209.85.166.173]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m72sb-005yfW-7v for linux-arm-kernel@lists.infradead.org; Fri, 23 Jul 2021 21:38:50 +0000 Received: by mail-il1-f173.google.com with SMTP id l11so2839716iln.4 for ; Fri, 23 Jul 2021 14:38:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=qLC1a0942Ze1tivGSf8NMdJuQgNlX4CCAdHKNqxYvFw=; b=OieMjMDQTWjlfevB3U6jRbFNGaV+QMyk9TAzQX2W9KD2hXK3pEtaTk17/1C5/ipEOy Mg9BP4cliD/scLXzlQUaLnz55CTiR7t6dPT7UfTRD+YsRBTN7jn7aXMJvb31H6bgFIVo 2ZamecwOXNpcxfWrPRLeIUR0YsH/5FUsb81RGanN6vVNaYs6GUMQb6vqEbcz2ItwSKwj 10z7eL8Wgf/tZOmb8jKTL0GCDIbtwJTS0/Dr+kLl+ED3JTJH8q9HRA3+Q4VXDBlefErA ri+pp8K/YQq8GIGYHRmEStdQP6KywDcyFkJRiILat1PJMPntDzi3OsLoqnl9Bcb9xLOn sdkQ== X-Gm-Message-State: AOAM5317z0wJ1Ot4JTY2xxtH4jN0DqRF0i0GTXX8EomNmSUbqL8qZvcD 39PPBQLO4V7vl/In0/1lSg== X-Google-Smtp-Source: ABdhPJzZQVJYy6rBmD8rhTRjqsu5y/388MRTnNj0Dek62WfDxQEci31NVIVSjh3spz/Rszg7/lvxJA== X-Received: by 2002:a92:de0a:: with SMTP id x10mr4799658ilm.215.1627076326664; Fri, 23 Jul 2021 14:38:46 -0700 (PDT) Received: from robh.at.kernel.org ([64.188.179.248]) by smtp.gmail.com with ESMTPSA id h6sm18168876iop.40.2021.07.23.14.38.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Jul 2021 14:38:46 -0700 (PDT) Received: (nullmailer pid 2634577 invoked by uid 1000); Fri, 23 Jul 2021 21:38:43 -0000 Date: Fri, 23 Jul 2021 15:38:43 -0600 From: Rob Herring To: Maxime Ripard Cc: Frank Rowand , Linus Walleij , devicetree@vger.kernel.org, Rob Herring , "David S. Miller" , Chen-Yu Tsai , Jernej Skrabec , linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org, Jakub Kicinski , linux-sunxi@googlegroups.com Subject: Re: [PATCH 07/54] dt-bindings: bluetooth: broadcom: Fix clocks check Message-ID: <20210723213843.GA2634543@robh.at.kernel.org> References: <20210721140424.725744-1-maxime@cerno.tech> <20210721140424.725744-8-maxime@cerno.tech> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210721140424.725744-8-maxime@cerno.tech> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210723_143849_331538_BBECDBC8 X-CRM114-Status: GOOD ( 23.27 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 21 Jul 2021 16:03:37 +0200, Maxime Ripard wrote: > The original binding was mentioning that valid values for the clocks and > clock-names property were one or two clocks from extclk, txco and lpo, > with extclk being deprecated in favor of txco. > > However, the current binding lists a valid array as extclk, txco and > lpo, with either one or two items. > > While this looks similar, it actually enforces that all the device trees > use either ["extclk"], or ["extclk", "txco"]. That doesn't make much > sense, since the two clocks are said to be equivalent, with one > superseeding the other. > > lpo is also not a valid clock anymore, and would be as the third clock > of the list, while we could have only this clock in the previous binding > (and in DTs). > > Let's rework the clock clause to allow to have either: > > - extclk, and mark it a deprecated > - txco alone > - lpo alone > - txco, lpo > > While ["extclk", "lpo"] wouldn't be valid, it wasn't found in any device > tree so it's not an issue in practice. > > Similarly, ["lpo", "txco"] is still considered invalid, but it's > generally considered as a best practice to fix the order of clocks. > > Cc: "David S. Miller" > Cc: Jakub Kicinski > Cc: Linus Walleij > Cc: netdev@vger.kernel.org > Signed-off-by: Maxime Ripard > --- > .../bindings/net/broadcom-bluetooth.yaml | 17 +++++++++++++++-- > 1 file changed, 15 insertions(+), 2 deletions(-) > Reviewed-by: Rob Herring _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel