From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8B8AC4338F for ; Fri, 23 Jul 2021 22:18:14 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 813FA60ED7 for ; Fri, 23 Jul 2021 22:18:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 813FA60ED7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=bMZSDIEDG9QqrcQYu6Qaxeae+UuE6XpP6ZIdNeWjTl8=; b=VbOOr6KUK+OWoT F9NVPFjaHX+w072+XB04k/s1kDADuPd/gCEJQ2Sjqhw+MOf/55xnZGk/WMkKDKPZGV3c7bFGEjDsw Ka+J7XE/3cAyPPwwo1ZOOXK8A0qikYHW2/PQ38qp0dVC6sgfsaermatZB2agoLywYICRi61fGuOzj UGypSNqprIq4uc0EVDdYWTMmMWSqTObMeLrdY+NPHSs1LwW7x+amJor9L+vB4/fk0bAi7opEf4ltH j4M0G45851BSSevKXAV2W7sXMaFtaN4owKymzwgG7GwzJdI6yFo2yrNx1C8zPyjHAFTX3oR10ed1T +AsfXurlIMELPJcH1/JQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m73Sl-006CaN-Cb; Fri, 23 Jul 2021 22:16:11 +0000 Received: from mail-io1-f43.google.com ([209.85.166.43]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m73SB-006CL2-1y for linux-arm-kernel@lists.infradead.org; Fri, 23 Jul 2021 22:15:36 +0000 Received: by mail-io1-f43.google.com with SMTP id 185so4259616iou.10 for ; Fri, 23 Jul 2021 15:15:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=8VpOpdMI56wWAkj6aPBnW7egxkynjdSmdBCLRJSRl6I=; b=m/ms/o/EuX3OVisOVy/fgD1y4wWbS5cVMuZYo4ygkantEZO53EWR+rgG/+3SDl/5SG dzlJ0D5OGluI8nSYlg3E4+JeJBQDdSPB/+Muf/f7mBK/YubupnONhG/vfFHoZQk7Lo43 R6oYgBGEMEKwm5aQSK+Aw+A4tN8LAypmSPgdX4XKAO45EvBJIeawsHSpup7w6n0zxtwX KDc8aluAroTO/GdK0hDjlq/yTRAzfFll3RO/zm+lQ+7SvTLlYVxdAvoVcmwQMqD6PQER rwYemYfja7nTGPaaXbVvtgD/uTh0XJ8yAPYXkX6u7hKuXzPZMxED03k0yKcAJAKR1LO8 x7Sg== X-Gm-Message-State: AOAM5333R6xXIrbhMsFyVB8l7fVoZaxh3M9Q6CkuD4TeWA047Qoe1+sJ ZwXmYjcLR0QBvqxOlZkpPg== X-Google-Smtp-Source: ABdhPJxR6Rd6/8jGdufV11O47kcty8d3BHkNbsWeraol8KOjCzvkehOf/GjlJN9WblKe/cu4kXhiDQ== X-Received: by 2002:a5d:8186:: with SMTP id u6mr5498860ion.45.1627078534202; Fri, 23 Jul 2021 15:15:34 -0700 (PDT) Received: from robh.at.kernel.org ([64.188.179.248]) by smtp.gmail.com with ESMTPSA id w17sm14659643iom.20.2021.07.23.15.15.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Jul 2021 15:15:33 -0700 (PDT) Received: (nullmailer pid 2693115 invoked by uid 1000); Fri, 23 Jul 2021 22:15:30 -0000 Date: Fri, 23 Jul 2021 16:15:30 -0600 From: Rob Herring To: Maxime Ripard Cc: Chen-Yu Tsai , Jernej Skrabec , devicetree@vger.kernel.org, Frank Rowand , linux-arm-kernel@lists.infradead.org, linux-sunxi@googlegroups.com, Felipe Balbi , Greg Kroah-Hartman , linux-usb@vger.kernel.org Subject: Re: [PATCH 35/54] dt-bindings: usb: dwc3: Fix usb-phy check Message-ID: <20210723221530.GA2684283@robh.at.kernel.org> References: <20210721140424.725744-1-maxime@cerno.tech> <20210721140424.725744-36-maxime@cerno.tech> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210721140424.725744-36-maxime@cerno.tech> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210723_151535_192384_F0368C0F X-CRM114-Status: GOOD ( 22.56 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jul 21, 2021 at 04:04:05PM +0200, Maxime Ripard wrote: > The original binding was allowing any combination of usb2-phy and > usb3-phy in the phys and phy-names properties. > > However, the current binding enforces that those properties must be a > list of usb2-phy and usb3-phy, with exactly one element, effectively > making usb2-phy the only value being valid. Huh? If 'maxItems' is not specified, then it's the length of 'items' list. > Let's rework the properties description to allow either one or two > element picked with values either usb2-phy or usb3-phy. The rest of the > tooling makes sure that we don't get any duplicate value, so this should > be what we want. Is it really valid to have only a USB3 PHY and what you want here? That would mean the USB3 phy also handles USB2, right? > > Cc: Felipe Balbi > Cc: Greg Kroah-Hartman > Cc: linux-usb@vger.kernel.org > Signed-off-by: Maxime Ripard > --- > Documentation/devicetree/bindings/usb/snps,dwc3.yaml | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml > index 41416fbd92aa..6c3f7c9a76c0 100644 > --- a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml > +++ b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml > @@ -73,15 +73,15 @@ properties: > > phys: > minItems: 1 > - items: > - - description: USB2/HS PHY > - - description: USB3/SS PHY > + maxItems: 2 > > phy-names: > minItems: 1 > + maxItems: 2 > items: > - - const: usb2-phy > - - const: usb3-phy > + enum: > + - usb2-phy > + - usb3-phy > > resets: > minItems: 1 > -- > 2.31.1 > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel