From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5F52BC4338F for ; Fri, 23 Jul 2021 23:05:10 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 219E460F36 for ; Fri, 23 Jul 2021 23:05:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 219E460F36 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Rcjyq/sNTDc8lx1YS2qH6Elj0qqDLhErPf7TOpsR544=; b=LWyeNSu7zmoAwH 6GBN1VbAmnMwwVEZhJm+Rx4/a+anzSkwen0W169hpwKJFOpaD8NfCVTwjeTAO9C22VqiyI7Ob+8vR XcsRWavgwKI0aMvL7JwLa0jG6zH3vZMT/dI/aSEyDnxhTQ3noFJ3ozP+L/nlVydwrLpYqnwGH+TPT o9HebgQ64n5e1q0P9EiUD346aj6xJVKihY7zoKW6JBz5TUOmgXG+Jt/7gRzRACpbdPFvElX72eMRu A2sqBUn/iG2Y1md0WpcZu3ONqzIX2M48dl/c6+oyJDuVTzD509DUYSgDwj78u9oP+Y8bV41XKawki cKCjrIpu8nYXHL5f02mw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m74Cl-006Lt3-Vu; Fri, 23 Jul 2021 23:03:44 +0000 Received: from mail-io1-f49.google.com ([209.85.166.49]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m74Ci-006Ls2-AW for linux-arm-kernel@lists.infradead.org; Fri, 23 Jul 2021 23:03:41 +0000 Received: by mail-io1-f49.google.com with SMTP id h1so4362308iol.9 for ; Fri, 23 Jul 2021 16:03:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=DW4bQw9bBu1BhDL+EWMhBLTiwn6MVnii4A/u2r0uOO4=; b=ALo7LPnrDwaODjB/020hwsO5tZPhOq5/Rbx25gs8+KEuG7Urs9YE1WGPK6PRWj8yll tDBAURGMmZHVEvux9CSOk+7VSiYODqI6dO+hBR5OYj4B4IQbq0yFGhSWoJBC5ML8rQRb JPqYH3cuvgFAnDwmKmPJw8XIjkcrPcJQ+EfYm12xAUTV9wziq/qMEjNHuzsrfNMZ4qGa SM76LJ/LX+rLhaRyUubdvX6dGshHfTkgtD9ed2WRCTvxwmZlKH2s470s9CwXWDFXBm4w FqYb3EpSaM9qE/YTVgzNZwyaexB/3kUoAEtOy6QvNT8C0dAqXhsHkp6sCrwN3VLN6bQs 0eIg== X-Gm-Message-State: AOAM531ExhrL32h/3Hb5BuuAnPdGWD3no/B9e8A0jygT1UmHzOfM0fQF JcfWCjaPlWTfnEJD/gxD9m9Xc8o7DQ== X-Google-Smtp-Source: ABdhPJzkKRM3SdTpwR7KsVQI2xc7VD6bxG1O9jkUH3Cu4HixVa3X3vQH5/ZVGWU5h977KexrakHw8w== X-Received: by 2002:a05:6638:25c7:: with SMTP id u7mr6034251jat.26.1627081418604; Fri, 23 Jul 2021 16:03:38 -0700 (PDT) Received: from robh.at.kernel.org ([64.188.179.248]) by smtp.gmail.com with ESMTPSA id v18sm17161933iln.49.2021.07.23.16.03.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Jul 2021 16:03:38 -0700 (PDT) Received: (nullmailer pid 2770149 invoked by uid 1000); Fri, 23 Jul 2021 23:03:36 -0000 Date: Fri, 23 Jul 2021 17:03:36 -0600 From: Rob Herring To: Baruch Siach Cc: Thierry Reding , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Lee Jones , Andy Gross , Bjorn Andersson , Balaji Prakash J , Robert Marko , Kathiravan T , linux-pwm@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v6 3/4] dt-bindings: pwm: add IPQ6018 binding Message-ID: <20210723230336.GA2764383@robh.at.kernel.org> References: <889aae1b88f120cb6281919d27164a959fbe69d0.1626948070.git.baruch@tkos.co.il> <70f0522a9394e9da2f31871442d47f6ad0ff41aa.1626948070.git.baruch@tkos.co.il> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <70f0522a9394e9da2f31871442d47f6ad0ff41aa.1626948070.git.baruch@tkos.co.il> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210723_160340_416311_41D3421C X-CRM114-Status: GOOD ( 19.06 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Jul 22, 2021 at 01:01:09PM +0300, Baruch Siach wrote: > DT binding for the PWM block in Qualcomm IPQ6018 SoC. > = > Signed-off-by: Baruch Siach > --- > v6: > = > Device node is child of TCSR; remove phandle (Rob Herring) > = > Add assigned-clocks/assigned-clock-rates (Uwe Kleine-K=F6nig) > = > v5: Use qcom,pwm-regs for phandle instead of direct regs (Bjorn > Andersson, Kathiravan T) > = > v4: Update the binding example node as well (Rob Herring's bot) > = > v3: s/qcom,pwm-ipq6018/qcom,ipq6018-pwm/ (Rob Herring) > = > v2: Make #pwm-cells const (Rob Herring) > --- > .../devicetree/bindings/pwm/ipq-pwm.yaml | 69 +++++++++++++++++++ > 1 file changed, 69 insertions(+) > create mode 100644 Documentation/devicetree/bindings/pwm/ipq-pwm.yaml > = > diff --git a/Documentation/devicetree/bindings/pwm/ipq-pwm.yaml b/Documen= tation/devicetree/bindings/pwm/ipq-pwm.yaml > new file mode 100644 > index 000000000000..ee2bb03a1223 > --- /dev/null > +++ b/Documentation/devicetree/bindings/pwm/ipq-pwm.yaml > @@ -0,0 +1,69 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/pwm/ipq-pwm.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Qualcomm IPQ6018 PWM controller > + > +maintainers: > + - Baruch Siach > + > +properties: > + "#pwm-cells": > + const: 2 > + > + compatible: > + const: qcom,ipq6018-pwm > + > + offset: > + description: | > + Offset of PWM register in the TCSR block. > + maxItems: 1 Use 'reg' here instead. > + > + clocks: > + maxItems: 1 > + > + clock-names: > + const: core > + > + assigned-clocks: > + maxItems: 1 > + > + assigned-clock-rates: > + maxItems: 1 > + > +required: > + - "#pwm-cells" > + - compatible > + - clocks > + - clock-names > + - assigned-clocks > + - assigned-clock-rates > + > +additionalProperties: false > + > +examples: > + - | > + #include > + > + soc { > + #address-cells =3D <2>; > + #size-cells =3D <2>; > + > + tcsr: syscon@1937000 { > + compatible =3D "syscon", "simple-mfd"; This should really have a specific compatible string, but we don't warn = for that (yet). > + reg =3D <0x0 0x01937000 0x0 0x21000>; > + > + pwm: pwm { > + #pwm-cells =3D <2>; > + compatible =3D "qcom,ipq6018-pwm"; > + offset =3D <0xa010>; > + clocks =3D <&gcc GCC_ADSS_PWM_CLK>; > + clock-names =3D "core"; > + assigned-clocks =3D <&gcc GCC_ADSS_PWM_CLK>; > + assigned-clock-rates =3D <100000000>; > + status =3D "disabled"; Drop 'status' > + }; > + }; > + }; > -- = > 2.30.2 > = > = _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel