From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5342C4338F for ; Sat, 24 Jul 2021 15:27:12 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 732F860E96 for ; Sat, 24 Jul 2021 15:27:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 732F860E96 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=GNeTeDS1IHXrbPEq290bnsEewhHzsgmGwGQNXthISfM=; b=CO6WdnzdrwrQ5a Jks8aLzNk6lgYji1MxGvvnAg81S6YSqUku1YvHoLBdak3XutYAPhWNIrGFL6SJI6ZqeDhUraB5GJZ nbeOuP5V8SQy2GnvIz0NaOCJThP96c7D3FzErai8OwGrFV5mlow+E8/1zgr+THo3lWUTquPApXm3g PWStY1gfL/dd89KM7rUh3v5OQGoQV2DOEcManKYUcZu//VFCsynTy5xjeJ49DYTl9goLOmSR4w1V2 p5LbSB+OlIcaUItS7BUKrOMl70lo0Up2NWNT0CFA7J5nijRiQZJfY6Cb8pzONUslV0DHer8Lg3yJP 4+HJOsWItucB8DoUnchg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m7JWi-007LLY-0c; Sat, 24 Jul 2021 15:25:20 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m7JWe-007LLB-0R for linux-arm-kernel@lists.infradead.org; Sat, 24 Jul 2021 15:25:17 +0000 Received: from jic23-huawei (cpc108967-cmbg20-2-0-cust86.5-4.cable.virginm.net [81.101.6.87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C879A6056C; Sat, 24 Jul 2021 15:25:10 +0000 (UTC) Date: Sat, 24 Jul 2021 16:27:41 +0100 From: Jonathan Cameron To: Tang Bin Cc: knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, broonie@kernel.org, lgirdwood@gmail.com, linux-iio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Zhang Shengju Subject: Re: [PATCH] iio: adc: fsl-imx25-gcq: Use the defined variable to clean code Message-ID: <20210724162741.15a8b8b6@jic23-huawei> In-Reply-To: <20210720125945.11548-1-tangbin@cmss.chinamobile.com> References: <20210720125945.11548-1-tangbin@cmss.chinamobile.com> X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210724_082516_124921_214A9E87 X-CRM114-Status: GOOD ( 16.64 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 20 Jul 2021 20:59:45 +0800 Tang Bin wrote: > Use the defined variable "dev" to make the code cleaner. > > Co-developed-by: Zhang Shengju > Signed-off-by: Zhang Shengju > Signed-off-by: Tang Bin Applied. Thanks, Jonathan > --- > drivers/iio/adc/fsl-imx25-gcq.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/iio/adc/fsl-imx25-gcq.c b/drivers/iio/adc/fsl-imx25-gcq.c > index d28976f21..01fe5b137 100644 > --- a/drivers/iio/adc/fsl-imx25-gcq.c > +++ b/drivers/iio/adc/fsl-imx25-gcq.c > @@ -192,11 +192,11 @@ static int mx25_gcq_setup_cfgs(struct platform_device *pdev, > */ > priv->vref[MX25_ADC_REFP_INT] = NULL; > priv->vref[MX25_ADC_REFP_EXT] = > - devm_regulator_get_optional(&pdev->dev, "vref-ext"); > + devm_regulator_get_optional(dev, "vref-ext"); > priv->vref[MX25_ADC_REFP_XP] = > - devm_regulator_get_optional(&pdev->dev, "vref-xp"); > + devm_regulator_get_optional(dev, "vref-xp"); > priv->vref[MX25_ADC_REFP_YP] = > - devm_regulator_get_optional(&pdev->dev, "vref-yp"); > + devm_regulator_get_optional(dev, "vref-yp"); > > for_each_child_of_node(np, child) { > u32 reg; > @@ -298,7 +298,7 @@ static int mx25_gcq_probe(struct platform_device *pdev) > int ret; > int i; > > - indio_dev = devm_iio_device_alloc(&pdev->dev, sizeof(*priv)); > + indio_dev = devm_iio_device_alloc(dev, sizeof(*priv)); > if (!indio_dev) > return -ENOMEM; > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel