From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90D11C432BE for ; Mon, 26 Jul 2021 10:56:49 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5E14C60241 for ; Mon, 26 Jul 2021 10:56:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 5E14C60241 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=RyA4CMBh2sWz+kC59bb967VLa3wuxBxUJEaBDwIWFHQ=; b=3EUSiHsRnqr91Z 64bPswUowOFauKfLbYpgQKPxDIVKpLh18NDC/idVV0WyinpnsReO6OQEvW/9GQtHkS8HvrONc2YMl s9PXo/F9FeKSQRoJ4HochrsVqLuV6dlH/ssZynqRbieJdzk4h3iylApt7Zv8fSk08kKmIRdUFmf3i u44GXZd2MjU3e7f3toMPq54qJ3vCYxo7xbEFmTRcgUL4B6J617ybunlJ+heoWdj61KxNVCny9/PCV N/k+sr5YAf4qd/4QgM65dWRfBSMRZphGwCkI2sxzvJO99CRl8QClxBEfxRndx933K4hhOQPmUXkaz n+cS1+Mw6tiWYkuRu8cg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m7yGN-00Angc-B2; Mon, 26 Jul 2021 10:55:11 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m7yGJ-00Ang9-5s for linux-arm-kernel@lists.infradead.org; Mon, 26 Jul 2021 10:55:08 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 8B49911B3; Mon, 26 Jul 2021 03:55:02 -0700 (PDT) Received: from bogus (unknown [10.57.64.156]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 161663F70D; Mon, 26 Jul 2021 03:54:59 -0700 (PDT) Date: Mon, 26 Jul 2021 11:54:00 +0100 From: Sudeep Holla To: Sumit Garg Cc: Jens Wiklander , Linux Kernel Mailing List , linux-arm-kernel , OP-TEE TrustedFirmware , Marc Bonnici , Sudeep Holla , Jerome Forissier , sughosh.ganu@linaro.org Subject: Re: [PATCH v3 0/5] Add FF-A support in OP-TEE driver Message-ID: <20210726105400.2li4fj223u3vajly@bogus> References: <20210722121757.1944658-1-jens.wiklander@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210726_035507_364007_18EAAB64 X-CRM114-Status: GOOD ( 35.60 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jul 26, 2021 at 03:59:36PM +0530, Sumit Garg wrote: > Hi Jens, > > On Thu, 22 Jul 2021 at 17:48, Jens Wiklander wrote: > > > > Hi all, > > > > This adds supports for the OP-TEE driver to communicate with secure world > > using FF-A [1] as transport. > > > > There is one change to the TEE subsystem with "tee: add sec_world_id to > > struct tee_shm" to add support for holding globally unique handle assigned > > by the FF-A. This is a field that I believe could useful for the AMDTEE > > driver too. > > > > For communication the OP-TEE message protocol is still used, but with a new > > type of memory reference, struct optee_msg_param_fmem, to carry the > > information needed by FF-A. The OP-TEE driver is refactored internally with > > to sets of callbacks, one for the old SMC based communication and another > > set with FF-A as transport. The functions relating to the SMC based ABI > > are moved to smc_abi.c while the FF-A based ABI is added in a ffa_abi.c. > > > > There is also a difference in how the drivers are instantiated. With the > > SMC based transport we have a platform driver, module_platform_driver(), > > today which we're keeping as is for this configuration. In a FF-A system we > > have a FF-A driver, module_ffa_driver(), instead. > > > > The OP-TEE driver can be compiled for both targets at the same time and > > it's up to runtime configuration (device tree or ACPI) to decide how it's > > initialized. Note that it's only the old SMC based driver instance that > > need device tree or ACPI to initialize. The FF-A based driver relies on the > > FF-A bus instead. > > > > This can be tested QEMU > > The repo for SPMC at S-EL1 retrieved by > > repo init -u https://github.com/jenswi-linaro/manifest.git -m > > qemu_v8.xml -b ffav4_spmc > > repo sync > > # Then checkout the branch optee_ffa_v3 from > > # git://git.linaro.org/people/jens.wiklander/linux-tee.git > > # in the linux directory > > > > To build do: > > cd build > > make toolchains > > make all > > > > To boot: > > make run-only > > > > Test with xtest, perhaps only with the command "xtest 1004" in case you're > > not interested in too many tests. > > Thanks Jens for sharing instructions to test this feature. So I tried > to reproduce using following repo versions: > > linux-tee, branch: optee_ffa_v3 > trusted-firmware-a, branch: ffav4_sel1_spmc > build, branch: ffav4_spmc > > and rest of the repos synced to the latest version as per upstream > qemu_v8.xml [1] but I don't see OP-TEE driver being probed during boot > [2]. Am I missing something? > > [1] https://github.com/OP-TEE/manifest/blob/master/qemu_v8.xml > [2] > Welcome to Buildroot, type root or test to login > buildroot login: root > # dmesg | grep optee > Do you see ARM FF-A driver initialised successfully ? You must see "ARM FF-A Version 1.0 found" or something similar based on the actual version supported. If so, can you check if the partitions are correctly populated by the driver using the discover API. $ grep "" /sys/bus/arm_ffa/devices/*/uuid If uuid reads zeros, then the devices are populated, just the matching driver is not found(due to the workaround for v1.0 spec) -- Regards, Sudeep _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel