From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.7 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A67EC4338F for ; Tue, 27 Jul 2021 16:57:40 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 48A5B60FF0 for ; Tue, 27 Jul 2021 16:57:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 48A5B60FF0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=+bc9KP1Mft1SaAzs9/M9RYP9+6LOWGpmEzfbYhGAVU4=; b=zCfAoQtzudc7lo RS4Iv2GWcd8610vIi6VNhVgJNr3m0/gaCL8/PuwGzuq/D9GLEh3YPWaPsEP+B1rBUw+Vp5X4ZySko kK+rcZwJNOR41r07djrxYOTn+ib8TXv0C8RDUQ8W6X3ijTqFNKYKfgw+5ztZA94QUBV719SEuAkmC Uwut5OBs8jgwouFdqFCzpMVik+PtlkAnT7B2wGsFAzjZLufDhluvwjvMtAJX3KA4MWD9Ks50/Emd6 pcRs5gduhY2JKkGPrHspLjlXMu3iUBtH19h6JlZ6zPHhoifEbM/vguTehwZu7EEZUMhmoLOwnGwZW 4b7AcNdP7HoIE47JVqIQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m8QMs-00FQYN-Gd; Tue, 27 Jul 2021 16:55:46 +0000 Received: from mail-pl1-x632.google.com ([2607:f8b0:4864:20::632]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m8QMp-00FQX3-AM for linux-arm-kernel@lists.infradead.org; Tue, 27 Jul 2021 16:55:44 +0000 Received: by mail-pl1-x632.google.com with SMTP id n10so16577387plf.4 for ; Tue, 27 Jul 2021 09:55:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=QQoNCG1M1L8gK5ht1u6i2Ce3nKisRclgMdzn1xxe0eA=; b=jjBH51zUezd5bHvHk2ASWyXfi/yE/hVl6TAbgIpIABp4TeK3z7dG6HRwMZyiX5+Uhr a6U01JsaicvYDXPV5eWNA74GYSKK3+dAz3K4NPb+QpZw1GBER7K/0A3/JA7fwCcebkLv DkML+5g5G0AB3ow5jYxg7xrwzK4rw+Pd1JdiP1fEiMEc0D/P/JbLUOS6bSJL41YL3OgM sVVdfnaOqm7nj/xywAY66pDFHS2AoF8rLfw1ChGaMJuSP5eWCOB948CVrk4OS9lTyffk G4J7eMP7Ae0MiVdbiEUqHVJdA1dHAyux1kr2yd50gg8BdOcLWBq80La8TAyzVvBc2ppi X81A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=QQoNCG1M1L8gK5ht1u6i2Ce3nKisRclgMdzn1xxe0eA=; b=RcyOshADPLtpXjebZpUfB6+0gcOcycnnw2vM24u9+7PRjvIiInker3yyTGNWtVjozF J+r1Ele2olArqItR7mk/4ccy5Q+5DiSQ0xLOftU4tvvEBS73y1eRuG4VOXf21ECtVPz3 sIfCMFPktKXxOuqVRiq3sBavQ6wrZNLPq5fOKkpi0votVwek1l++wmKYYbok01jYTShn cLpvoFMMmIj0Z4NDvu2xHG2faAo7yIRZx89KrKNHO2UXZ6a5Fpto3jbc5UjXV4Jf0W/1 4R2eNQmJLlYune5G2XbGpPuZ3BD0Ldg5v8t7XnJbpvoOYTyHhhON0aaKFGWhYEgULKk/ FYrg== X-Gm-Message-State: AOAM530Eq2J4t0iuTQ0wNvoYvRM/K0WWMl9qZJnIYM5DuP9Ic4DOtqr9 eZJXKpdGiyJay+v9uFrE9R8= X-Google-Smtp-Source: ABdhPJwY8lsfzvJMPbJsMFM8vgp5/st1KXukwiUobKcGkNjEncAvzMHeMUy7vLecay+P05ELFWikBQ== X-Received: by 2002:a17:90a:ce17:: with SMTP id f23mr2453653pju.236.1627404939233; Tue, 27 Jul 2021 09:55:39 -0700 (PDT) Received: from ojas ([122.161.53.213]) by smtp.gmail.com with ESMTPSA id k16sm4169671pfu.83.2021.07.27.09.55.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Jul 2021 09:55:38 -0700 (PDT) Date: Tue, 27 Jul 2021 22:25:26 +0530 From: Ojaswin Mujoo To: Greg KH Cc: nsaenz@kernel.org, stefan.wahren@i2se.com, dan.carpenter@oracle.com, phil@raspberrypi.com, linux-arm-kernel@lists.infradead.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 4/5] staging: vchiq: Make creation of vchiq cdev optional Message-ID: <20210727165526.GA13711@ojas> References: <846c424dd4aae14d1cc28c8f30877a06e2b7dd10.1626882325.git.ojaswin98@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210727_095543_408302_BC00CE88 X-CRM114-Status: GOOD ( 22.54 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jul 27, 2021 at 03:25:01PM +0200, Greg KH wrote: > On Wed, Jul 21, 2021 at 09:50:52PM +0530, Ojaswin Mujoo wrote: > > Before this commit, vchiq cdev (/dev/vchiq) was always created during > > platform initialization. Introduce a new Kconfig option > > CONFIG_VCHIQ_CDEV which determines if the cdev will be created or not. > > > > Signed-off-by: Ojaswin Mujoo > > --- > > drivers/staging/vc04_services/Kconfig | 10 ++++++++++ > > drivers/staging/vc04_services/Makefile | 5 ++++- > > .../vc04_services/interface/vchiq_arm/vchiq_arm.h | 9 +++++++++ > > 3 files changed, 23 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/staging/vc04_services/Kconfig b/drivers/staging/vc04_services/Kconfig > > index 4b886293f198..63caa6818d37 100644 > > --- a/drivers/staging/vc04_services/Kconfig > > +++ b/drivers/staging/vc04_services/Kconfig > > @@ -19,6 +19,16 @@ config BCM2835_VCHIQ > > Defaults to Y when the Broadcom Videocore services > > are included in the build, N otherwise. > > > > +if BCM2835_VCHIQ > > + > > +config VCHIQ_CDEV > > + bool "VCHIQ Character Driver" > > + help > > + Enable the creation of VCHIQ character driver to help > > + communicate with the Videocore platform. > > I'll take this, but this really should say more about what this really > is for. Who needs this? Why will I know if I want a character driver > interface? What tools talk to this? > > Or conversely, why would I want to turn this off? > > Can you send a follow-on patch that makes this more descriptive? Hello Greg, Sure, I can send in a follow up patch explaining this in more detail. Thank you, Ojaswin > > thanks, > > greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel