From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 397A7C432BE for ; Thu, 29 Jul 2021 06:45:49 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 00D6161019 for ; Thu, 29 Jul 2021 06:45:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 00D6161019 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=n5Ms2eIz/dD3mtK61o0XcR04TkjbtQ+n2tgaOI+pfaA=; b=bdjeaM3Q81bDxx 1QaVZRiF7+6dIf9+0dSFgTyvVsOFQTccig8UGItat3UVQ47MXV/3vFUxFfS2ZnWaDGd/KtmH0ufQ9 qeI1ZGQCfgwje0VuLdRYpa/QcqstFbh8PsA/9x8m6/dIITyfmi9DI5tUAJgzB42M4gM1FQKRM26Pz xg9t5E5EkzLe5RsukWd/L+b7fu4ptBGg8+qrF2FT+TsBjTdanrGlSWGzy7iygxtimWBHBWQ1codz0 fUP+Bs7aQOWIouLgJNxsvLsfk6FETf2OtiZHUwfD014XCBJLMTWQm2ypuLTyKllu4GvIx/acSDch3 3ZEMTVe0H9mEtULllsVw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m8zm3-003GkI-7D; Thu, 29 Jul 2021 06:44:07 +0000 Received: from mail-lf1-x12b.google.com ([2a00:1450:4864:20::12b]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m8zlz-003Gjb-UO for linux-arm-kernel@lists.infradead.org; Thu, 29 Jul 2021 06:44:05 +0000 Received: by mail-lf1-x12b.google.com with SMTP id a26so8890979lfr.11 for ; Wed, 28 Jul 2021 23:44:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=aNHAvKzLnDE0l22szBAplJPRIyO7Fjn7sOyBfjv9ftM=; b=TzevBp24AUTpOKpCI+D8uvXeWR8ycXDOEPiiRHRAu2eZQWaaQ01ysFXZNwT8ggjIPk C3SCJXwd6aYveLIThgf85/uMLZ5F/nUnhMaL/l1ZprzFvh2V4Tm7non1BxmQS3LCZIJr OTdgxDIsijzxmTfNendVfIpRhAbNYLdOZg9x/T0+VbTlPHseCBx6Vdi8t9BMaLY7B8cZ cjCoYXxofDgvt/jM1GLxHvGHQAy9YLc+2hDbqyvlexV2HrL4k3njHJT44enyC0LSQYOp q4WSzXombeCZFc8oo36OQ2MoFQz53cmbQXnBBhm9tjmEzYPDmAnCzoQHZjwcWQfF9leb UyRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=aNHAvKzLnDE0l22szBAplJPRIyO7Fjn7sOyBfjv9ftM=; b=NlKBzR6z9Em66sluzO5Qk1bo7kUNSgXohhPIjOAxueqEe9sWxOImqPuSLa60KJJ3FH eSvYxLueIPQcz2EeJ0vj8mLqQnxSutluWdvPcAiIyMcu52V6Hpo6i+8riwOdrKUAV8iM cnu1gMpCXguxxiZ8dNBplq/eJlCMWhVpAqR7H2F6kTGON2hucYgi9Okh02axAg2gvXz2 H1qww1KmHeyCkSLy6KVztlIoA7Oo83kdMr++s+yw6C/8+CXIRttZK5O359SxoQiqQAKr xZj4FplgNikJBM7YB7VxHq9QAG2fU9yFA4Dj7t2nsYxyn08aTavtOSPr4oxsH7PvUdu3 zUYQ== X-Gm-Message-State: AOAM5303Aq1ph8fMg36PxcYO1UlXvlaEcR0v5aYJnJaAhWYh4M97ZDab gfVFHoBzhW66HzdmPQ03brM8Fg== X-Google-Smtp-Source: ABdhPJxpJbFaurYlEZcpIUIj9510NOv6ZQJA1ULcwdlk/07Q/oZhBgwaXewMrNtwLx5V//7MppqEjw== X-Received: by 2002:a19:c707:: with SMTP id x7mr2679322lff.38.1627541041147; Wed, 28 Jul 2021 23:44:01 -0700 (PDT) Received: from jade (h-94-254-48-165.A175.priv.bahnhof.se. [94.254.48.165]) by smtp.gmail.com with ESMTPSA id i3sm90427ljd.57.2021.07.28.23.44.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Jul 2021 23:44:00 -0700 (PDT) Date: Thu, 29 Jul 2021 08:43:59 +0200 From: Jens Wiklander To: Sumit Garg Cc: Linux Kernel Mailing List , linux-arm-kernel , OP-TEE TrustedFirmware , Sudeep Holla , Marc Bonnici , Jerome Forissier , Sughosh Ganu Subject: Re: [PATCH v3 2/5] optee: simplify optee_release() Message-ID: <20210729064359.GA3316601@jade> References: <20210722121757.1944658-1-jens.wiklander@linaro.org> <20210722121757.1944658-3-jens.wiklander@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210728_234404_051219_958A53EC X-CRM114-Status: GOOD ( 13.99 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jul 28, 2021 at 02:15:47PM +0530, Sumit Garg wrote: > On Thu, 22 Jul 2021 at 17:48, Jens Wiklander wrote: > > > > Simplifies optee_release() with a new helper function, > > optee_close_session_helper() which has been factored out from > > optee_close_session(). > > > > Simplification looks good to me. > > > A separate optee_release_supp() is added for the supplicant device. > > > > On similar terms, can we have separate optee_open_supp() for better > understanding? I'm not so keen on that. It wouldn't be much of a simplification since we'd end up adding quite a few functions. optee_smc_open_supp(), optee_ffa_open_supp(), optee_open_common(), and finally optee_open_supp(). Thanks, Jens _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel