From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E6792C432BE for ; Thu, 29 Jul 2021 12:31:43 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B008C60F00 for ; Thu, 29 Jul 2021 12:31:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org B008C60F00 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=cerno.tech Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Fui3fqIxixD1TC7c0XJtKubw7hMSsoB2rf9AE9/0fCg=; b=3j3lrFRAEbjzSc 7cha0DwkuXSKOuoAp7DqFxMYJ3tmGl4qSOfPVxcPuqm1ZT7+CoO882okGAGacQXBsmp72LGuchlJJ /XDHLvgZ9IwQNREY2ovUAkWx41+dM0jJS4YrsiRypjF+Asnew2dPSzwyXeS8tOxoG6HKLlzfZ4/gp Ic0FCtYK70rJH7igzAmp2O+2pxNXGEp00Wz3Jj5tku4mVlCB3Puf8rhEGpqiacnJWUwp2/GC5Ns4w xTlzzRbii06YQ1L1Cxq7fcBvCbOsLIkz0xltvrXNGbEvb0u1D8rN4R9nbfLuqyhobq9vuioay2FNW d9t5LWYuZDmJHXjP6Pdw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m95AZ-0047QC-IT; Thu, 29 Jul 2021 12:29:47 +0000 Received: from out4-smtp.messagingengine.com ([66.111.4.28]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m95AV-0047Pf-QV for linux-arm-kernel@lists.infradead.org; Thu, 29 Jul 2021 12:29:45 +0000 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id C298F5C00BC; Thu, 29 Jul 2021 08:29:42 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Thu, 29 Jul 2021 08:29:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:content-transfer-encoding:in-reply-to; s=fm3; bh=6 Fzowjt81NyaUnF7+p0gjmnL8GZGPKJTWRJZvkPp5zI=; b=t5hVYCm7duDUEFcP6 3WwSXJaFRoCc4zRc3hX+btqmFT+DyvnNUJ4sRbdle+jxSXIETePlw0gzeAtwm7VE J93QgY4ygk6rKzrxizRV/eWXAs7wzsWQ3r+1BuMGr+zsmA31sxqe2Q+n5oNLKSgz Lcjkpn1v6Oh2IrIDqyyyILloohEKQ5Jg/tlPYyzqDBhuoazkDUcNIB7eXWjNjmOZ /FybOC5O3faOf6QR4tqcQADTrx93FxwlwAetYWnxqlSkr1xlAum1Znfo+siQOJgW r4jQ24UczLcLXJw+y+y3f0bje7j5cLuZCNYmfXyVO9m0gF4e0HLaQQnHXsl/ej7p O8sDg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=6Fzowjt81NyaUnF7+p0gjmnL8GZGPKJTWRJZvkPp5 zI=; b=keTZeIBGLbbkPxUAgv2Hafk98V4NlP0BFbHN01qov27OJTv6gMSe2QUc+ IFZkF08DEyhC3eR8iRvWb1XH2SOZGXDkAMzUPVeNhrvbGvElg7LOnepHrhSCIsO5 HRcPBMAjgP7p+nNKX8zZTZbIh1IKE0ydeAiLPRiyYNYbg/hzoFdhZ8BGWSN2INsd hUSO4BZz6XwQYXC0xOuBvwxafKd+t3lHS9ly3Wzc1rPSvQf/F4bJ/L+QQadmejAq dvD1pXksY2FQwN1MqtleVGsEF6vrXlajAkBX+/50mDHtt0vzhTgFN6KCqiv1QPaN HLNVcuuQG8saKYN4eEIBM7xpr0mFw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrheefgddugecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvuffkfhggtggugfgjsehtqhertddttddvnecuhfhrohhmpeforgigihhm vgcutfhiphgrrhguuceomhgrgihimhgvsegtvghrnhhordhtvggthheqnecuggftrfgrth htvghrnhepgfejtedtjefggfffvdetuedthedtheegheeuteekfeeghfdtteejkeeludeg vddunecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepmh grgihimhgvsegtvghrnhhordhtvggthh X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 29 Jul 2021 08:29:40 -0400 (EDT) Date: Thu, 29 Jul 2021 14:29:38 +0200 From: Maxime Ripard To: Rob Herring Cc: Chen-Yu Tsai , Jernej Skrabec , devicetree@vger.kernel.org, Frank Rowand , linux-arm-kernel@lists.infradead.org, linux-sunxi@googlegroups.com, Felipe Balbi , Greg Kroah-Hartman , linux-usb@vger.kernel.org Subject: Re: [PATCH 35/54] dt-bindings: usb: dwc3: Fix usb-phy check Message-ID: <20210729122938.t432abpl2dm2p46c@gilmour> References: <20210721140424.725744-1-maxime@cerno.tech> <20210721140424.725744-36-maxime@cerno.tech> <20210723221530.GA2684283@robh.at.kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210723221530.GA2684283@robh.at.kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210729_052943_974231_CA6BB057 X-CRM114-Status: GOOD ( 17.50 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Rob, On Fri, Jul 23, 2021 at 04:15:30PM -0600, Rob Herring wrote: > On Wed, Jul 21, 2021 at 04:04:05PM +0200, Maxime Ripard wrote: > > The original binding was allowing any combination of usb2-phy and > > usb3-phy in the phys and phy-names properties. > > > > However, the current binding enforces that those properties must be a > > list of usb2-phy and usb3-phy, with exactly one element, effectively > > making usb2-phy the only value being valid. > > Huh? If 'maxItems' is not specified, then it's the length of 'items' > list. Even if minItems is set? This doesn't really change anything to my issue though. """ - phy-names: from the *Generic PHY* bindings; supported names are "usb2-phy" or "usb3-phy". """ The YAML binding has phy-names: minItems: 1 items: - const: usb2-phy - const: usb3-phy which means that only usb2-phy is accepted (and possibly usb2-phy, usb3-phy) but only usb3-phy isn't anymore, while it was valid according to the original binding and used in multiple DT across multiple vendors (arch/arm64/boot/dts/hisilicon/hi3660.dtsi, arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi) > > Let's rework the properties description to allow either one or two > > element picked with values either usb2-phy or usb3-phy. The rest of the > > tooling makes sure that we don't get any duplicate value, so this should > > be what we want. > > Is it really valid to have only a USB3 PHY and what you want here? That > would mean the USB3 phy also handles USB2, right? IIRC that's how it works for the H6 at least yes. Maxime _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel