linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Ojaswin Mujoo <ojaswin98@gmail.com>
To: Stefan Wahren <stefan.wahren@i2se.com>
Cc: Greg KH <gregkh@linuxfoundation.org>,
	nsaenz@kernel.org, dan.carpenter@oracle.com,
	phil@raspberrypi.com, linux-arm-kernel@lists.infradead.org,
	linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] staging: vchiq: Set $CONFIG_VCHIQ_CDEV to be enabled by default
Date: Thu, 29 Jul 2021 19:50:43 +0530	[thread overview]
Message-ID: <20210729142043.GA25192@ojas> (raw)
In-Reply-To: <ddcc0ba2-edc0-89a9-b20d-ce58b3e548fc@i2se.com>

On Wed, Jul 28, 2021 at 10:21:41PM +0200, Stefan Wahren wrote:
> Am 28.07.21 um 22:06 schrieb Ojaswin Mujoo:
> > On Wed, Jul 28, 2021 at 08:45:55PM +0200, Greg KH wrote:
> >> On Thu, Jul 29, 2021 at 12:07:16AM +0530, Ojaswin Mujoo wrote:
> >>> Before this config was defined, the cdev used to be created
> >>> unconditionally. When an earlier commit introduced this config, the
> >>> default behavior was set to disabled, which might surprise some
> >>> unsuspecting users.  Hence, make this config default to 'Y' to be more
> >>> backward consistent.
> >>>
> >>> Signed-off-by: Ojaswin Mujoo <ojaswin98@gmail.com>
> >>> ---
> >>>  drivers/staging/vc04_services/Kconfig | 1 +
> >>>  1 file changed, 1 insertion(+)
> >>>
> >>> diff --git a/drivers/staging/vc04_services/Kconfig b/drivers/staging/vc04_services/Kconfig
> >>> index 63caa6818d37..2b70c37cdd09 100644
> >>> --- a/drivers/staging/vc04_services/Kconfig
> >>> +++ b/drivers/staging/vc04_services/Kconfig
> >>> @@ -23,6 +23,7 @@ if BCM2835_VCHIQ
> >>>  
> >>>  config VCHIQ_CDEV
> >>>  	bool "VCHIQ Character Driver"
> >>> +	default y
> >>
> >> default y is only if the machine will not work without this option.
> >> Is that the case here?  If not, then please do not have this as the
> >> default.
> > Got it Greg. 
> >
> > From my testing, the Raspberry Pi does seem to boot correctly without
> > this although some userspace libraries might not work. 
> >
> > Since the machine itself works, I guess I'll drop this patch.
> 
> The idea is good, but the patch needs improvement :)
> 
> Acceptable solution might be that BCM2835_VCHIQ selects VCHIQ_CDEV.
Thanks for the suggestion, Stefan. 

So on testing with select, it seems like select defines a hard reverse
dependency i.e if BCM2835_VCHIQ=y then VCHIQ_CDEV=y and it can't be set
to n.

Checking the Kconfig launguae doc, I found that we could use "imply" to
define weak reverse dependencies, such that BCM2835_VCHIQ=y auto selects
VCHIQ_CDEV=y but we can also change it back to n if required. I tested
this out and it seems to work fine. I believe we can se imply here as it
better suits the use case.

Thank you,
Ojaswin
> 
> >
> > Thank you!
> > Ojaswin
> >> thanks,
> >>
> >> greg k-h
> > _______________________________________________
> > linux-arm-kernel mailing list
> > linux-arm-kernel@lists.infradead.org
> > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-07-29 14:22 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-28 18:37 [PATCH 0/2] staging: vchiq: Minor fixups to CONFIG_VCHIQ_CDEV Ojaswin Mujoo
2021-07-28 18:37 ` [PATCH 1/2] staging: vchiq: Set $CONFIG_VCHIQ_CDEV to be enabled by default Ojaswin Mujoo
2021-07-28 18:45   ` Greg KH
2021-07-28 20:06     ` Ojaswin Mujoo
2021-07-28 20:21       ` Stefan Wahren
2021-07-29 14:20         ` Ojaswin Mujoo [this message]
2021-07-28 18:37 ` [PATCH 2/2] staging: vchiq: Add details to $CONFIG_VCHIQ_CDEV help text Ojaswin Mujoo
2021-07-28 18:46   ` Greg KH
2021-07-28 20:00     ` Ojaswin Mujoo
2021-07-28 20:39       ` Stefan Wahren
2021-07-29 13:47         ` Ojaswin Mujoo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210729142043.GA25192@ojas \
    --to=ojaswin98@gmail.com \
    --cc=dan.carpenter@oracle.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=nsaenz@kernel.org \
    --cc=phil@raspberrypi.com \
    --cc=stefan.wahren@i2se.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).