From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9DD2AC4338F for ; Fri, 30 Jul 2021 15:15:05 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6578E60F5C for ; Fri, 30 Jul 2021 15:15:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 6578E60F5C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=6ZVN4zGiYogKIqAidd/Q8OD7hc6MINmuIDxtEPdip8M=; b=xWhkIAVaZIgYi3 uwG71rqTWxUjRblisadZWcnnwOYQT0Z6gjzw836oktpjLOjib5ZwlomHBRtBU8O9sFur0rB8KWT+3 ijmu9d1rl190pMw7izmasdrA9LpeRHgtrUplimvhQtrz9GR4g6mtDPbo0L0s80eObI1Hw+duT0HH/ q95Q6NSHkxxDdqkEoAQ3BsHq34rhqOJGw3e/ojJd51HNtEx79NW501TWN3n2CIM8gXZD16RxW7pL5 jFkjz68YjDwnVB0mjZtvxb6VTgsMRWUXdAVmVcESjTC7ib2iRmoCEQyXIr2bSiLbaX6+4Jfvj8IW+ oh9pHKLv6GB9LZuzTAOg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m9UBs-009Cvk-7S; Fri, 30 Jul 2021 15:12:48 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m9UBn-009CrL-HK for linux-arm-kernel@lists.infradead.org; Fri, 30 Jul 2021 15:12:44 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 36B12113E; Fri, 30 Jul 2021 08:12:40 -0700 (PDT) Received: from slackpad.fritz.box (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 6D9CE3F66F; Fri, 30 Jul 2021 08:12:39 -0700 (PDT) Date: Fri, 30 Jul 2021 16:11:52 +0100 From: Andre Przywara To: Mark Rutland Cc: linux-arm-kernel@lists.infradead.org, Jaxson.Han@arm.com, Wei.Chen@arm.com Subject: Re: [boot-wrapper PATCH 01/12] Ensure `kernel_address` is aligned Message-ID: <20210730161152.42da46af@slackpad.fritz.box> In-Reply-To: <20210729152050.23635-2-mark.rutland@arm.com> References: <20210729152050.23635-1-mark.rutland@arm.com> <20210729152050.23635-2-mark.rutland@arm.com> Organization: Arm Ltd. X-Mailer: Claws Mail 3.17.1 (GTK+ 2.24.31; x86_64-slackware-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210730_081243_679512_CC059946 X-CRM114-Status: GOOD ( 13.26 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 29 Jul 2021 16:20:39 +0100 Mark Rutland wrote: > We accidentally placed the `.align` directive after the `kernel_address` > label, meaning that the label itself isn't necessarily aligned. Place > the `.align` directive first to ensure this. > > Signed-off-by: Mark Rutland Ouch, good catch! Reviewed-by: Andre Przywara Cheers, Andre > --- > arch/aarch64/spin.S | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/aarch64/spin.S b/arch/aarch64/spin.S > index 72603cf..ca05937 100644 > --- a/arch/aarch64/spin.S > +++ b/arch/aarch64/spin.S > @@ -30,8 +30,8 @@ start_no_el3: > mov x2, #0 > bl first_spin > > -kernel_address: > .align 3 > +kernel_address: > .long 0 > > .ltorg _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel