From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A401C432BE for ; Fri, 30 Jul 2021 15:20:22 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D3AA160F5C for ; Fri, 30 Jul 2021 15:20:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org D3AA160F5C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=rWUZ/GbccJFeQ4r7a093MreaE8e9ie1j02N77Z2CJmg=; b=OQe9sQ/yydjEgs fdYrs++XI3drPit9uNZVH36KwaKfy06sVGROLGbKehjJB7oPlm12lQ0DZE/Bhrg3INTINSjb52Thx 8rSrFepLE/KFKgoe6dqAwcztrcmZjzuIkgRPsYE6h7knCLBsfBRULV65dHS79rLzEebFHxByONM5X Ye0PFG8ta9T8Nz9zEe4IvNr0jt9TACkxW1x1cMdHdsbmWAn5Ak0K2tMfmajpLtyF7axYgF886dwOH t11BD+9q7Wazvd+hot+EHWttLlUepn5fZn1tX0MAj3aiVabBRe+4suoLtT3npzbxAn8QTQRHh7KCn 6QYhYJEXjzDDBkNKMF7g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m9UGm-009Epu-P9; Fri, 30 Jul 2021 15:17:53 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m9UD4-009DUp-Uh for linux-arm-kernel@lists.infradead.org; Fri, 30 Jul 2021 15:14:04 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 238D6113E; Fri, 30 Jul 2021 08:14:01 -0700 (PDT) Received: from slackpad.fritz.box (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 54AFE3F66F; Fri, 30 Jul 2021 08:14:00 -0700 (PDT) Date: Fri, 30 Jul 2021 16:13:19 +0100 From: Andre Przywara To: Mark Rutland Cc: linux-arm-kernel@lists.infradead.org, Jaxson.Han@arm.com, Wei.Chen@arm.com Subject: Re: [boot-wrapper PATCH 06/12] Move scripts to a `scripts` directory Message-ID: <20210730161319.06baea39@slackpad.fritz.box> In-Reply-To: <20210729152050.23635-7-mark.rutland@arm.com> References: <20210729152050.23635-1-mark.rutland@arm.com> <20210729152050.23635-7-mark.rutland@arm.com> Organization: Arm Ltd. X-Mailer: Claws Mail 3.17.1 (GTK+ 2.24.31; x86_64-slackware-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210730_081403_219003_EB6AF09C X-CRM114-Status: GOOD ( 16.93 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 29 Jul 2021 16:20:44 +0100 Mark Rutland wrote: > The top-level directory is getting increasingly cluttered. For clarity > let's move the scripts into their own directory. > > There should be no functional change as a result of this patch. Yes, confirmed to be just renaming/moving. Requires autoreconf -i though, of course. Reviewed-by: Andre Przywara Cheers, Andre > > Signed-off-by: Mark Rutland > --- > Makefile.am | 20 +++++++++++--------- > FDT.pm => scripts/FDT.pm | 0 > addpsci.pl => scripts/addpsci.pl | 0 > findbase.pl => scripts/findbase.pl | 0 > findcpuids.pl => scripts/findcpuids.pl | 0 > findmem.pl => scripts/findmem.pl | 0 > 6 files changed, 11 insertions(+), 9 deletions(-) > rename FDT.pm => scripts/FDT.pm (100%) > rename addpsci.pl => scripts/addpsci.pl (100%) > rename findbase.pl => scripts/findbase.pl (100%) > rename findcpuids.pl => scripts/findcpuids.pl (100%) > rename findmem.pl => scripts/findmem.pl (100%) > > diff --git a/Makefile.am b/Makefile.am > index 8334049..ad13dbc 100644 > --- a/Makefile.am > +++ b/Makefile.am > @@ -7,13 +7,15 @@ > # Use of this source code is governed by a BSD-style license that can be > # found in the LICENSE.txt file. > > +SCRIPT_DIR := $(top_srcdir)/scripts > + > # VE > -PHYS_OFFSET := $(shell perl -I $(top_srcdir) $(top_srcdir)/findmem.pl $(KERNEL_DTB)) > -UART_BASE := $(shell perl -I $(top_srcdir) $(top_srcdir)/findbase.pl $(KERNEL_DTB) 0 'arm,pl011') > -SYSREGS_BASE := $(shell perl -I $(top_srcdir) $(top_srcdir)/findbase.pl $(KERNEL_DTB) 0 'arm,vexpress-sysreg' 2> /dev/null) > +PHYS_OFFSET := $(shell perl -I $(SCRIPT_DIR) $(SCRIPT_DIR)/findmem.pl $(KERNEL_DTB)) > +UART_BASE := $(shell perl -I $(SCRIPT_DIR) $(SCRIPT_DIR)/findbase.pl $(KERNEL_DTB) 0 'arm,pl011') > +SYSREGS_BASE := $(shell perl -I $(SCRIPT_DIR) $(SCRIPT_DIR)/findbase.pl $(KERNEL_DTB) 0 'arm,vexpress-sysreg' 2> /dev/null) > CNTFRQ := 0x01800000 # 24Mhz > > -CPU_IDS := $(shell perl -I $(top_srcdir) $(top_srcdir)/findcpuids.pl $(KERNEL_DTB)) > +CPU_IDS := $(shell perl -I $(SCRIPT_DIR) $(SCRIPT_DIR)/findcpuids.pl $(KERNEL_DTB)) > NR_CPUS := $(shell echo $(CPU_IDS) | tr ',' ' ' | wc -w) > > DEFINES = -DCNTFRQ=$(CNTFRQ) > @@ -51,7 +53,7 @@ PSCI_NODE := psci { \ > cpu_on = <$(PSCI_CPU_ON)>; \ > cpu_off = <$(PSCI_CPU_OFF)>; \ > }; > -CPU_NODES := $(shell perl -I $(top_srcdir) $(top_srcdir)/addpsci.pl $(KERNEL_DTB)) > +CPU_NODES := $(shell perl -I $(SCRIPT_DIR) $(SCRIPT_DIR)/addpsci.pl $(KERNEL_DTB)) > else > BOOTMETHOD := spin.o > PSCI_NODE := > @@ -59,14 +61,14 @@ CPU_NODES := > endif > > if GICV3 > -GIC_DIST_BASE := $(shell perl -I $(top_srcdir) $(top_srcdir)/findbase.pl $(KERNEL_DTB) 0 'arm,gic-v3') > -GIC_RDIST_BASE := $(shell perl -I $(top_srcdir) $(top_srcdir)/findbase.pl $(KERNEL_DTB) 1 'arm,gic-v3') > +GIC_DIST_BASE := $(shell perl -I $(SCRIPT_DIR) $(SCRIPT_DIR)/findbase.pl $(KERNEL_DTB) 0 'arm,gic-v3') > +GIC_RDIST_BASE := $(shell perl -I $(SCRIPT_DIR) $(SCRIPT_DIR)/findbase.pl $(KERNEL_DTB) 1 'arm,gic-v3') > DEFINES += -DGIC_DIST_BASE=$(GIC_DIST_BASE) > DEFINES += -DGIC_RDIST_BASE=$(GIC_RDIST_BASE) > GIC := gic-v3.o > else > -GIC_DIST_BASE := $(shell perl -I $(top_srcdir) $(top_srcdir)/findbase.pl $(KERNEL_DTB) 0 'arm,cortex-a15-gic') > -GIC_CPU_BASE := $(shell perl -I $(top_srcdir) $(top_srcdir)/findbase.pl $(KERNEL_DTB) 1 'arm,cortex-a15-gic') > +GIC_DIST_BASE := $(shell perl -I $(SCRIPT_DIR) $(SCRIPT_DIR)/findbase.pl $(KERNEL_DTB) 0 'arm,cortex-a15-gic') > +GIC_CPU_BASE := $(shell perl -I $(SCRIPT_DIR) $(SCRIPT_DIR)/findbase.pl $(KERNEL_DTB) 1 'arm,cortex-a15-gic') > DEFINES += -DGIC_CPU_BASE=$(GIC_CPU_BASE) > DEFINES += -DGIC_DIST_BASE=$(GIC_DIST_BASE) > GIC := gic.o > diff --git a/FDT.pm b/scripts/FDT.pm > similarity index 100% > rename from FDT.pm > rename to scripts/FDT.pm > diff --git a/addpsci.pl b/scripts/addpsci.pl > similarity index 100% > rename from addpsci.pl > rename to scripts/addpsci.pl > diff --git a/findbase.pl b/scripts/findbase.pl > similarity index 100% > rename from findbase.pl > rename to scripts/findbase.pl > diff --git a/findcpuids.pl b/scripts/findcpuids.pl > similarity index 100% > rename from findcpuids.pl > rename to scripts/findcpuids.pl > diff --git a/findmem.pl b/scripts/findmem.pl > similarity index 100% > rename from findmem.pl > rename to scripts/findmem.pl _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel