From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7013C4338F for ; Fri, 30 Jul 2021 17:41:56 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 791E460EE2 for ; Fri, 30 Jul 2021 17:41:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 791E460EE2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=y7vMpA5NVaCUUUOQgNxwFB9rEDcv+JR1IqrrkOnUvWE=; b=3ZspgZsyY0wNqW 8pHlEWMJ9p3fATGBp5kVpGoIHebqVySOvgoKGEvjJCEg2HYg7YA1FlRsFyyhTbU/jOuFWYeY6y7fX z9toyEEldFvOye2vzHdUIAltm3ZYpNeXGNmc5xTMFc1AK77jYRUG//U1omJ5vaaNM9rcVVxiX1L/X 2y0r2+iQNMa3+72tymxVxF9gx0M9TyiDBqBQzy1t/5JDRNOUn9lnRyLrf7TXeRM1XLkhowajj5xwR pyrYGkOUWKC/Nspl0vSnVgeNT1vcMQ5F2iXlBAfYo4yCiQJofhIbvQJNxqV2akjsK/JwDK1YsfMSE 8z3Ev+rRsKMo9F+vZ8JQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m9WUV-009ir2-Gv; Fri, 30 Jul 2021 17:40:11 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m9WUM-009ioQ-4F for linux-arm-kernel@lists.infradead.org; Fri, 30 Jul 2021 17:40:03 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B607D11B3; Fri, 30 Jul 2021 10:40:00 -0700 (PDT) Received: from slackpad.fritz.box (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id F1B423F66F; Fri, 30 Jul 2021 10:39:59 -0700 (PDT) Date: Fri, 30 Jul 2021 18:39:19 +0100 From: Andre Przywara To: Mark Rutland Cc: linux-arm-kernel@lists.infradead.org, Jaxson.Han@arm.com, Wei.Chen@arm.com Subject: Re: [boot-wrapper PATCH 10/12] aarch32: rename `_spin_dead` -> `err_invalid_id` Message-ID: <20210730183919.685432ab@slackpad.fritz.box> In-Reply-To: <20210729152050.23635-11-mark.rutland@arm.com> References: <20210729152050.23635-1-mark.rutland@arm.com> <20210729152050.23635-11-mark.rutland@arm.com> Organization: Arm Ltd. X-Mailer: Claws Mail 3.17.1 (GTK+ 2.24.31; x86_64-slackware-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210730_104002_295559_C494270C X-CRM114-Status: GOOD ( 13.35 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 29 Jul 2021 16:20:48 +0100 Mark Rutland wrote: > For clarity, align aarch32 with aarch64, sending unexpected CPUs to an > `err_invalid_id` loop rather than `_spin_dead`. > > There should be no functional change as a result of this patch. > > Signed-off-by: Mark Rutland Reviewed-by: Andre Przywara Cheers, Andre > --- > arch/aarch32/boot.S | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/aarch32/boot.S b/arch/aarch32/boot.S > index 15e51d4..9e5c308 100644 > --- a/arch/aarch32/boot.S > +++ b/arch/aarch32/boot.S > @@ -21,7 +21,7 @@ ASM_FUNC(_start) > cpuid r0, r1 > bl find_logical_id > cmp r0, #MPIDR_INVALID > - beq _spin_dead > + beq err_invalid_id > > bl setup_stack > > @@ -58,7 +58,7 @@ _monitor: > /* Initialise boot method */ > b start_el3 > > -_spin_dead: > +err_invalid_id: > b . > > .text _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel