From: Leo Yan <leo.yan@linaro.org>
To: Suzuki K Poulose <suzuki.poulose@arm.com>
Cc: linux-arm-kernel@lists.infradead.org, mike.leach@linaro.org,
mathieu.poirier@linaro.org, coresight@lists.linaro.org,
James Clark <james.clark@arm.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Mark Rutland <mark.rutland@arm.com>, Jiri Olsa <jolsa@redhat.com>,
linux-perf-users@vger.kernel.org,
Alexander Shishkin <alexander.shishkin@linux.intel.com>
Subject: Re: [PATCH] tools: perf: Report collisions in AUX records
Date: Sat, 31 Jul 2021 09:38:47 +0800 [thread overview]
Message-ID: <20210731013847.GA91194@leoy-ThinkPad-X240s> (raw)
In-Reply-To: <20210728091219.527886-1-suzuki.poulose@arm.com>
On Wed, Jul 28, 2021 at 10:12:19AM +0100, Suzuki Kuruppassery Poulose wrote:
> Just like the other flags in the AUX records, report a summary
> of the Collisions if there were any.
>
> Cc: Mike Leach <mike.leach@linaro.org>
> Cc: Mathieu Poirier <mathieu.poirier@linaro.org>
> Cc: Leo Yan <leo.yan@linaro.org>
> Cc: James Clark <james.clark@arm.com>
> Cc: Arnaldo Carvalho de Melo <acme@kernel.org>
> Cc: Mark Rutland <mark.rutland@arm.com>
> Cc: Jiri Olsa <jolsa@redhat.com>
> Cc: linux-perf-users@vger.kernel.org
> Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
> Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com>
The change looks good to me:
Reviewed-by: Leo Yan <leo.yan@linaro.org>
> ---
> tools/perf/util/events_stats.h | 1 +
> tools/perf/util/session.c | 9 +++++++++
> 2 files changed, 10 insertions(+)
>
> diff --git a/tools/perf/util/events_stats.h b/tools/perf/util/events_stats.h
> index 3480bafd414b..1b0006092265 100644
> --- a/tools/perf/util/events_stats.h
> +++ b/tools/perf/util/events_stats.h
> @@ -30,6 +30,7 @@ struct events_stats {
> u64 total_lost_samples;
> u64 total_aux_lost;
> u64 total_aux_partial;
> + u64 total_aux_collision;
> u64 total_invalid_chains;
> u32 nr_events[PERF_RECORD_HEADER_MAX];
> u32 nr_lost_warned;
> diff --git a/tools/perf/util/session.c b/tools/perf/util/session.c
> index 51f727402912..59b6c3fe0d01 100644
> --- a/tools/perf/util/session.c
> +++ b/tools/perf/util/session.c
> @@ -1540,6 +1540,8 @@ static int machines__deliver_event(struct machines *machines,
> evlist->stats.total_aux_lost += 1;
> if (event->aux.flags & PERF_AUX_FLAG_PARTIAL)
> evlist->stats.total_aux_partial += 1;
> + if (event->aux.flags & PERF_AUX_FLAG_COLLISION)
> + evlist->stats.total_aux_collision += 1;
> }
> return tool->aux(tool, event, sample, machine);
> case PERF_RECORD_ITRACE_START:
> @@ -1895,6 +1897,13 @@ static void perf_session__warn_about_errors(const struct perf_session *session)
> "");
> }
>
> + if (session->tool->aux == perf_event__process_aux &&
> + stats->total_aux_collision != 0) {
> + ui__warning("AUX data detected collision %" PRIu64 " times out of %u!\n\n",
> + stats->total_aux_collision,
> + stats->nr_events[PERF_RECORD_AUX]);
> + }
> +
> if (stats->nr_unknown_events != 0) {
> ui__warning("Found %u unknown events!\n\n"
> "Is this an older tool processing a perf.data "
> --
> 2.24.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-07-31 1:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210723124456.3828769-1-suzuki.poulose@arm.com>
2021-07-28 9:12 ` [PATCH] tools: perf: Report collisions in AUX records Suzuki K Poulose
2021-07-31 1:38 ` Leo Yan [this message]
2021-09-02 19:25 ` Mathieu Poirier
2021-09-03 11:01 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210731013847.GA91194@leoy-ThinkPad-X240s \
--to=leo.yan@linaro.org \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=coresight@lists.linaro.org \
--cc=james.clark@arm.com \
--cc=jolsa@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mathieu.poirier@linaro.org \
--cc=mike.leach@linaro.org \
--cc=suzuki.poulose@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox