Re: [PATCH v2 04/24] iommu/vt-d: Drop IOVA cookie management

Lu Baolu
2021-07-30T06:11:26Z

On 7/28/21 11:58 PM, Robin Murphy wrote:
> The core code bakes its own cookies now.
>
> Signed-off-by: Robin Murphy <robin.murphy@arm.com>
> ---
> drivers/iommu/intel/iommu.c | 8 --------
> 1 file changed, 8 deletions(-)
>
> diff --git a/drivers/iommu/intel/iommu.c b/drivers/iommu/intel/iommu.c
> index c12cc955389a..7e168634c433 100644
> --- a/drivers/iommu/intel/iommu.c
> +++ b/drivers/iommu/intel/iommu.c
> @@ -1979,10 +1979,6 @@ static void domain_exit(struct dmar_domain *domain)
> /* Remove associated devices and clear attached or cached domains */
> domain_remove_dev_info(domain);
>
> - /* destroy iovas */
> - if (domain->domain.type == IOMMU_DOMAIN_DMA)
> - iommu_put_dma_cookie(&domain->domain);
> -
> if (domain->pgd) {
> struct page *freelist;
>
> @@ -4544,10 +4540,6 @@ static struct iommu_domain *intel_iommu_domain_alloc(unsigned type)
> return NULL;
> }
>
> - if (type == IOMMU_DOMAIN_DMA &&
> - iommu_get_dma_cookie(&dmar_domain->domain))
> - return NULL;
> -
> domain = &dmar_domain->domain;
> domain->geometry.aperture_start = 0;
> domain->geometry.aperture_end =
>

Reviewed-by: Lu Baolu <baolu.lu@linux.intel.com>

Best regards,
baolu