Re: [PATCH v2 11/24] iommu/virtio: Drop IOVA cookie management

Jean-Philippe Brucker
2021-07-30T09:23:13Z

On Wed, Jul 28, 2021 at 04:58:32PM +0100, Robin Murphy wrote:
> The core code bakes its own cookies now.
>
> CC: Jean-Philippe Brucker <jean-philippe@linaro.org>
> Signed-off-by: Robin Murphy <robin.murphy@arm.com>

Reviewed-by: Jean-Philippe Brucker <jean-philippe@linaro.org>

Also tested on the Seattle (vsmmuv3/viommu with lazy/strict, still need to
test the runtime switch).

> ---
> drivers/iommu/virtio-iommu.c | 8 --------
> 1 file changed, 8 deletions(-)
>
> diff --git a/drivers/iommu/virtio-iommu.c b/drivers/iommu/virtio-iommu.c
> index 6abdcab7273b..80930ce04a16 100644
> --- a/drivers/iommu/virtio-iommu.c
> +++ b/drivers/iommu/virtio-iommu.c
> @@ -598,12 +598,6 @@ static struct iommu_domain *viommu_domain_alloc(unsigned type)
> spin_lock_init(&vdomain->mappings_lock);
> vdomain->mappings = RB_ROOT_CACHED;
>
> - if (type == IOMMU_DOMAIN_DMA &&
> - iommu_get_dma_cookie(&vdomain->domain)) {
> - kfree(vdomain);
> - return NULL;
> - }
> -
> return &vdomain->domain;
> }
>
> @@ -643,8 +637,6 @@ static void viommu_domain_free(struct iommu_domain *domain)
> {
> struct viommu_domain *vdomain = to_viommu_domain(domain);
>
> - iommu_put_dma_cookie(domain);
> -
> /* Free all remaining mappings (size 2^64) */
> viommu_del_mappings(vdomain, 0, 0);
>
> --
> 2.25.1
>
> _______________________________________________
> iommu mailing list
> iommu@lists.linux-foundation.org
> https://lists.linuxfoundation.org/mailman/listinfo/iommu