Re: [PATCH v2 18/24] iommu: Express DMA strictness via the domain type

Lu Baolu
2021-07-29T07:17:44Z

Hi Robin,

On 7/28/21 11:58 PM, Robin Murphy wrote:
> diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c
> index 982545234cf3..eecb5657de69 100644
> --- a/drivers/iommu/iommu.c
> +++ b/drivers/iommu/iommu.c
> @@ -136,6 +136,9 @@ static int __init iommu_subsys_init(void)
> }
> }
>
> + if (!iommu_default_passthrough() && !iommu_dma_strict)
> + iommu_def_domain_type = IOMMU_DOMAIN_DMA_FQ;

iommu_dma_strict could be changed later by the vendor iommu driver via
iommu_set_dma_strict(). This seems not to be the right place to set
iommu_def_domain_type.

> +
> pr_info("Default domain type: %s %s\n",
> iommu_domain_type_str(iommu_def_domain_type),
> (iommu_cmd_line & IOMMU_CMD_LINE_DMA_API) ?

Best regards,
baolu