From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B4D0C4338F for ; Wed, 4 Aug 2021 10:16:44 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4FD3C60243 for ; Wed, 4 Aug 2021 10:16:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 4FD3C60243 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=89mYdSiyI90yIBdnivdffD+ouWUvkMfh28tyjhdh4A0=; b=iwxELWwsDlzBvI h56KhobvM51EQ79L45NO0ZOflqsPlEu5tHy3PV6KqFCjYJvP2gmt9AsyX5eIGEMvxiJwVxdjn622m cYVO5Fsx8me0G6+TJ9zH9JfTPaA4TeJVyQGwpGC91T/RFNfVbBbsfJn7yDkPJWI06EWPkOmtUYtgV 8opLtNSBQOiLyBxMkr72m8HIsmRjFhMCvFs8zUVvQRTiyOP4vyBhfITkwurin/ZcvhLYv+mMYq9PP jKAM1UujMHSWSmgeHHopIuYzTtNvvrn6me1yHPHMEKDCLpcyLa4q6rSbXrgS0Y10ecxsq8KB4XELO VmqG3MFXDSLYeVEqEZWw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mBDur-005fGG-8S; Wed, 04 Aug 2021 10:14:26 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mBDui-005fA5-Vm for linux-arm-kernel@lists.infradead.org; Wed, 04 Aug 2021 10:14:18 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=hthaXayFsAFuO4fgMsEzj4PkQ40X+DJilzikZbi39ck=; b=v1C/YnksCL/7UjCynklphOGHw B8DZFolIHZHedAANNrkCQYpGq9jpYEIKeP6GEy8GrhIpZnT8xASeQRhOUuXVO4I1wG9sjiBSsb5tX DnhniUTWtO+ENmJmu9INyHjNSCV4x4TCdTOlSaccEEVI6YQb0Er587hOLW4lTXp6JLmLjDzLtuS3l puk1pGsvo/I1VBovWzN8cjn3SZM2RCGW0opFHD9VqP9eg6uTgbVsh34bPVlL+IDMA+9TWN+bZ4g94 itTRiLfvgeLImtKcdooqOGMkmwy+Yg4AIZ+Tdqf5Sv/dh14RQn9BcoB2IqG5mD/1gfgqs71bOIJFt /D69kAYVQ==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:46930) by pandora.armlinux.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mBDuW-0008W5-9E; Wed, 04 Aug 2021 11:14:05 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1mBDuQ-0004iR-T1; Wed, 04 Aug 2021 11:13:58 +0100 Date: Wed, 4 Aug 2021 11:13:58 +0100 From: "Russell King (Oracle)" To: cgel.zte@gmail.com Cc: yong.yiran@zte.com.cn, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Zeal Robot Subject: Re: [PATCH linux-next] 'linux/tty.h' included in 'hackkit.c' is duplicated. It is also included in the 21th line. Message-ID: <20210804101358.GO22278@shell.armlinux.org.uk> References: <20210804093907.618719-1-yong.yiran@zte.com.cn> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210804093907.618719-1-yong.yiran@zte.com.cn> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210804_031417_065533_6111189D X-CRM114-Status: GOOD ( 18.06 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Aug 04, 2021 at 02:39:07AM -0700, cgel.zte@gmail.com wrote: > From: yong yiran > > Reported-by: Zeal Robot > Signed-off-by: yong yiran Hi, The commit message and summary(subject) could do with some improvement: 1) I don't think having "It is also included in the 21th line." in the summary adds value. 2) Maybe the summary should be "Remove duplicated 'linux/tty.h' include in 'hackkit.c'" 3) the commit message should say something, maybe along the lines of: "Remove all but the first include of linux/tty.h from hackkit.c." Thanks. > --- > arch/arm/mach-sa1100/hackkit.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/arch/arm/mach-sa1100/hackkit.c b/arch/arm/mach-sa1100/hackkit.c > index 3085f1c2e586..3fe34ee7c0ab 100644 > --- a/arch/arm/mach-sa1100/hackkit.c > +++ b/arch/arm/mach-sa1100/hackkit.c > @@ -18,7 +18,6 @@ > #include > #include > #include > -#include > #include > #include > #include > -- > 2.25.1 > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel > -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel