From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B12DFC4338F for ; Thu, 5 Aug 2021 16:39:00 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 77E8E61050 for ; Thu, 5 Aug 2021 16:39:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 77E8E61050 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=qbHFj2pIAN1njZHVS2APcbqfYgXUhj2R/OPfXKMLpJI=; b=ahT/ho+Yonnq7E r3N7Jwsk2RHthnCgu+Ym5NASY8oTAs8LjGWqpj/qUMREpwYZAfYphfQeMMZZ9HN8W94KMa+PXdlZc aycQ/vDqjqCZ7RVRjd/BryHm8YSIxFYWjkM/5Ibxm2rEPWCGayzwnXvl8BUqd+oOtnVDxsTQF8KtJ 2aotY3MtvzDwOxnGb2CgcvgqMnAgPaCQe8Dj5GTaKSESQ3q/YB4EICtR85rUeh6cQYQLNXG97Wp9S 5w0bJx4Dt25TlD80p6KefFY1F1X2cOcHkVY8xZK/gHIWjWKAFq6KvfYQGfPmWSWxwSXz0bkEgSd0+ uusMGwZvOWS3XNMZbOuQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mBgN7-00AGrN-QU; Thu, 05 Aug 2021 16:37:30 +0000 Received: from mail-pj1-x1030.google.com ([2607:f8b0:4864:20::1030]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mBgN4-00AGqf-4R for linux-arm-kernel@lists.infradead.org; Thu, 05 Aug 2021 16:37:27 +0000 Received: by mail-pj1-x1030.google.com with SMTP id o44-20020a17090a0a2fb0290176ca3e5a2fso10894257pjo.1 for ; Thu, 05 Aug 2021 09:37:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=ScCSrb+0LlElQBDZymqW4N+GFGFpMM8jxuWTV0UN0ys=; b=Jq0q2K+Yrtw+0B/X0gAkJfeVD9YOMZeEG6YZmvQrAiA+EDZ9q3MyoKDSXKaFKwo3JU BZxgewbkNDqUGKH8AD+AvDOdLFsfan1cRt5uah5iSpqIxhmVnuQpL41kvNaTuzETq1GA 3MjYMTKx4Vga4iNe4mBN97LoF8mEXPxB0+CCNsqkNjfKyGplFtuwAKS7rcnYahbLJbui cxNwt0L1Z44gr2Gl2D2x0CFBftpEUda/4d3y3UTcoNTAzux7kZBRfBgjwMgFUt+rgYQe 0amb4iNXhdlipM8PhZvnrbsk/RVjPmufcdiNJCFf2VIAK3uDCgFf9Q9J+CdtC5IvK7GD HR2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=ScCSrb+0LlElQBDZymqW4N+GFGFpMM8jxuWTV0UN0ys=; b=fnpTu2w2F7rCbjAJrMAKg8pjLKWEElxdKq2W79RP54MqookijAa/OaPXOjvuynjlNH qEf0hErTf7ppElhakSSwhhqrSXawS0ZtW4AlDYc7sTOKUAgZhDgoOrCFdOxdL+X+BwKZ /dkfDhTukDz6icUlazS3H9qhk5EGz7wfhSFyHTkOMaDogDxqUxaXm3DKuUwtAsDNGWNY mLnHF1+Q0hANjKm3R4g0khnh73wplgI6Mnpl976qOB919JWUbHKbLjIM6mtO55FOeQct qXkPF4uOfIB0LqEnhtIN06I+Pcp/5pr6nFTN2Jb4mjlU7Nd9deyMpotR2Y3uxBQXS+ES xbXg== X-Gm-Message-State: AOAM532Vpoc8McDnchxBFXGYGtCHuWpmp4hToUUy0nvtntaDEBDYg7SB snM7ZEza4fNU5K8b5Yd+6mTtGw== X-Google-Smtp-Source: ABdhPJz3U5WBhG6HDzWmDkcO9tCnQS+NsBaAwcTZpQCR+8C1giZ3HKcGcTxyHZaT46ODcbTJxYLPbA== X-Received: by 2002:a17:90b:8c5:: with SMTP id ds5mr16367049pjb.212.1628181445659; Thu, 05 Aug 2021 09:37:25 -0700 (PDT) Received: from p14s (S0106889e681aac74.cg.shawcable.net. [68.147.0.187]) by smtp.gmail.com with ESMTPSA id w9sm7265985pfg.151.2021.08.05.09.37.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Aug 2021 09:37:25 -0700 (PDT) Date: Thu, 5 Aug 2021 10:37:23 -0600 From: Mathieu Poirier To: Dong Aisheng Cc: linux-remoteproc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, ohad@wizery.com, dongas86@gmail.com, bjorn.andersson@linaro.org, cleger@kalray.eu, peng.fan@nxp.com Subject: Re: [PATCH v3 1/5] remoteproc: fix the wrong default value of is_iomem Message-ID: <20210805163723.GD3205691@p14s> References: <20210805033206.1295269-1-aisheng.dong@nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210805033206.1295269-1-aisheng.dong@nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210805_093726_218772_B69D8905 X-CRM114-Status: GOOD ( 20.00 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Please respin this set with all the RB and TB tags. Thanks, Mathieu On Thu, Aug 05, 2021 at 11:32:02AM +0800, Dong Aisheng wrote: > Currently the is_iomem is a random value in the stack which may > be default to true even on those platforms that not use iomem to > store firmware. > > Cc: Bjorn Andersson > Cc: Mathieu Poirier > Fixes: 40df0a91b2a5 ("remoteproc: add is_iomem to da_to_va") > Reviewed-by: Peng Fan > Signed-off-by: Dong Aisheng > --- > v2->v3: > * no changes > v1->v2: > * update rproc_copy_segment as well > --- > drivers/remoteproc/remoteproc_coredump.c | 2 +- > drivers/remoteproc/remoteproc_elf_loader.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/remoteproc/remoteproc_coredump.c b/drivers/remoteproc/remoteproc_coredump.c > index aee657cc08c6..c892f433a323 100644 > --- a/drivers/remoteproc/remoteproc_coredump.c > +++ b/drivers/remoteproc/remoteproc_coredump.c > @@ -152,8 +152,8 @@ static void rproc_copy_segment(struct rproc *rproc, void *dest, > struct rproc_dump_segment *segment, > size_t offset, size_t size) > { > + bool is_iomem = false; > void *ptr; > - bool is_iomem; > > if (segment->dump) { > segment->dump(rproc, segment, dest, offset, size); > diff --git a/drivers/remoteproc/remoteproc_elf_loader.c b/drivers/remoteproc/remoteproc_elf_loader.c > index e8078efb3dec..3cd1798f17a3 100644 > --- a/drivers/remoteproc/remoteproc_elf_loader.c > +++ b/drivers/remoteproc/remoteproc_elf_loader.c > @@ -178,8 +178,8 @@ int rproc_elf_load_segments(struct rproc *rproc, const struct firmware *fw) > u64 filesz = elf_phdr_get_p_filesz(class, phdr); > u64 offset = elf_phdr_get_p_offset(class, phdr); > u32 type = elf_phdr_get_p_type(class, phdr); > + bool is_iomem = false; > void *ptr; > - bool is_iomem; > > if (type != PT_LOAD) > continue; > -- > 2.25.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel