From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A205C4338F for ; Fri, 6 Aug 2021 09:10:47 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D941261159 for ; Fri, 6 Aug 2021 09:10:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org D941261159 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Jbr8Ohg9SOqoMnDXwpUdKkjYw3B49N1C90CS2DuBdAQ=; b=j0Q/A126niLXi8 Pgrd+pba4xuok4EHNkKbuqE03Kp/fYvZ/SNFyUxUKYpGDJ3YdmynTn0KsW6ZMRpQrldspISw6BVRY jAu0LVTlx84OUJRwbx4yO/xD+oaeUpbiWBVxJcin/je31LfAwes/LKnovGgNieU0TAQgLahCS+0GZ ++FVDfPr6rr23upVOCI3QwIwRsmJcUMz3bWt1Z0Msf3EOBAuUgZsDLisn9mfkEwMeOA/nd93seC6+ g1AdkXOM4KFm9eQILVTymAW9WGd6y9MRI6fN+bjBgmIE/jbZcuaie6xVGk9BSwrQuCHCMtPlANy7I UZEuy1sA/DX9DNbn9Ceg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mBvqt-00BxyO-Cn; Fri, 06 Aug 2021 09:09:15 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mBvqq-00Bxxz-7Z for linux-arm-kernel@lists.infradead.org; Fri, 06 Aug 2021 09:09:13 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 353E6611C3; Fri, 6 Aug 2021 09:09:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1628240951; bh=2l+E2zrkCunpqaj+ispm+F8f+rlHHzGK0VEc6bKhVwg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=dFy30B6fB0NTNTTVXgDBaDrC1hr2SauA4MXGbv0XvPKUrNuh+X5sAd3/smAqcTLWO gb4dAun6MWkZhhKdcxsXNxi00z6nny2s+FoQ5m3WKXLvOJ8hRKYyCYJTIMKEDTlxGz nV46WXRJ5ayWJSMLJ0xs/nnSGoeQsWbE3D34nL/eZyBM7h9Sy9ptarEAVwkwfjclrL g05wzQimhFcS4eJvYoh/5VL6v2FaDqh+woIxP+L2OghS8PVCKgHHtVnEDtPS1dlkxm eqdd95ndRtbjVpZLVSTqelsPml14OoogxukB58TVg1HoB+4kjwKIwZdC+g2ReOjy6L zW20CXTHuhBYA== Date: Fri, 6 Aug 2021 10:09:07 +0100 From: Will Deacon To: Mark Brown Cc: Catalin Marinas , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] arm64: entry: Add SYM_CODE annotation for __bad_stack Message-ID: <20210806090907.GA2254@willie-the-truck> References: <20210804181710.19059-1-broonie@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210804181710.19059-1-broonie@kernel.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210806_020912_332721_EC1AB621 X-CRM114-Status: GOOD ( 18.39 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Aug 04, 2021 at 07:17:10PM +0100, Mark Brown wrote: > When converting arm64 to modern assembler annotations __bad_stack was left > as a raw local label without annotations. While this will have little if > any practical impact at present it may cause issues in the future if we > start using the annotations for things like reliable stack trace. Add > SYM_CODE annotations to fix this. > > Signed-off-by: Mark Brown > --- > arch/arm64/kernel/entry.S | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/arch/arm64/kernel/entry.S b/arch/arm64/kernel/entry.S > index 923ee2ac85fd..572f72f20646 100644 > --- a/arch/arm64/kernel/entry.S > +++ b/arch/arm64/kernel/entry.S > @@ -535,12 +535,13 @@ SYM_CODE_START(vectors) > SYM_CODE_END(vectors) > > #ifdef CONFIG_VMAP_STACK > +SYM_CODE_START_LOCAL(__bad_stack) > /* > * We detected an overflow in kernel_ventry, which switched to the > * overflow stack. Stash the exception regs, and head to our overflow > * handler. > */ > -__bad_stack: > + > /* Restore the original x0 value */ > mrs x0, tpidrro_el0 > > @@ -560,6 +561,7 @@ __bad_stack: > /* Time to die */ > bl handle_bad_stack > ASM_BUG() > +SYM_CODE_END(__bad_stack) > #endif /* CONFIG_VMAP_STACK */ Acked-by: Will Deacon Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel