From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E98F4C4338F for ; Fri, 6 Aug 2021 22:14:54 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8F9EF61179 for ; Fri, 6 Aug 2021 22:14:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 8F9EF61179 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Owner; bh=tixwGB5fIzxrIUpvGqegFabDS2/EirCSCmFcY0CZ9r4=; b=wfYGnEHvq0ELlP uCWcHGOSjOC+QOaewhVPv8Sji8e9+fGz8MQW5YDpK3zBJakvQk2z8i9ihQFMN0HP34epfh/ZcDBTv NrWKt5LVNL1oQR5Me1iHU4UKD9Id/RLKUJzZCGerX7TtOmB3WTP1uvRzAhCFaMEDvMqZ2OgVEqfpd m3Sr6rPOqnoukLv2QFOe58X5NsvB5JtanoRJynBfVqLfCPk2s1iZ7TTJyAouL7Qk0vuHZ2x7Ta5br LFKw3U6Q1fPusKjFY/6scTR2oZyky8w+2u1uiiGfqlKc5LU6ZidG8ZnpB4Rn+rflyCu+QNOet6K4L NxW0ePFFReIb0iCIk2Hg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mC85P-00Djyi-PR; Fri, 06 Aug 2021 22:13:03 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mC85L-00Djy1-58; Fri, 06 Aug 2021 22:13:00 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 291E761179; Fri, 6 Aug 2021 22:12:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1628287978; bh=ntBblkw27DzG1SDuhwy9/ADL5F68jkVcbJJtcTu4720=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=nTUpXNwatcS8bNHyLfP0yBfT8MRCkrXawEWlGkn+Y7ZWiwzgz/Fo7WGrVHb5Zu2Nf /7g+YxnSxlnrDJ3YyFMOLHgmurdVnQRU59bID88Ia6SAOlaKPyax6Yua+aqsxPfB5d zL2mZ/ospnIZW4FLU82UBzvdaOLSkK8ls6vRWHWyANh3AMakQAeDkQyo/uBIdVddZ3 w/DuweOx1bZrolnnKh2FbjE4lQLirPjj0/jWNTmdiFe0N4Z04Gmqg+ZRKNr5qLLVJ6 P5FpBeQFVJ5tcEgY2dnjA9ymLy7XqOmHQulbUH2rH8LWMsISaGTeC8t/IREtcqYSSL aejk4FTUA+TiQ== Date: Fri, 6 Aug 2021 17:12:56 -0500 From: Bjorn Helgaas To: Jeremy Linton Cc: linux-pci@vger.kernel.org, lorenzo.pieralisi@arm.com, nsaenz@kernel.org, bhelgaas@google.com, rjw@rjwysocki.net, lenb@kernel.org, robh@kernel.org, kw@linux.com, f.fainelli@gmail.com, bcm-kernel-feedback-list@broadcom.com, linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rpi-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/3] PCI/ACPI: Add new quirk detection, enable bcm2711 Message-ID: <20210806221256.GA1891371@bjorn-Precision-5520> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210805211200.491275-4-jeremy.linton@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210806_151259_263942_9FD7232D X-CRM114-Status: GOOD ( 21.86 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org In subject, this or similar would match history: PCI/ACPI: Add Broadcom bcm2711 MCFG quirk On Thu, Aug 05, 2021 at 04:12:00PM -0500, Jeremy Linton wrote: > Now that we have a bcm2711 quirk, we need to be able to > detect it when the MCFG is missing. Use a namespace > property as an alternative to the MCFG OEM. Rewrap to use ~75 columns. Mention the DT namespace property here. > Signed-off-by: Jeremy Linton > --- > drivers/acpi/pci_mcfg.c | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > > diff --git a/drivers/acpi/pci_mcfg.c b/drivers/acpi/pci_mcfg.c > index 53cab975f612..7d77fc72c2a4 100644 > --- a/drivers/acpi/pci_mcfg.c > +++ b/drivers/acpi/pci_mcfg.c > @@ -169,6 +169,9 @@ static struct mcfg_fixup mcfg_quirks[] = { > ALTRA_ECAM_QUIRK(1, 13), > ALTRA_ECAM_QUIRK(1, 14), > ALTRA_ECAM_QUIRK(1, 15), > + > + { "bcm2711", "", 0, 0, MCFG_BUS_ANY, &bcm2711_pcie_ops, > + DEFINE_RES_MEM(0xFD500000, 0xA000) }, > }; > > static char mcfg_oem_id[ACPI_OEM_ID_SIZE]; > @@ -198,8 +201,19 @@ static void pci_mcfg_apply_quirks(struct acpi_pci_root *root, > u16 segment = root->segment; > struct resource *bus_range = &root->secondary; > struct mcfg_fixup *f; > + const char *soc; > int i; > > + /* > + * This could be a machine with a PCI/SMC conduit, > + * which means it doens't have MCFG. Get the machineid from > + * the namespace definition instead. s/SMC/SMCCC/ ? Cover letter uses SMCCC (not sure it's relevant anyway) s/doens't/doesn't/ Rewrap comment to use ~80 columns. Seems pretty reasonable that a platform without standard ECAM might not have MCFG, since MCFG basically implies ECAM. Is "linux,pcie-quirk" the right property to look for? It doesn't sound very generic, and it doesn't sound like anything related to ECAM. Is it new? I don't see it in the tree yet. Should it be in Documentation/devicetree/bindings/pci/pci.txt so we don't get a different property name for every new platform? > + */ > + if (!fwnode_property_read_string(acpi_fwnode_handle(root->device), > + "linux,pcie-quirk", &soc)) { > + memcpy(mcfg_oem_id, soc, ACPI_OEM_ID_SIZE); > + } > + > for (i = 0, f = mcfg_quirks; i < ARRAY_SIZE(mcfg_quirks); i++, f++) { > if (pci_mcfg_quirk_matches(f, segment, bus_range)) { > if (f->cfgres.start) > -- > 2.31.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel