From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 49D8FC4338F for ; Sun, 8 Aug 2021 13:53:47 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 03C8260ED6 for ; Sun, 8 Aug 2021 13:53:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 03C8260ED6 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=YZi8UZWVxAGGZTHfbnQmXtX56vu4eUW6M4ScSesztLo=; b=qYgHRhK3N4rG25 XLqkMwmnZPqJOz2tj0Bip2xVXE6C4ggwux8ZRUW9AfDXh7KAFsjmXmDaePeK0TIyMeiowHRpOeTrs DwdQKAaSWMiFisaQPxUiR6l7AB6qHYcaQhR6XBlL8o/NSJFuVaHk9o5ed8IbkcE6NobZ9YLKiuKRv AZc+lWL+L51c02CP1NqOLykhn93dfXgECpHfGGMjFrMIk0OfPA8HW37kRqOjQFnCB/j8ooRIYEFCc Kyyz9z93Hd3hkNYhd/5PyXD3/bElAmGviDc4L9kp+Gl0t54fE67RGsf+ilfn/bOLP/yEYFsmn8PIR /rhLVCG2gf1wsHkGqZ1g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mCjDR-00Fwmx-Bv; Sun, 08 Aug 2021 13:51:49 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mCjDN-00FwmG-L7 for linux-arm-kernel@lists.infradead.org; Sun, 08 Aug 2021 13:51:46 +0000 Received: from jic23-huawei (cpc108967-cmbg20-2-0-cust86.5-4.cable.virginm.net [81.101.6.87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id EE0E060ED6; Sun, 8 Aug 2021 13:51:41 +0000 (UTC) Date: Sun, 8 Aug 2021 14:54:31 +0100 From: Jonathan Cameron To: Tang Bin Cc: knaack.h@gmx.de, lars@metafoo.de, shawnguo@kernel.org, s.hauer@pengutronix.de, festevam@gmail.com, linux-iio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Zhang Shengju Subject: Re: [PATCH v2] iio: adc: fsl-imx25-gcq: fix the right check and simplify code Message-ID: <20210808145431.5164b2d8@jic23-huawei> In-Reply-To: <20210802120929.33760-1-tangbin@cmss.chinamobile.com> References: <20210802120929.33760-1-tangbin@cmss.chinamobile.com> X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210808_065145_764799_AD21E6AE X-CRM114-Status: GOOD ( 24.24 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, 2 Aug 2021 20:09:29 +0800 Tang Bin wrote: > For the function of platform_get_irq(), the example in platform.c is > * int irq = platform_get_irq(pdev, 0); > * if (irq < 0) > * return irq; > the return value of zero is unnecessary to check, so make the right > check and simplify code. > > Co-developed-by: Zhang Shengju > Signed-off-by: Zhang Shengju > Signed-off-by: Tang Bin Applied. I tweaked the message an title to make it clear this isn't a fix, but rather a little clean up with no functional affect. Thanks, Jonathan > --- > Changes from v1 > - change the code to the original place and make it simple. > - change the commit message. > --- > drivers/iio/adc/fsl-imx25-gcq.c | 9 +++------ > 1 file changed, 3 insertions(+), 6 deletions(-) > > diff --git a/drivers/iio/adc/fsl-imx25-gcq.c b/drivers/iio/adc/fsl-imx25-gcq.c > index 8cb51cf7a..2cdf45aa8 100644 > --- a/drivers/iio/adc/fsl-imx25-gcq.c > +++ b/drivers/iio/adc/fsl-imx25-gcq.c > @@ -336,14 +336,11 @@ static int mx25_gcq_probe(struct platform_device *pdev) > goto err_vref_disable; > } > > - priv->irq = platform_get_irq(pdev, 0); > - if (priv->irq <= 0) { > - ret = priv->irq; > - if (!ret) > - ret = -ENXIO; > + ret = platform_get_irq(pdev, 0); > + if (ret < 0) > goto err_clk_unprepare; > - } > > + priv->irq = ret; > ret = request_irq(priv->irq, mx25_gcq_irq, 0, pdev->name, priv); > if (ret) { > dev_err(dev, "Failed requesting IRQ\n"); _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel