From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-21.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E6D69C4338F for ; Sun, 8 Aug 2021 15:09:49 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8187E6023E for ; Sun, 8 Aug 2021 15:09:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 8187E6023E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=YEtY3HQ95WN4faAcZ/gLrgUiCLyAkBFAdJCkjNBEqCI=; b=P+nqTi2DgITy9H 6wSMxhEfMK/YyUFja2bYipx8ZEN4xmHy7FNV2jl/2tMZSJG/3j3Ag599fPeU8DDQlIEL9rBgc+bPW 5XFWaX2EZ5RCo5ZmjN0Zp1CLhCWZef7WftQq7X6JMtrd6R9lqEChpHOM8VopK8t0yayb6HJSmC24x wpf/uLxuWORMekOvgpalEmwzQND0DlytL3oDx45BGKth4VSmOZIno49hEiehG1ZISWCgF7pkjUtf1 gxkNXleii3SNhEJo0DHEm37N5ftbyJhrtYxPBstCQTXFOvNS3EkLvT3Ln4zGjswJkIr8h4xsvTIMx dCa3iJQvi6dQKpYAlyNw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mCkPD-00G0eT-PH; Sun, 08 Aug 2021 15:08:03 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mCkP5-00G0cq-Ni for linux-arm-kernel@lists.infradead.org; Sun, 08 Aug 2021 15:08:00 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 6C58F6D; Sun, 8 Aug 2021 08:07:49 -0700 (PDT) Received: from e120937-lin (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 06D223F718; Sun, 8 Aug 2021 08:07:47 -0700 (PDT) Date: Sun, 8 Aug 2021 16:07:41 +0100 From: Cristian Marussi To: Sudeep Holla Cc: Igor Skalkin , kbuild-all@lists.01.org, linux-kernel@vger.kernel.org, kernel test robot , Peter Hilber , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] firmware: arm_scmi: fix boolconv.cocci warnings Message-ID: <20210808150741.GW6592@e120937-lin> References: <202108080108.k5pHZ040-lkp@intel.com> <20210807173127.GA43248@a24dbc127934> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210807173127.GA43248@a24dbc127934> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210808_080755_860293_61712943 X-CRM114-Status: GOOD ( 14.42 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, Aug 08, 2021 at 01:31:27AM +0800, kernel test robot wrote: > From: kernel test robot > > drivers/firmware/arm_scmi/virtio.c:225:40-45: WARNING: conversion to bool not needed here > > Remove unneeded conversion to bool > > Semantic patch information: > Relational and logical operators evaluate to bool, > explicit conversion is overly verbose and unneeded. > > Generated by: scripts/coccinelle/misc/boolconv.cocci > > CC: Igor Skalkin > Reported-by: kernel test robot > Signed-off-by: kernel test robot > --- > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/sudeep.holla/linux.git for-next/scmi > head: 1e7cbfaa66d39e78bd24df0c78b55df68176b59e > commit: 46abe13b5e3db187e52cd0de06c07bbce010726c [23/24] firmware: arm_scmi: Add virtio transport > :::::: branch date: 2 days ago > :::::: commit date: 2 days ago > > virtio.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > --- a/drivers/firmware/arm_scmi/virtio.c > +++ b/drivers/firmware/arm_scmi/virtio.c > @@ -222,7 +222,7 @@ static bool virtio_chan_available(struct > return false; > } > > - return vioch && !vioch->cinfo ? true : false; > + return vioch && !vioch->cinfo; > } > > static int virtio_chan_setup(struct scmi_chan_info *cinfo, struct device *dev,o Hi Sudeep, this seems obviously right, would you pick it up as it is on top of for-next/scmi when you have time ? Thanks, Cristian _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel