From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5595CC4338F for ; Mon, 9 Aug 2021 17:45:00 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1C7A660238 for ; Mon, 9 Aug 2021 17:45:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 1C7A660238 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Owner; bh=LI4qrRgdI3CbmZyXOpwKcyZGuBgiHrj/Edgry8oBXWA=; b=1E96xHDeLFlGxQ wpxF9g/jF8juj+sQ+FcBErI6z5VypE0h94FSgH4eG/zb+uff+2V72QhbQZ2A9IdVo+Qu64y04bwx+ meDLpoZUpPR6k7G56EYUhUVcujvQGI3bntm3EO5mbo3tLD652J1NcIKcUnXOkSBPVV1hkLCLCsOPi +4DGCKpqe9vyUvscr1i+nEFCC3R/drrz9iAyhgy7qRT3QJp7JCoq5gsG5HTxq8J5UySwTbVCkpRf8 E0y3wjdwi5tFybMACGKYWCtNGbKE8tQoBKUl+h9wC7LolEZWpR8mHAR2TJlQIdGmmR5gzBlIccS1v p1/rX9gszSBKtKgTcCKg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mD9IY-001aNx-Hm; Mon, 09 Aug 2021 17:42:50 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mD9IU-001aMy-H7; Mon, 09 Aug 2021 17:42:47 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id B4C3660F25; Mon, 9 Aug 2021 17:42:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1628530966; bh=FSFPv4kDztNyzO9/5NElHuOFEoE9ULfv2/yH+18aDsg=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=VNrWPeDdTAiBVFGd4tE8zpWxdKdmy4uZNfT1xG9Ey8dAH7dGzy2c31IkFE9wqhszF sPg1ZS08jMOcY++hBBMKJl46omOGv26RAgaUHhwtqzouT8be3ihPXpXc2BVOWceOzr VzLE4PwGgZYl82onsupTZbAB6RyTgcbYud/IfXyqJflAMDkDS4adDqd3HYEu+Rv/q7 eQ3acQ0wCZNInKHLW3sdL7fjtvpyFj8hL8jtrfliA/lKHv6Dp11tnIevVKPooqs2zB DHZKTfDCPZXc1Gn8wvspTzXBrEGJKKFGvCBL1CQQPy9mEV2B7pfeKfJjHPa9dQnSsO S/yuhaEMlYO+g== Date: Mon, 9 Aug 2021 12:42:44 -0500 From: Bjorn Helgaas To: Jeremy Linton Cc: linux-pci@vger.kernel.org, lorenzo.pieralisi@arm.com, nsaenz@kernel.org, bhelgaas@google.com, rjw@rjwysocki.net, lenb@kernel.org, robh@kernel.org, kw@linux.com, f.fainelli@gmail.com, bcm-kernel-feedback-list@broadcom.com, linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rpi-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/3] PCI: brcmstb: Add ACPI config space quirk Message-ID: <20210809174244.GA2167737@bjorn-Precision-5520> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <51a11c89-d49b-7367-a75c-13016a2ea5d9@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210809_104246_631376_8E6F8D4E X-CRM114-Status: GOOD ( 22.87 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Aug 06, 2021 at 09:55:27PM -0500, Jeremy Linton wrote: > Hi, > > On 8/6/21 5:21 PM, Bjorn Helgaas wrote: > > On Thu, Aug 05, 2021 at 04:11:59PM -0500, Jeremy Linton wrote: > > > The PFTF CM4 is an ACPI platform that is following the PCIe SMCCC > > > standard because its PCIe config space isn't ECAM compliant and is > > > split into two parts. One part for the root port registers and a > > > moveable window which points at a given device's 4K config space. > > > Thus it doesn't have a MCFG (and really any MCFG provided would be > > > nonsense anyway). As Linux doesn't support the PCIe SMCCC standard > > > we key off a Linux specific host bridge _DSD to add custom ECAM > > > ops and cfgres. The cfg op selects between those two regions, as > > > well as disallowing problematic accesses, particularly if the link > > > is down because there isn't an attached device. > > > > I'm not sure SMCCC is *really* relevant here. If it is, an expansion > > of the acronym and a link to a spec would be helpful. > > > > But AFAICT the only important thing here is that it doesn't have > > standard ECAM, and we're going to work around that. > > I will reword it a bit. > > > I don't see anything about _DSD in this series. > > That is the "linux,pci-quirk" in the next patch. The next patch doesn't mention _DSD either. Is it obfuscated by being inside fwnode_property_read_string()? If so, it's well and truly hidden; I gave up trying to connect that with ACPI. Bjorn _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel