From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25DF1C4338F for ; Tue, 10 Aug 2021 12:43:18 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DBCBD60EFF for ; Tue, 10 Aug 2021 12:43:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org DBCBD60EFF Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=S8fl7l0oD/rdEURtpXKQAxDLXMej8W2IL+ouBfAnbbM=; b=Qam/ZjGYOqlPGHzjEIc5asg5MK deAtJwVU6Ivn5t4Zk0Xr3c++IqWnrFQwpZMIcb/9OP/wzUSnbpPZco5uNXt3D54Cpm3jFrXIo6NcR FncXVc1uAxLq0rvfyzhOWHwWlvb+cw13oWojMMZXnGv121WYsctC/LTEOFxkOIMbVuCjg3K5Ll64M N4wFgW5QduwKjaE9xyWEwpLcYTHQYOyd/cw0IMawa20h8oApp6cXps1d1f/nUuCmRdZfFwTAOFN/W PdIGfjIi0loGw5snmWgp390l2A3Eb7aMs6yR+NEiV8J0IPzUrtHrJ71QKHs1IxTC9szNnNGTpBkBz +RUot2EA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mDR3M-003kQu-19; Tue, 10 Aug 2021 12:40:20 +0000 Received: from jabberwock.ucw.cz ([46.255.230.98]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mDR3H-003kOe-F9 for linux-arm-kernel@lists.infradead.org; Tue, 10 Aug 2021 12:40:17 +0000 Received: by jabberwock.ucw.cz (Postfix, from userid 1017) id B8C5A1C0B77; Tue, 10 Aug 2021 14:40:07 +0200 (CEST) Date: Tue, 10 Aug 2021 14:40:07 +0200 From: Pavel Machek To: Tony Lindgren , sashal@kernel.org Subject: Re: [PATCH] bus: ti-sysc: Fix gpt12 system timer issue with reserved status Message-ID: <20210810124006.GA25121@amd> References: <20210611060224.36769-1-tony@atomide.com> MIME-Version: 1.0 In-Reply-To: <20210611060224.36769-1-tony@atomide.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210810_054016_494387_47704D2F X-CRM114-Status: GOOD ( 17.95 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Nishanth Menon , Grygorii Strashko , Dave Gerlach , Keerthy , linux-kernel@vger.kernel.org, Faiz Abbas , Jarkko Nikula , Greg Kroah-Hartman , linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: multipart/mixed; boundary="===============3845281604068890751==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============3845281604068890751== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="bp/iNruPH9dso1Pn" Content-Disposition: inline --bp/iNruPH9dso1Pn Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi! I noticed the issue while reviewing stable kernels, as this is being backported. > Jarkko Nikula reported that Beagleboard > revision c2 stopped booting. Jarkko bisected the issue down to > commit 6cfcd5563b4f ("clocksource/drivers/timer-ti-dm: Fix suspend > and resume for am3 and am4"). >=20 > Let's fix the issue by tagging system timers as reserved rather than > ignoring them. And let's not probe any interconnect target module child > devices for reserved modules. +++ b/drivers/bus/ti-sysc.c > @@ -3093,8 +3095,8 @@ static int sysc_probe(struct platform_device *pdev) > return error; > =20 > error =3D sysc_check_active_timer(ddata); > - if (error) > - return error; > + if (error =3D=3D -EBUSY) > + ddata->reserved =3D true; > =20 > error =3D sysc_get_clocks(ddata); > if (error) What is going on here? First, we silently ignore errors other than EBUSY. Second, sysc_check_active_timer() can't return -EBUSY: it returns either 0 or -ENXIO. (I checked 5.10-stable, mainline and -next-20210806). Best regards, Pavel --=20 DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany --bp/iNruPH9dso1Pn Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAmESc6YACgkQMOfwapXb+vKZ5wCeLKBimzJgT4TZyjOoeCGslBeJ BH8AoKYD1/pIPyYP4B42sem9TRwrdWEx =XRbK -----END PGP SIGNATURE----- --bp/iNruPH9dso1Pn-- --===============3845281604068890751== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============3845281604068890751==--