From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AFD91C4338F for ; Wed, 11 Aug 2021 10:17:36 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 62E92601FD for ; Wed, 11 Aug 2021 10:17:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 62E92601FD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Vie/MutxPCduYJrnx3J6R1cFSPr7GYO4nzB+p1kTdfY=; b=BFZ7FMxMq3UD7G n97BmpQeMZFduMDDLjobLSfDrv7bSkIGqRln4pkDWEjxAtl5lXMcczdE/24357xZYk0giBm6BE+ab Py+7CRgOBkiYWkBZaB0dpyijSnrlDEguUxmrV+9xW2VzqouUYcHhMJLHuWGI/u8LUk7IcGr+Szt73 exYKZ2fjGVKRQBaBMmwEVXiXxrEN7vZjqsEHDl1/DiyJrhisKVJr4RnHCD/VWf7C6QREx479wsXjK BATNWhGK3Yvr5nAc5zEBP4dPGbA4z8upJAyd1o++vgBxDOaAECnq+jrRysiXQ5JCsU3S3bN2Sx86s I3DKQkvOWU7OwLCGphVg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mDlGK-006aMW-Di; Wed, 11 Aug 2021 10:15:05 +0000 Received: from mail-pj1-x1036.google.com ([2607:f8b0:4864:20::1036]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mDlG8-006aIK-Lg for linux-arm-kernel@lists.infradead.org; Wed, 11 Aug 2021 10:14:56 +0000 Received: by mail-pj1-x1036.google.com with SMTP id s22-20020a17090a1c16b0290177caeba067so8864144pjs.0 for ; Wed, 11 Aug 2021 03:14:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=Rg+nfqNpN4KVS6P5Kg2kgnadiI4aRZsAUMlE7w6kB2k=; b=ac4casP3kUB13OsUJQcv38FKO7pVIq50bZ6uPGU1NEdpQ0ASqnp8urXzheGfF4JgZJ F0GBVqBxpnRY7eoErIyp2IabG5QIpaejNKNbwc0aQqxzw6oZgMJeXCdM+On3gP7GcwAm Ze6ZM7NUk6+K3utV/jdB+12kqYzQTqBoRF8pt/wvWMKT0t0AejJqeovqCSNaOQMJbO1L dD5NFrhUjhU22SWOPidIBz2QfpP5F/XNnFPgeAwhtmB5nt6HWk+7H9MN4LVZKKuaHvyE KiuTQa4lU4FT+xPngVH2NJUbPObjZ/HoPrBwxQiQRHH+/uoJ61KSOscQQ3Qen6LcUrLD YtkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=Rg+nfqNpN4KVS6P5Kg2kgnadiI4aRZsAUMlE7w6kB2k=; b=B3rAO3BIW60dqslCiH8d5jQv8H2mA6IHqBqAjknmcC4OpBmsCG8XE9asJd+HvGB7be qnesKlNP0E81ulAJIE/391wBXwZszgJ3IUokvIoPXw/2g6J3EUPdOFhZDS9kb0d9hwq0 QKlW/CkryOms6FN5mEDF4fxVgQr+NoAD3M7YUh15CSsBT+AMUN/91z3mpHN/cB0xGi64 QxcP5gYoOzDVL27nCRvJd/VYi4098r6m4FpunN7/qNgUNCEuypCOMGJ5zqkuOn263Z7V O00TPnkacrD3WOZDLWkpghsTCuepoCOr5uJRG4upCgfHw3Anoe2uQwkQlmiHFmFjQFG/ apbA== X-Gm-Message-State: AOAM5313NX8TF2VlJHL/PDL9AMDvxc66bgcfL8p3DIw5Vbbor+Yjc/1v EaeBiUcYIFCavJOyyrV6g2njyA== X-Google-Smtp-Source: ABdhPJzXjMW9vKhvdq5O6Gt8ct98tc27N2TMRTz0kLhqKVJ5iHf/FGC7+T3yYcwqi1noPFO5FkhCyA== X-Received: by 2002:aa7:9f5b:0:b029:3be:2a1f:ca58 with SMTP id h27-20020aa79f5b0000b02903be2a1fca58mr27592438pfr.46.1628676892055; Wed, 11 Aug 2021 03:14:52 -0700 (PDT) Received: from localhost ([122.172.201.85]) by smtp.gmail.com with ESMTPSA id j25sm27085750pfe.198.2021.08.11.03.14.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Aug 2021 03:14:51 -0700 (PDT) Date: Wed, 11 Aug 2021 15:44:49 +0530 From: Viresh Kumar To: Quentin Perret Cc: Rafael Wysocki , Vincent Donnefort , lukasz.luba@arm.com, Andy Gross , Bjorn Andersson , Cristian Marussi , Fabio Estevam , Kevin Hilman , Matthias Brugger , NXP Linux Team , Pengutronix Kernel Team , Sascha Hauer , Shawn Guo , Sudeep Holla , linux-pm@vger.kernel.org, Vincent Guittot , linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-omap@vger.kernel.org Subject: Re: [PATCH 0/8] cpufreq: Auto-register with energy model Message-ID: <20210811101449.c2533ediwboeplqj@vireshk-i7> References: <20210811051859.ihjzhvrnuct2knvy@vireshk-i7> <20210811053406.jqwextgtnxhgsjd2@vireshk-i7> <20210811095311.e6wnma2ubkqdtuic@vireshk-i7> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20180716-391-311a52 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210811_031452_878508_22EB143D X-CRM114-Status: GOOD ( 13.50 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 11-08-21, 11:12, Quentin Perret wrote: > I think using the ready() callback can work just fine as long as we > document clearly it is important to register the EM from there and not > anywhere else. The dedicated em_register() callback makes that a bit > clearer and should avoid a bit of boilerplate in the driver, but it's > not a big deal really, so I'm happy either way ;) Yeah, I think just the same. It is better to have register_em as a separate call. I was just wondering if it is the right choice :) Anyway, I think ready() will get removed pretty soon, so register_em() will work well. I will redo this series and send it. -- viresh _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel