From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 454C4C4338F for ; Thu, 12 Aug 2021 09:02:48 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0A4E2603E7 for ; Thu, 12 Aug 2021 09:02:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 0A4E2603E7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=bdCkLTBWEHgRaxjP2uS42uOL57AhNbG7QAty7OC7ylA=; b=Mq5igz16r42ogF PBAEKoCNgqdE3Tq+C7nU9MjrRJsnpxJ6YaGxjXlZDOLNylIvBswOd5WUcw0jQcIZKNxpR9AogNSYc +EtB31LACfCWLjhKfP67x+viplcOF7l/3EnLyCrVBHyOXAPrsq+J1S93kWxSJT0qj3tm7ZRfihdgr xY14vukmBUYEen35mSwTNW50qUW3N2N5juYVKQ0IUmfPUduVEKkJ8buWmhLTL+4IGRjHT3w/9tuSR W5eMy9WZdGfyP9EIAml+YWrVHJ1cykaDk05F2CDfSDn72bovUc/F4VIbKtlwucB+mgazqSpTaTg0a lqydcfVc0oXbt+R9cd7Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mE6Z5-009F19-7H; Thu, 12 Aug 2021 08:59:51 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mE6Yz-009Ezk-6R for linux-arm-kernel@lists.infradead.org; Thu, 12 Aug 2021 08:59:46 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 9BD9160C3F; Thu, 12 Aug 2021 08:59:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1628758784; bh=srKEXFb7B5Re+3iiWpHXQAcqGzm51k++58eDNACsfIU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=iCW5MwZkpLmx7akle39s9ZWQqz9phsrE8gL8DMrSjyYtmlkEzgfFbv2QE0G7KFEWI HEMFqcJhUy8HiXsDHb8G+MiEHwAnS4kBpkRxi+WbL6PFIl4V4qfrJbYudoeeSASvE9 gW+BqHIlUl3/+oJ6jWOeuAQg/0+Ww8EjnEWr+uQFp7MXIwZfbzbcks4O8ADmxN3ny3 DIZLEyXAPnyuJGSXJprvCuh8mDFkFDj/wSQhcTC1yw4SPMk8wmHd1Bavm6TI2z0A02 efS8zw2r4MEp3lRYwMIaRz7k5rufqLygdKrafkG+sf9GMeSyXwrkkni2kF3GGJVcGT 6nn8dL051zK6g== Date: Thu, 12 Aug 2021 09:59:39 +0100 From: Will Deacon To: Fuad Tabba Cc: kvmarm@lists.cs.columbia.edu, maz@kernel.org, james.morse@arm.com, alexandru.elisei@arm.com, suzuki.poulose@arm.com, mark.rutland@arm.com, christoffer.dall@arm.com, pbonzini@redhat.com, drjones@redhat.com, qperret@google.com, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kernel-team@android.com Subject: Re: [PATCH v3 08/15] KVM: arm64: Add feature register flag definitions Message-ID: <20210812085939.GF5912@willie-the-truck> References: <20210719160346.609914-1-tabba@google.com> <20210719160346.609914-9-tabba@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210719160346.609914-9-tabba@google.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210812_015945_304649_8B185FC0 X-CRM114-Status: GOOD ( 15.73 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jul 19, 2021 at 05:03:39PM +0100, Fuad Tabba wrote: > Add feature register flag definitions to clarify which features > might be supported. > > Consolidate the various ID_AA64PFR0_ELx flags for all ELs. > > No functional change intended. > > Signed-off-by: Fuad Tabba > --- > arch/arm64/include/asm/cpufeature.h | 4 ++-- > arch/arm64/include/asm/sysreg.h | 12 ++++++++---- > arch/arm64/kernel/cpufeature.c | 8 ++++---- > 3 files changed, 14 insertions(+), 10 deletions(-) > > diff --git a/arch/arm64/include/asm/cpufeature.h b/arch/arm64/include/asm/cpufeature.h > index 9bb9d11750d7..b7d9bb17908d 100644 > --- a/arch/arm64/include/asm/cpufeature.h > +++ b/arch/arm64/include/asm/cpufeature.h > @@ -602,14 +602,14 @@ static inline bool id_aa64pfr0_32bit_el1(u64 pfr0) > { > u32 val = cpuid_feature_extract_unsigned_field(pfr0, ID_AA64PFR0_EL1_SHIFT); > > - return val == ID_AA64PFR0_EL1_32BIT_64BIT; > + return val == ID_AA64PFR0_ELx_32BIT_64BIT; > } > > static inline bool id_aa64pfr0_32bit_el0(u64 pfr0) > { > u32 val = cpuid_feature_extract_unsigned_field(pfr0, ID_AA64PFR0_EL0_SHIFT); > > - return val == ID_AA64PFR0_EL0_32BIT_64BIT; > + return val == ID_AA64PFR0_ELx_32BIT_64BIT; > } > > static inline bool id_aa64pfr0_sve(u64 pfr0) > diff --git a/arch/arm64/include/asm/sysreg.h b/arch/arm64/include/asm/sysreg.h > index 326f49e7bd42..0b773037251c 100644 > --- a/arch/arm64/include/asm/sysreg.h > +++ b/arch/arm64/include/asm/sysreg.h > @@ -784,14 +784,13 @@ > #define ID_AA64PFR0_AMU 0x1 > #define ID_AA64PFR0_SVE 0x1 > #define ID_AA64PFR0_RAS_V1 0x1 > +#define ID_AA64PFR0_RAS_ANY 0xf This doesn't correspond to an architectural definition afaict: the manual says that any values other than 0, 1 or 2 are "reserved" so we should avoid defining our own definitions here. Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel