From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56A17C4338F for ; Fri, 13 Aug 2021 03:42:49 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1999C60295 for ; Fri, 13 Aug 2021 03:42:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 1999C60295 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ehclJvZlVceQ+qCQRY9f2DVlJYzE2IA/+5CVpGPnL1g=; b=mA7IB9gcT3IbEn aTaZj8hoDE+OAD/qaeFqZkMVZKMvwxzcAsEnzBvAWVdluG7lhrblGthsekLEZZcshgFb8LAQ3dVy/ 2SZvM52CSgE2K/Boe0Ce6NqG9gtCwP5dE4khYlpjQlaMfO3yrt+kyOH3P+u0LIqP+CSfR3DZ5hPY3 qkHn3PJTn70DG29GcHyMDzI4fDchUfLWYk/nXIGMxKNS0avuUKyP4jPYhSKqfBuVavE00TnPRAWDA /D0yQa2FwdpyPjSO2Q8d4Tk4IVI0BipsfwGXQIynkHwbeSSnDuWDHEGIDoLV0rYR3NuALlmZiTbOR P0CxMzEPj77WTAn8pIMg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mEO3f-00BfYY-5z; Fri, 13 Aug 2021 03:40:35 +0000 Received: from mail-pj1-x102d.google.com ([2607:f8b0:4864:20::102d]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mEO3U-00BfY5-UM for linux-arm-kernel@lists.infradead.org; Fri, 13 Aug 2021 03:40:26 +0000 Received: by mail-pj1-x102d.google.com with SMTP id om1-20020a17090b3a8100b0017941c44ce4so418482pjb.3 for ; Thu, 12 Aug 2021 20:40:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=ORlrD9sl2aYo7jcRja/hxhONlCSeq5JNCCwjrBnwxHg=; b=ls+y9PABiM7r2XhDF6NpqmapOhuDd3WDTmTnpnP3+eOcE/KB0PBGnOMGCTwiWmCxZU zRtrd/D/KjHERYC7MTD8uRVfXzG2Z3HMizrjPVThbvc0Jn4mv8A/w1u2/0UmT+VeoOy4 3QbaSEy+9SrswsB+SIEssE3V2Wai5hML/bWmUvsTYU/Exi+Oz3uilkjwqQ/pvR+VGy+L xEJTN4AxgeY/0UlnLApejq8ai34l4SANvij0fRnaR5wI4+AygGI1FTzF80JVv7ieaASI zWnHrO72pTJmD0O/WVdun7wGDUdBEF/Kctn2zoaQFwPrsJQ5o/mXLKr6pOmXC/e9NwQF kXjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=ORlrD9sl2aYo7jcRja/hxhONlCSeq5JNCCwjrBnwxHg=; b=l89CDEPUaswDHB0Fd0Hbq2ZpRuXvOKG+YXEqNT8pqaDa9g0PYFgYVLWZ3o5jbya97V yOeV2SO6osR89FrBJzvvh4njPmT+HFyJbxOE1GYbs0I/TdG5U7kFwQN1RmC2HGvigZm5 gQsMKMK2WWUuzP+aDgK5ftsTH+u14D1REHbdd6zn999F9+cXLIsnIM+DyOfe2/9NWa5d F1PUr3KvoaWfZbClqLSYk/7pD5f+MC6FBFtL9pJ5HAvysJEe6H7rMgcHkTolvck1sz0m 3FJH8ymtQkkPLi89cd+cLSF3BWew5yc1gDZTsVoM9SHBU/HD9HYj1emTZnQ4MtE76Y0i yQ3g== X-Gm-Message-State: AOAM5326tr+mtGnxF1qiZKzwghrJplZP1aFwSyTbmPBSjU1bf1puBJuB p3ndP5SAQrtatWvH5jBbhtM= X-Google-Smtp-Source: ABdhPJzhTgI45W86irveIUKBOUgK67+9nGpu3ltrKHOvKGT9EQFFV8uNZpi8CRMREa+QzJyTRGOSyg== X-Received: by 2002:a17:902:8f90:b029:12d:1b48:efd8 with SMTP id z16-20020a1709028f90b029012d1b48efd8mr352319plo.23.1628826023485; Thu, 12 Aug 2021 20:40:23 -0700 (PDT) Received: from taoren-ubuntu-R90MNF91 (c-73-92-48-112.hsd1.ca.comcast.net. [73.92.48.112]) by smtp.gmail.com with ESMTPSA id z24sm236977pjq.43.2021.08.12.20.40.22 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 12 Aug 2021 20:40:23 -0700 (PDT) Date: Thu, 12 Aug 2021 20:40:17 -0700 From: Tao Ren To: Joel Stanley Cc: Rob Herring , Andrew Jeffery , devicetree , Linux ARM , linux-aspeed , Linux Kernel Mailing List , OpenBMC Maillist , Tao Ren Subject: Re: [PATCH v2 4/6] ARM: dts: aspeed: Add Facebook Cloudripper (AST2600) BMC Message-ID: <20210813034016.GA21895@taoren-ubuntu-R90MNF91> References: <20210805222818.8391-1-rentao.bupt@gmail.com> <20210805222818.8391-5-rentao.bupt@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210812_204025_028480_3C361A72 X-CRM114-Status: GOOD ( 16.96 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Aug 13, 2021 at 01:29:17AM +0000, Joel Stanley wrote: > On Thu, 5 Aug 2021 at 22:28, wrote: > > +&mdio1 { > > + status = "okay"; > > You're enabling this but it looks like it's unused? Thanks Joel for the careful review. The MDIO controller is not paired with BMC MAC; instead, it's connected to the MDC/MDIO interface of the on-board switch (whose ports are connected to BMC, Host and front panel management port). In other word, the MDIO controller is used, but we do need some user space scripts to control the controller. What's your suggestion? For example, should I add some comments to explain the purpose? Cheers, Tao > > > +}; > > + > > +&mdio3 { > > + status = "okay"; > > + > > + ethphy1: ethernet-phy@13 { > > + compatible = "ethernet-phy-ieee802.3-c22"; > > + reg = <0x0d>; > > + }; > > +}; > > + > > +&mac3 { > > + status = "okay"; > > + phy-mode = "rgmii"; > > + phy-handle = <ðphy1>; > > + pinctrl-names = "default"; > > + pinctrl-0 = <&pinctrl_rgmii4_default>; > > +}; _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel