From: Shawn Guo <shawnguo@kernel.org>
To: Marek Vasut <marex@denx.de>
Cc: Pascal Zimmermann <pzimmermann@dh-electronics.com>,
linux-arm-kernel@lists.infradead.org,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@denx.de>,
NXP Linux Team <linux-imx@nxp.com>,
kernel@dh-electronics.com,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Arnd Bergmann <arnd@arndb.de>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Subject: Re: [PATCH] ARM: imx_v6_v7_defconfig: enable driver of the LTC3676 PMIC
Date: Sat, 14 Aug 2021 19:24:25 +0800 [thread overview]
Message-ID: <20210814112424.GA9470@dragon> (raw)
In-Reply-To: <2a3e56b8-7fd7-44ec-4090-7fe2b5d7863c@denx.de>
On Sat, Aug 14, 2021 at 09:45:03AM +0200, Marek Vasut wrote:
> On 8/14/21 7:40 AM, Shawn Guo wrote:
> > On Tue, Aug 10, 2021 at 07:36:24AM +0200, Marek Vasut wrote:
> > > On 8/5/21 3:50 PM, Pascal Zimmermann wrote:
> > > > The LTC3676 is a PMIC which is used on some i.MX6 based boards (like the
> > > > DHCOM i.MX6 Quad SoM), it was first used on the GW Ventana board, enable
> > > > LTC3676 driver in imx_v6_v7_defconfig.
> > > >
> > > > Fixes: e3946fe805053 ("ARM: dts: add Gateworks Ventana support")
> >
> > I don't think the Fixes tag is appropriate here. Dropped it and applied
> > patch.
>
> Can you please elaborate why do you think the Fixes tag is not appropriate ?
>
> Neither system can work properly without the PMIC driver, so I believe the
> Fixes tag is correct and this should be backported to older LTS kernel
> releases.
It's enabling a feature (driver) rather than fixing a bug or regression.
If you want to enable it for LTS kernel, go ahead to back port it.
Do not abuse the Fixes tag.
Shawn
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-08-14 11:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-05 13:50 [PATCH] ARM: imx_v6_v7_defconfig: enable driver of the LTC3676 PMIC Pascal Zimmermann
2021-08-10 5:36 ` Marek Vasut
2021-08-14 5:40 ` Shawn Guo
2021-08-14 7:45 ` Marek Vasut
2021-08-14 11:24 ` Shawn Guo [this message]
2021-08-14 14:31 ` Marek Vasut
2021-08-31 17:38 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210814112424.GA9470@dragon \
--to=shawnguo@kernel.org \
--cc=arnd@arndb.de \
--cc=festevam@denx.de \
--cc=gregkh@linuxfoundation.org \
--cc=kernel@dh-electronics.com \
--cc=kernel@pengutronix.de \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=marex@denx.de \
--cc=pzimmermann@dh-electronics.com \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).