From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0EABC4338F for ; Sat, 14 Aug 2021 23:42:49 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 928F560F4B for ; Sat, 14 Aug 2021 23:42:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 928F560F4B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=DuYL6ofbiNybKg4JkRUX9zyvccOpe+O0Xbh2FITkO8s=; b=b3Kt0Gj9RKrcY8 0znl2dU2CfLMu0YfuREplAQhsdTV5W628lj2HNo/XSvgEa4o6xVT83B7Csmr7c8s8TiyFHkqHrd8W If+a3MzlOYolnBboqU4far1zOgzW/rnxjh0CMe6NxaqvwQM6jrjrLsL10Qq7ORh6JPSGFFPjdhbWA 3u/b3+j3x1rj7vLsWrFisKihY7ayJDSc5O8p+JAxiykIm1WVyiyjhBdIMrRj0HtjtPFBh+JpvezkF Vv+QtQXk1xgnASCa7tUJdqNX5rL+qJlVUnSpcfAOR16u8EtE2JvscBf+99BdCWB+AKyl7ScWPBNyb oiSDU/J86Ymyc0Te7iJg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mF3H3-00Ehpl-CM; Sat, 14 Aug 2021 23:41:09 +0000 Received: from mail-oi1-x22b.google.com ([2607:f8b0:4864:20::22b]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mF3Gz-00EhpH-Gu for linux-arm-kernel@lists.infradead.org; Sat, 14 Aug 2021 23:41:06 +0000 Received: by mail-oi1-x22b.google.com with SMTP id r5so21502530oiw.7 for ; Sat, 14 Aug 2021 16:41:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Tfuq+be3Xa5MVH6I90u/6qpYq26wTOLdHeD5oxhu6Ks=; b=TrdCHs1Ejepb0mKQvg/IhZlrldX9HB8TvKWpXPb1hrFaQH98zhoMUYZoGz8CVSpLmu 4pKn8m4sQ+opZd54fL+KwUwCuNnCDr1oQ8zfbtN+yFtgdCN7mep5F30Ru+Ie38mWFvBs irQubPYANI5/Q3q49q+ZePV/e48mAmCRGD517kYy1fLol6pJWjZYOX1nN+FV05v/39vW JDX6IqsQJC1HZ3qs+A7i5/ZOGowyGcH490SrPvyLGgt8J0B386Alckw8DRamnSyJkRVD FfycE1hxRogw/PjmifHsowUj+PFsfMVYPPk8AaPrM9cr+kuqW+Z0Ug6QjroXog409xes jxzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to; bh=Tfuq+be3Xa5MVH6I90u/6qpYq26wTOLdHeD5oxhu6Ks=; b=QtwIXRlqHhGN1XmWFRc0ZzEiFL7kUmlo9C3hIi+vWmElqVa0P5nUVa07wwKDsOUuCg 7QuZsEA+c52F4eQwMa4rA9JUMbhxmYHS66DJ5RCAGahPBRGeI6unWNxvOF/hdVP6SMDX O+zjD02XIGM/vYEr9Al8UVhWMYNANIkvXQB3lpQsZhSyJOTvS7GdoPMikbaQS2gnTYpN jDHigwbya7WHXVe5mU6O/ijqASL0j8nJZwHaZvodCyzWM69uKPCDpODj0I30n30tsOzr kjAmVVdDeZ0K4y2hapXJRrRWSSdrzDTidVdhMa8V5CMBq/N/bywx+qU+9AK9XdgBowZ9 2xcw== X-Gm-Message-State: AOAM5338p65TfV6eehm/CyfiI8n8PHn5/MrxtyhuuEI6B/FpBXza5iul GvWEt/7Z1XpueC8cWVtH52zXMGeuhbQ= X-Google-Smtp-Source: ABdhPJwMVUqia/DAvlgtxwKwT9hpbfm1RJ+hAlvcLcmyptIrOVhu1G1ehGBSDx83NVmlXlq9EmT9jQ== X-Received: by 2002:a05:6808:2ca:: with SMTP id a10mr447223oid.44.1628984464722; Sat, 14 Aug 2021 16:41:04 -0700 (PDT) Received: from server.roeck-us.net ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id y12sm1213884oiv.55.2021.08.14.16.41.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 14 Aug 2021 16:41:04 -0700 (PDT) Date: Sat, 14 Aug 2021 16:41:03 -0700 From: Guenter Roeck To: Valentin Schneider Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Marc Zyngier Subject: Re: [PATCH] irqchip/gic: Convert to handle_strict_flow_irq() Message-ID: <20210814234103.GA828447@roeck-us.net> References: <20210814194737.GA3951530@roeck-us.net> <87sfzb7jeo.mognet@arm.com> <87pmuf7j5a.mognet@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <87pmuf7j5a.mognet@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210814_164105_611732_16D2A391 X-CRM114-Status: GOOD ( 12.49 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, Aug 14, 2021 at 11:31:45PM +0100, Valentin Schneider wrote: > On 14/08/21 23:26, Valentin Schneider wrote: > > > > Now, the above makes me feel like this is the start of a wild goose chase > > for irqchips in a similar situation. > > The ones in arch/arm are easy enough to catch (I see gpc, omap-wakeupgen > and some exynos suspend thing), less so for the ones in drivers/irqchip... Try: make coccicheck COCCI=irq_chip.cocci MODE=report M=. with the script below. I am sure the script could be augmented if there is some secondary condition that makes irq_ack mandatory. Guenter --- irq_chip.cocci: virtual report @c@ identifier chip; position p; @@ struct irq_chip chip@p = { ... }; @i@ identifier c.chip; identifier f; @@ struct irq_chip chip = { .irq_ack = f, }; @script:python depends on c && !i && report@ p << c.p; @@ print "Found %s:%s" % (p[0].file, p[0].line) _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel