From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 915E1C432BE for ; Wed, 18 Aug 2021 10:02:48 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5C0F26109E for ; Wed, 18 Aug 2021 10:02:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 5C0F26109E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=cerno.tech Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=3bZs7pVboVYT0+uLeSH5PeMPjEO5f9OT2Dt505mxzLU=; b=i0YctB+gm5FY7iYbZBKzJmIoZB AMh74FMnueyohiBrOQBE1xrpeQi1GzlblWT1oVIvcOK9zH7NPCmyO0onIp7cJEepsHkrPrTGIw19e SNIgA3RIISN2Zzn/zHM4l3nGB6/zKfuBPbm/WLdh590eGq7mOMhKkfO2ECyszyTy7AkwwdbjBnjsx hTXsViSJAPZfZoU6WLXqOM8YHZOotnc3pxG7Da6IPh7tV3QN7pZvjnmdaMK/NJWwyaJTGgFFs9/RD m2HzrYdKCrs1gp1G2Xciketqzvm8Bppg1Q6uyXlWj8x6WjE4DF16PEYk/cJDiZxmC7gorFGpsDPI5 XbqHGQGg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mGINA-0051Ui-Nc; Wed, 18 Aug 2021 10:00:36 +0000 Received: from out1-smtp.messagingengine.com ([66.111.4.25]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mGIN3-0051TG-SM for linux-arm-kernel@lists.infradead.org; Wed, 18 Aug 2021 10:00:34 +0000 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 833265C0198; Wed, 18 Aug 2021 06:00:25 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Wed, 18 Aug 2021 06:00:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm3; bh=kZLyEeKCZry5SsJrdGDyx9YCfod 3H+Q8kZ+LUcg5WBM=; b=i7vLeEjKSGKlHFYzq5IsgVZcyuqpXY3rkMgGmvppWBO Gc3McrpOVmnh7GPT0JCvBmLWauDx/atrJMyWjDRGii/OIp6KksZ1lbNYqktmqTM0 5z12NJeOiKU9cOE8R8EsHLAc8juXgzNZD9UllGR2ArGaUnZTiA6uP2okJMfjUyC7 wzvkHLc4clv5Q+iNuiEDlysslCwJQ8IIiU/akGGkE56djaWL0JIRwCaLL+JyEGdP +6e3e/JYRTrD1DAknuAlzCtm5dmypZB3AYp9ylqVxAQOVy1AF/vxb/n4hj+RO1s/ zBg2tKcT0m8jRhqttQs4b78l78A0rfCL80h5D5vteEw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=kZLyEe KCZry5SsJrdGDyx9YCfod3H+Q8kZ+LUcg5WBM=; b=SdSU0e1EFbHncFfDte8G+P lMAx2ZD7omTeVAHrCo0RvQWQdRU3hXncDt16q6Mm2NT1gHOloiHdutXw2er3MSQ1 rT5qz1/SuaMNaPPXuIO8gu9TAAcwQA8Rb/A/wZQeoOOktuaufQLz7VdVmjnISbxn 3qfLt8RDV8faWRAk3kvV5bzp/+bLcWCjkqeqX01iBhlqk//WFKwt4Y+gO72nSIwc lo4AeNBOjocAd/nSc/HSXeEtO8Pq6AmtdbJ0XXgMJufCimn+ol5NbuW6WwiRWhB2 EdJBMv9Ruua8QOvFamBWBCIBf4EG8rt/a7tY/Rwc96Fj9f+VUUGtWhIQQMDogH6g == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrleehgddvfecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvuffkfhggtggujgesghdtreertddtvdenucfhrhhomhepofgrgihimhgv ucftihhprghrugcuoehmrgigihhmvgestggvrhhnohdrthgvtghhqeenucggtffrrghtth gvrhhnpeffteetveeijeetuefhffegkeetgffhieelheehtdduudethffhjedtvddtudel vdenucffohhmrghinhepuggvvhhitggvthhrvggvrdhorhhgnecuvehluhhsthgvrhfuih iivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepmhgrgihimhgvsegtvghrnhhordht vggthh X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 18 Aug 2021 06:00:23 -0400 (EDT) Date: Wed, 18 Aug 2021 12:00:21 +0200 From: Maxime Ripard To: Rob Herring Cc: Grant Likely , Chen-Yu Tsai , Jernej Skrabec , devicetree@vger.kernel.org, Frank Rowand , linux-arm-kernel , linux-sunxi@googlegroups.com, Mailing List Subject: Re: [PATCH 05/54] dt-bindings: Convert Reserved Memory binding to a schema Message-ID: <20210818100021.yzzcuadkowy4tfv4@gilmour> References: <20210721140424.725744-1-maxime@cerno.tech> <20210721140424.725744-6-maxime@cerno.tech> MIME-Version: 1.0 In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210818_030030_263755_91657AAD X-CRM114-Status: GOOD ( 28.98 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============0168359717171019216==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============0168359717171019216== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="n7nlrbexrimtktxt" Content-Disposition: inline --n7nlrbexrimtktxt Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Rob, On Wed, Jul 21, 2021 at 08:30:43AM -0600, Rob Herring wrote: > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/reserved-memory/reserved-memory.yam= l# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: /reserved-memory Node > > + > > +maintainers: > > + - Devicetree Specification Mailing List > > + > > +description: > > > + Reserved memory is specified as a node under the /reserved-memory no= de. The > > + operating system shall exclude reserved memory from normal usage one= can > > + create child nodes describing particular reserved (excluded from nor= mal use) > > + memory regions. Such memory regions are usually designed for the spe= cial > > + usage by various device drivers. > > + > > +properties: > > + $nodename: > > + const: reserved-memory > > + > > + "#address-cells": true > > + "#size-cells": true > > + ranges: true > > + > > +patternProperties: > > + "^(?!(ranges))[a-z,-]*(@[0-9]+)?$": >=20 > Note that you could drop this and put under 'additionalProperties'. > You would lose some node name checking, but there's really little > standard on these nodes. I didn't realise it could be used that way too, I'll change it. > > + type: object > > + > > + description: > > > + Each child of the reserved-memory node specifies one or more reg= ions of > > + reserved memory. Each child node may either use a 'reg' property= to > > + specify a specific range of reserved memory, or a 'size' propert= y with > > + optional constraints to request a dynamically allocated block of= memory. > > + > > + Following the generic-names recommended practice, node names sho= uld > > + reflect the purpose of the node (ie. "framebuffer" or "dma-pool"= ). Unit > > + address (@
) should be appended to the name if the node = is a > > + static allocation. > > + > > + properties: > > + reg: true > > + > > + size: > > + $ref: /schemas/types.yaml#/definitions/uint32-array > > + description: > > > + Length based on parent's \#size-cells. Size in bytes of memo= ry to > > + reserve. > > + > > + alignment: > > + $ref: /schemas/types.yaml#/definitions/uint32-array > > + description: > > > + Length based on parent's \#size-cells. Address boundary for > > + alignment of allocation. > > + > > + alloc-ranges: > > + $ref: /schemas/types.yaml#/definitions/uint32-array > > + description: > > > + Address and Length pairs. Specifies regions of memory that a= re > > + acceptable to allocate from. > > + > > + compatible: > > + oneOf: > > + - const: shared-dma-pool > > + description: > > > + This indicates a region of memory meant to be used as a = shared > > + pool of DMA buffers for a set of devices. It can be used= by an > > + operating system to instantiate the necessary pool manag= ement > > + subsystem if necessary. > > + > > + # Vendor-specific compatibles in the form ,[= -] > > + - const: mediatek,trustzone-bootinfo >=20 > I think these should be separate schema files. At least, we're going > to need to support separate files because I don't think we want ones > adding custom properties here. This would fail unless we add every > compatible here. We could also be a bit more exact as to which > properties below apply (e.g. linux,.*-default is only valid for > shared-dma-pool). I'm not entirely sure how we can just ignore the vendor compatibles without raising a warning. Do you have any suggestion? Thanks! Maxime --n7nlrbexrimtktxt Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCYRzaNQAKCRDj7w1vZxhR xXoEAP0Wb+sDdQFVpE4TOpIzWL60pus62BaBAkK76+r+dEqmagD/ekGoQDd8MZv9 FjRdZeu13zCexoQq5O+jibOPiKbmtwQ= =l7it -----END PGP SIGNATURE----- --n7nlrbexrimtktxt-- --===============0168359717171019216== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============0168359717171019216==--