From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BFDD2C4338F for ; Fri, 20 Aug 2021 19:12:56 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 84EC860F91 for ; Fri, 20 Aug 2021 19:12:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 84EC860F91 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Owner; bh=JS2L5JkBBQSD9LcaVzxdR6UxnRBgOQgs9ppR8Qiy3lg=; b=ffRDDqj1DGeE6x pfzmgD+9HwGV1sJ6OKVNNhahQHxyOkYCZnNHFawzPQuFU/3gwktP8HamKtg67dkzEV9k6sSAjIoL1 BVmRdX0DUYzKQGFl0ZxbskiubuapDanERuYmOLnkOS5mwqN2XyAGsWNTuzB04+UolJcEkeR0I6q8v P9+JJ6Rj0BgE5k2PGSGEy1ZMD8OxHoZGYjZ1SbcKjx2VJSuzB7P1817RsgLKwehFqRuQoaSxLTeAe H+bxV2c7syBE3gcskw8sBUKPdQYsWYnBQWXF6pY6Rp3uKbFkxwHOCAgJegoBmviNhwPHJrHadBats tUejbszHsDuF2Bgd46ug==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mH9vE-00ByYk-9w; Fri, 20 Aug 2021 19:11:20 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mH9vA-00ByXa-2Z; Fri, 20 Aug 2021 19:11:17 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 69DF861057; Fri, 20 Aug 2021 19:11:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1629486675; bh=+lnS2uhPrhRCUE+VxVlLNxa0MLY4D5p562mgZIoQvcE=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=mLTremNUBXufGJG4IAdVgkGtRJzOJWqQOjFAKNLLJY9ReTw+n69H1Sf+N5cL/oQ/g NlqH0KiJyN3qT0mJciCKIlPU7Ef3tnt0mRjB4eWCM3iZUZeBUdeHoDRIkkQix7EnUS YHTuK973kuq4mWcp+xrBF7gbHs//d0+elKMbyyBxPE/wYFwVcDai5tXj5e5CNxv/MM CiRb/25Fnzub9oNHuIduUNUjr3dcc5gBAwZyza9v6llacIpATie/xQeXEUoDFQR5Q1 skgSLlTr+RaY6duKPKY6kkYoivSeHURTgBwCnqCnvQCZnOUY9G8G4s8vbV3/QfYQau wgt/7KnqgnwLg== Date: Fri, 20 Aug 2021 14:11:14 -0500 From: Bjorn Helgaas To: Jeremy Linton Cc: linux-pci@vger.kernel.org, lorenzo.pieralisi@arm.com, nsaenz@kernel.org, bhelgaas@google.com, rjw@rjwysocki.net, lenb@kernel.org, robh@kernel.org, kw@linux.com, f.fainelli@gmail.com, sdonthineni@nvidia.com, stefan.wahren@i2se.com, bcm-kernel-feedback-list@broadcom.com, linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rpi-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 0/4] CM4 ACPI PCIe quirk Message-ID: <20210820191114.GA3341026@bjorn-Precision-5520> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210819215655.84866-1-jeremy.linton@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210820_121116_195880_F4638733 X-CRM114-Status: GOOD ( 12.61 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Aug 19, 2021 at 04:56:51PM -0500, Jeremy Linton wrote: > The PFTF CM4 is an ACPI platform that is following the Arm PCIe SMC > (DEN0115) standard because its PCIe config space isn't ECAM compliant > since it is split into two parts. One part describes the root port > registers, and another contains a moveable window pointing at a given > device's 4K config space. Thus it doesn't have an MCFG table. As > Linux doesn't support the PCI/SMC, a host bridge specific _DSD is > added and associated with custom ECAM ops and cfgres. The custom cfg > op selects between those two regions, as well as disallowing > problematic accesses. > > V1->V2: > Only move register definitions to new .h file, add > include guards. > Change quirk namespace identifier. > Update Maintainers file. > A number of whitespace, grammar, etc fixes. > > > Jeremy Linton (4): > PCI: brcmstb: Break register definitions into separate header > PCI: brcmstb: Add ACPI config space quirk > PCI/ACPI: Add Broadcom bcm2711 MCFG quirk > MAINTAINERS: Widen brcmstb PCIe file scope > > MAINTAINERS | 2 +- > drivers/acpi/pci_mcfg.c | 13 ++ > drivers/pci/controller/Makefile | 1 + > drivers/pci/controller/pcie-brcmstb-acpi.c | 74 ++++++++++ > drivers/pci/controller/pcie-brcmstb.c | 150 +------------------- > drivers/pci/controller/pcie-brcmstb.h | 155 +++++++++++++++++++++ > include/linux/pci-ecam.h | 1 + > 7 files changed, 247 insertions(+), 149 deletions(-) > create mode 100644 drivers/pci/controller/pcie-brcmstb-acpi.c > create mode 100644 drivers/pci/controller/pcie-brcmstb.h I'm fine with all of these, given the minor comments I made. Lorenzo, if you want to pick this up after Jeremy updates it: Acked-by: Bjorn Helgaas _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel