From: Mark Rutland <mark.rutland@arm.com>
To: jing yangyang <cgel.zte@gmail.com>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Cc: Sudeep Holla <sudeep.holla@arm.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
jing yangyang <jing.yangyang@zte.com.cn>,
Zeal Robot <zealci@zte.com.cn>
Subject: Re: [PATCH linux-next] firmware/psci: fix application of sizeof to pointer
Date: Tue, 24 Aug 2021 11:58:24 +0100 [thread overview]
Message-ID: <20210824105824.GC96738@C02TD0UTHF1T.local> (raw)
In-Reply-To: <61d3cc7e5cd4a819381fcb22e1853d6f48a0c927.1629212319.git.jing.yangyang@zte.com.cn>
On Thu, Aug 19, 2021 at 07:30:16PM -0700, jing yangyang wrote:
> sizeof when applied to a pointer typed expression gives the size of
> the pointer.
>
> ./drivers/firmware/psci/psci_checker.c:158:41-47: ERROR application of sizeof to pointer
>
> This issue was detected with the help of Coccinelle.
>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: jing yangyang <jing.yangyang@zte.com.cn>
From looking at the git history, we should add:
Fixes: 7401056de5f8d4ea ("drivers/firmware: psci_checker: stash and use topology_core_cpumask for hotplug tests)"
With that:
Acked-by: Mark Rutland <mark.rutland@arm.com>
Lorenzo, how do we normally direct these patches?
Thanks,
Mark.
> ---
> drivers/firmware/psci/psci_checker.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/firmware/psci/psci_checker.c b/drivers/firmware/psci/psci_checker.c
> index 9a369a2..116eb46 100644
> --- a/drivers/firmware/psci/psci_checker.c
> +++ b/drivers/firmware/psci/psci_checker.c
> @@ -155,7 +155,7 @@ static int alloc_init_cpu_groups(cpumask_var_t **pcpu_groups)
> if (!alloc_cpumask_var(&tmp, GFP_KERNEL))
> return -ENOMEM;
>
> - cpu_groups = kcalloc(nb_available_cpus, sizeof(cpu_groups),
> + cpu_groups = kcalloc(nb_available_cpus, sizeof(*cpu_groups),
> GFP_KERNEL);
> if (!cpu_groups) {
> free_cpumask_var(tmp);
> --
> 1.8.3.1
>
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-08-24 11:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-20 2:30 [PATCH linux-next] firmware/psci: fix application of sizeof to pointer jing yangyang
2021-08-24 10:58 ` Mark Rutland [this message]
2021-10-16 18:10 ` Gustavo A. R. Silva
2021-10-18 13:54 ` Sudeep Holla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210824105824.GC96738@C02TD0UTHF1T.local \
--to=mark.rutland@arm.com \
--cc=cgel.zte@gmail.com \
--cc=jing.yangyang@zte.com.cn \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=sudeep.holla@arm.com \
--cc=zealci@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).