From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 53FDCC4338F for ; Tue, 24 Aug 2021 11:06:17 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1EE296101C for ; Tue, 24 Aug 2021 11:06:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 1EE296101C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=loFa7Vcij7mmBitpfSwnhMiz2pW74lFXbE1mgCEO7+8=; b=s/FpEYzMoJvvSf UPuGrcGU068xZuZTZeP6WmZa5m2KJsJxkjnBGzxfZicoMsRe9JKb1t0MQs+7Fu1LRNHqbQDMfybEi HVddXUB9viyFup7VQ52dqhABeaw6FgQ5fhKzfxUlmNtegSVzglQwgaaBRq8Q8Bm8q4f6Af3kXACii zAJhWy82fauJ50ukvkd6gpykI53mg0rn2fExDO5O3S9xPa2TQuIsMMm8E9uMu5y68Nu0ctu0cxdyj oQC2OAkXYh6/3T9MWZ0H+ERw8qCDD3JCmLntyk4+HnwLriYJ6UukJiMp33KQnt32D/w1/Ob2pIpSf RKijOOvhIx5KR/9QUu+Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mIUDr-002g87-6u; Tue, 24 Aug 2021 11:04:03 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mIU8U-002dFd-2s for linux-arm-kernel@lists.infradead.org; Tue, 24 Aug 2021 10:58:31 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E98931476; Tue, 24 Aug 2021 03:58:28 -0700 (PDT) Received: from C02TD0UTHF1T.local (unknown [10.57.90.204]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 16BDD3F66F; Tue, 24 Aug 2021 03:58:26 -0700 (PDT) Date: Tue, 24 Aug 2021 11:58:24 +0100 From: Mark Rutland To: jing yangyang , Lorenzo Pieralisi Cc: Sudeep Holla , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, jing yangyang , Zeal Robot Subject: Re: [PATCH linux-next] firmware/psci: fix application of sizeof to pointer Message-ID: <20210824105824.GC96738@C02TD0UTHF1T.local> References: <61d3cc7e5cd4a819381fcb22e1853d6f48a0c927.1629212319.git.jing.yangyang@zte.com.cn> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <61d3cc7e5cd4a819381fcb22e1853d6f48a0c927.1629212319.git.jing.yangyang@zte.com.cn> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210824_035830_237186_A6533012 X-CRM114-Status: GOOD ( 17.05 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Aug 19, 2021 at 07:30:16PM -0700, jing yangyang wrote: > sizeof when applied to a pointer typed expression gives the size of > the pointer. > > ./drivers/firmware/psci/psci_checker.c:158:41-47: ERROR application of sizeof to pointer > > This issue was detected with the help of Coccinelle. > > Reported-by: Zeal Robot > Signed-off-by: jing yangyang >From looking at the git history, we should add: Fixes: 7401056de5f8d4ea ("drivers/firmware: psci_checker: stash and use topology_core_cpumask for hotplug tests)" With that: Acked-by: Mark Rutland Lorenzo, how do we normally direct these patches? Thanks, Mark. > --- > drivers/firmware/psci/psci_checker.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/firmware/psci/psci_checker.c b/drivers/firmware/psci/psci_checker.c > index 9a369a2..116eb46 100644 > --- a/drivers/firmware/psci/psci_checker.c > +++ b/drivers/firmware/psci/psci_checker.c > @@ -155,7 +155,7 @@ static int alloc_init_cpu_groups(cpumask_var_t **pcpu_groups) > if (!alloc_cpumask_var(&tmp, GFP_KERNEL)) > return -ENOMEM; > > - cpu_groups = kcalloc(nb_available_cpus, sizeof(cpu_groups), > + cpu_groups = kcalloc(nb_available_cpus, sizeof(*cpu_groups), > GFP_KERNEL); > if (!cpu_groups) { > free_cpumask_var(tmp); > -- > 1.8.3.1 > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel