From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D3A1C4320A for ; Wed, 25 Aug 2021 13:33:45 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1AA2460F92 for ; Wed, 25 Aug 2021 13:33:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 1AA2460F92 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=iYB8CZqeTc2vW2qZr+OtB0muR90GfO9LXmF86gIwhO0=; b=c0FmZ7VtasEYf6 SjSgcNSVr0iDbm3jkxkXpn/uJgpufa6GaOo2MHzEhYotFdGKJMIaQQc8/plWdecRNiLuZv9b7UQvl Z+IMgiyfecmsU+PpTR8NCCpktHSLpNAQcwyoZ0+MVPyHC57lV0gsr8HUZNL1PMDTUyk/2pMxNF0Rn D0H2LCAMP+KgfzPN5AA2MMcQwfSbaNfgv3sKjXugNSiIZzjSmaxsC+XHmXJkTcxm+fNEZAXdj2lku g5Xv2kZ2/g5hPYdfJfiCViQk17F+JCqI75G3m6e5o+RW6Z42WQzPif7pdV9EI5jeurkfidPIGYvff yRKl0m8+huvKnSIGdtXQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mIszV-0074CV-Du; Wed, 25 Aug 2021 13:30:53 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mIszR-0074C6-Ln for linux-arm-kernel@lists.infradead.org; Wed, 25 Aug 2021 13:30:51 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 067C2106F; Wed, 25 Aug 2021 06:30:43 -0700 (PDT) Received: from e123427-lin.cambridge.arm.com (unknown [10.57.43.179]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 469F13F5A1; Wed, 25 Aug 2021 06:30:41 -0700 (PDT) Date: Wed, 25 Aug 2021 14:30:35 +0100 From: Lorenzo Pieralisi To: Yajun Deng Cc: catalin.marinas@arm.com, will@kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH linux-next] arm64: PCI: Introduce pcibios_free_irq() helper function Message-ID: <20210825133035.GA20522@e123427-lin.cambridge.arm.com> References: <20210825071612.21543-1-yajun.deng@linux.dev> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210825071612.21543-1-yajun.deng@linux.dev> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210825_063049_801811_E2B44B81 X-CRM114-Status: GOOD ( 20.59 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Aug 25, 2021 at 03:16:12PM +0800, Yajun Deng wrote: > Introduce pcibios_free_irq() to free irq in pci_device_probe() and > pci_device_remove() that in drivers/pci/pci-driver.c. Add a rationale - it is just code inspection or you are fixing a bug ? > Signed-off-by: Yajun Deng > --- > arch/arm64/kernel/pci.c | 10 +++++++++- > 1 file changed, 9 insertions(+), 1 deletion(-) > > diff --git a/arch/arm64/kernel/pci.c b/arch/arm64/kernel/pci.c > index 1006ed2d7c60..40da5aff4548 100644 > --- a/arch/arm64/kernel/pci.c > +++ b/arch/arm64/kernel/pci.c > @@ -25,10 +25,18 @@ > int pcibios_alloc_irq(struct pci_dev *dev) > { > if (!acpi_disabled) > - acpi_pci_irq_enable(dev); > + return acpi_pci_irq_enable(dev); This is an unrelated change and it is potentially introducing regressions. I need to page in the reasons why on arm64 we had to resort to pcibios_alloc_irq() (probe ordering IIRC) - in the meanwhile this function stays as it is. > return 0; > } > + > +void pcibios_free_irq(struct pci_dev *dev) > +{ > + if (!acpi_disabled) > + acpi_pci_irq_disable(dev); > + > +} Adding pcibios_free_irq() makes sense and I believe it is a genuine "fix". Please add any information in the commit log that explains the run-time condition you are fixing. Thanks, Lorenzo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel