From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: John Garry <john.garry@huawei.com>
Cc: "Martin K . Petersen" <martin.petersen@oracle.com>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Hannes Reinecke <hare@suse.com>, Christoph Hellwig <hch@lst.de>,
Bart Van Assche <bvanassche@acm.org>,
Arnd Bergmann <arnd@arndb.de>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: arm scsi drivers
Date: Fri, 27 Aug 2021 16:09:39 +0100 [thread overview]
Message-ID: <20210827150938.GU22278@shell.armlinux.org.uk> (raw)
In-Reply-To: <9552a506-e53a-3fd3-b38e-3cec81e713a6@huawei.com>
I haven't, sorry.
I have run 5.x kernels on the hardware, and do have a set of patches
kicking around for the SCSI drivers that do some cleanups. It looks
like the fixup is pretty simple from the links you've sent - using
scsi_cmd_to_rq() to get the tag.
That said, I think I may only had one SCSI drive that came anywhere
close to supported tagged queuing, so I never put much effort into
tagged command support. Both acornscsi and fas216 have it disabled
for this reason, so it's probably easier just to rip the tag code
out of these drivers.
Russell.
On Fri, Aug 27, 2021 at 03:55:05PM +0100, John Garry wrote:
> Hi Russell,
>
> Have you had a chance to consider the below?
>
> Thanks
>
>
> >
> > Recently we tried to remove scsi_cmnd.tags struct member [0].
> >
> > However it now shows that some of the arm SCSI drivers continue to use
> > this [1]. I think any other driver usage of this member had been found
> > and removed.
> >
> > The impression is that the usage of scsi_cmnd.tag in those drivers is
> > quite dubious.
> >
> > Now checking [2], it appears that you may have had some patches for
> > these drivers locally.
> >
> > So is that the case? Is this HW still used with bleeding edge kernels?
> > If so, can we fix up this tag management?
> >
> > [0] https://lore.kernel.org/linux-scsi/6c83bd7f-9fd2-1b43-627f-615467fa55d4@huawei.com/T/#mb47909f38f35837686734369600051b278d124af
> >
> >
> > [1] https://lore.kernel.org/linux-scsi/6c83bd7f-9fd2-1b43-627f-615467fa55d4@huawei.com/T/#md5d786e5753083b2f3e8e761b1c69809f82c7485
> >
> >
> > [2]
> > https://lore.kernel.org/lkml/20210109174357.GB1551@shell.armlinux.org.uk/
> >
> > Thanks,
> > John
>
>
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-08-27 15:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <5a72842f-99db-8787-120b-6d85e7884e2d@huawei.com>
2021-08-27 14:55 ` arm scsi drivers John Garry
2021-08-27 15:09 ` Russell King (Oracle) [this message]
2021-08-27 15:23 ` Hannes Reinecke
2021-09-01 8:03 ` John Garry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210827150938.GU22278@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=arnd@arndb.de \
--cc=bvanassche@acm.org \
--cc=hare@suse.com \
--cc=hch@lst.de \
--cc=jejb@linux.ibm.com \
--cc=john.garry@huawei.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox