From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 272CAC432BE for ; Sun, 29 Aug 2021 14:30:17 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D463860F36 for ; Sun, 29 Aug 2021 14:30:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org D463860F36 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=EVeZBBmeeiAB0oJtBlYpYBIFFuRjq6Wyu6HXqZuZh4w=; b=YTbG0bPCPrx1wo WQTW7SlR2gSuR1ZwYcVNztCKi1af2WQjupsju9/rNTFfL+hiEclYuXdRkE0A7Girhs2owWq0G4K1+ sDc9tofVh1/H+Q884EIlTwKh1euHTUGmJKqp0Asc8Xel/Ef6McDNjan0kFu9Y16KfpsHXB1uLoI9j ixZ6hr9jeI76YiVmyFlQ1G5uokHKL7Wj7gkQYGhryn0di9NFcShOdLjeO87hBWwyHQv+zbUAvnzqL vrMFFFAVRHeNyM1SwhMLc+8pUNXyxE2G3h6Nw0K4EwheLeZ2Kp6zy4pUCup17GasjhXaMWS1Jbz2w P+zeeGFHVMU4YsFx5p2g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mKLnF-00FcpX-BO; Sun, 29 Aug 2021 14:28:17 +0000 Received: from mail-pg1-x52d.google.com ([2607:f8b0:4864:20::52d]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mKLn9-00Fcob-AP for linux-arm-kernel@lists.infradead.org; Sun, 29 Aug 2021 14:28:15 +0000 Received: by mail-pg1-x52d.google.com with SMTP id q68so10811099pga.9 for ; Sun, 29 Aug 2021 07:28:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=qOZleRD8pCzJyM10JVouBjLRKaJx/Dr3UENRm/FbtnA=; b=BS30odEtgM4ZIUyd4SzRHypP8CAs70ZQrHf2PcAgQD2VuIRE9quIVFx90p9n6sKa1l or1b+3yNRrflvFOaUeCAybNZl/Bgtdvtb2nM8pguUN73BzH7o+boz9KRE79dDhfXxOre 82Zr7sILiq6lP426960l550AEwRqr2NoXD5LazSPlVCoPwrteLkxVmyjRY7gR6B9MbEq UIzVXHU1II8/F11M2E4cGgqr8IK9Omnww7NXpwThFqimZPcyleW2/58iXvAdqsZDNtWT o7G8HEgi5q3dWh5MEAlgrH9c3c0/HuqAFKNFdotSJTgRr6rkVyXkpX2aH5rwuTYiwxB9 o/XQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=qOZleRD8pCzJyM10JVouBjLRKaJx/Dr3UENRm/FbtnA=; b=WpnPU+Ltc+97/gvdgf1zRgxaI2XiVFKDXyn3N2zOVC3onTh5PkkqtGYIHTgbCn/60f IFpMW9O1nttwuM+O/EO+9SwRtau29b2GbQvpPx+toRhWdfucuYBQZb6lr4TdbpEu9DCG 6dsnn2FI3UZfbaB4iQOSeoxqgMYTeWM3JXeu2Jo7ThYa8Q7F9sYMsLMugvw1IQLvzQyI tNIHoKeXYJHyKZqdAEUjRO2Am6qg70+ku8LrOIgENXNjHx4QJGf42q1DNW7SUkK3AYj4 /YTUVrRsuNhQtxtDSlieNU34/9NQzWesECirnEVrMX0HJkCQq13coDXMgsbicWh8k/Xx YFBw== X-Gm-Message-State: AOAM530lXqB1WFW0m+S0WtijAfmq86tZZ30ZQyUhoGGMS9CZL48uf1pg 1nUDc/KaKxQmIiriAhYorr1cYg== X-Google-Smtp-Source: ABdhPJwizvyf802+JtqxkB4pHwYNMDzQeajZ0wsosunlo6KatX/rEBVWDJmbeJ5Ldm6grKGeh2+ubA== X-Received: by 2002:a65:6487:: with SMTP id e7mr17088629pgv.27.1630247288979; Sun, 29 Aug 2021 07:28:08 -0700 (PDT) Received: from leoy-ThinkPad-X240s ([213.173.35.225]) by smtp.gmail.com with ESMTPSA id t28sm12818428pfe.144.2021.08.29.07.28.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 29 Aug 2021 07:28:08 -0700 (PDT) Date: Sun, 29 Aug 2021 22:28:02 +0800 From: Leo Yan To: Tao Zhang Cc: Mathieu Poirier , Suzuki K Poulose , Alexander Shishkin , Mike Leach , Greg Kroah-Hartman , coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Tingwei Zhang , Mao Jinlong , Yuanfang Zhang Subject: Re: [PATCH] coresight: cti: Correct the parameter for pm_runtime_put Message-ID: <20210829142802.GA186881@leoy-ThinkPad-X240s> References: <1629365377-5937-1-git-send-email-quic_taozha@quicinc.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1629365377-5937-1-git-send-email-quic_taozha@quicinc.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210829_072811_438113_4CC41C6C X-CRM114-Status: GOOD ( 20.81 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Tao, On Thu, Aug 19, 2021 at 05:29:37PM +0800, Tao Zhang wrote: > The input parameter of the function pm_runtime_put should be the > same in the function cti_enable_hw and cti_disable_hw. The correct > parameter to use here should be dev->parent. > > Signed-off-by: Tao Zhang > --- > drivers/hwtracing/coresight/coresight-cti-core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/hwtracing/coresight/coresight-cti-core.c b/drivers/hwtracing/coresight/coresight-cti-core.c > index e2a3620..8988b2e 100644 > --- a/drivers/hwtracing/coresight/coresight-cti-core.c > +++ b/drivers/hwtracing/coresight/coresight-cti-core.c > @@ -175,7 +175,7 @@ static int cti_disable_hw(struct cti_drvdata *drvdata) > coresight_disclaim_device_unlocked(csdev); > CS_LOCK(drvdata->base); > spin_unlock(&drvdata->spinlock); > - pm_runtime_put(dev); > + pm_runtime_put(dev->parent); coresight_register() allocates data structure 'coresight_device' and assigns probed device to the field 'coresight_device::dev::parent'; thus afterwards we need to pass 'coresight_device::dev::parent' for pm_runtime_xxx() functions. It's not directive for understanding, so log the info at here. For the patch: Reviewed-by: Leo Yan We could wait for Mike to review as well. Thanks, Leo > return 0; > > /* not disabled this call */ > -- > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, > a Linux Foundation Collaborative Project > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel