Re: [PATCH v2 44/52] ARM: dts: v3s: Remove useless DMA properties

Jernej Škrabec
2021-09-05T21:10:21Z

Hi Maxime!

Dne sreda, 01. september 2021 ob 11:18:44 CEST je Maxime Ripard napisal(a):
> The crypto engine binding doesn't allow for any DMA property, yet the
> v3s define some. Remove them.
>
> Signed-off-by: Maxime Ripard <maxime@cerno.tech>
> ---
> arch/arm/boot/dts/sun8i-v3s.dtsi | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/sun8i-v3s.dtsi b/arch/arm/boot/dts/sun8i-
v3s.dtsi
> index b30bc1a25ebb..44382e36e825 100644
> --- a/arch/arm/boot/dts/sun8i-v3s.dtsi
> +++ b/arch/arm/boot/dts/sun8i-v3s.dtsi
> @@ -285,8 +285,6 @@ crypto@1c15000 {
> interrupts = <GIC_SPI 80
IRQ_TYPE_LEVEL_HIGH>;
> clocks = <&ccu CLK_BUS_CE>, <&ccu CLK_CE>;
> clock-names = "ahb", "mod";
> - dmas = <&dma 16>, <&dma 16>;
> - dma-names = "rx", "tx";

Since V3s documentation mentions those DMA channels, wouldn't be better to
update bindings instead?

Best regards,
Jernej

> resets = <&ccu RST_BUS_CE>;
> reset-names = "ahb";
> };
> --
> 2.31.1