From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61798C432BE for ; Thu, 2 Sep 2021 12:56:25 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2E49760EBA for ; Thu, 2 Sep 2021 12:56:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 2E49760EBA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=4fXJC4MJ4h2XG1zFAmKxwqv6+MWJd2GtBxYCHUVVIBs=; b=nxo+JDQh8wJ3WC OTIHAM7ppr84hDolm/9a9B0fxzlcJ7y7cVMEAaC55E7ofM5TRmejmkyMPNpRO7rXCQuTxT2P2D1Ee cc2SuBPdFZb420NmLJalKETP/rzDvgsIDzn58yl6vge+QbQbt0VGwC4Yr4LPRDe5gCa4QGwO4SD16 tq7lSNBkjrMbGIV9jdmhBAkT0sFpQJlrN43Ay1c38/X0DQ8hYon2IhwUhZ4CbojP0NTFbLx1qMOWT R3VSHdFgos3H0srPGAEtSxHbshizJsGKUQh+74bF8LFTxMdVBIu/Wfmc0tpK7bXYSOtZEBcBX8uVo lSuNrS9/ZV0OTrff053Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mLmEt-009cyB-IA; Thu, 02 Sep 2021 12:54:43 +0000 Received: from mail-pj1-x102e.google.com ([2607:f8b0:4864:20::102e]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mLmEn-009cxF-BF for linux-arm-kernel@lists.infradead.org; Thu, 02 Sep 2021 12:54:41 +0000 Received: by mail-pj1-x102e.google.com with SMTP id gp20-20020a17090adf1400b00196b761920aso1378211pjb.3 for ; Thu, 02 Sep 2021 05:54:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=0ep4NCpmYbrJnytWXXjt0p8Pd2myd+G98CcinMn3pzU=; b=PmqrxALEt7K+mMlScjFji7LT+6SiSbaGn1vwwSnCUaukPorGQoGY5g94MqESofpEPL e5eXj4rwxqkhXS+WHQhsdADZqFpY0VP90N3aLIVWyIhXrz4PDoVVnjLc0n20amL59yMk zdzWbmCXYvIakxY5OLboaK/BvePNcasDyKUTKJoqMedbIat8taXi2+Fo74QDibtgGAk6 6ZEZolCt3RvkGBPW707/ejWXOgz2EqEMs7C9H97NjFyxbzJOrGv9mqWG/IoNzSEAar9V YP52DB2G/Ic0rCC4+uvViNQSYQ/lZPYEJNP81ATew21MgQp2n78+XqJT+DnOKJ7XMs44 Vv3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=0ep4NCpmYbrJnytWXXjt0p8Pd2myd+G98CcinMn3pzU=; b=Mrhof9oqxhupq1E6IX5PCVmE7BSj6fnRsHZhtPMa7MG1OnMDqIDkr+jAllFVoICWIC xQlm0Iv3a0Mx50mXQW+2AjyPUGbML9jf9A/Rn00J9CD6UJA7YsXnA6iqkzcc1klF8QcN nSO6Vg2Y1g+biRHdUlGYlx7NPZHgvT8tDmdt91QhHvbzTxdcxKJYg23Uji19pLQXnApO z1PcROYWyVPP/uHBSFtA2Lhad9rcasGlowjDMRxKPj801zpaEVi4ux5MOuc80smb/xFU gkCtpqcPcfAF9hMvPokxmqnCAO0+XKpJUo+8OxpDLB5Q4Hp/QNJt9E7DqsR17fY6Ym5m 0fbA== X-Gm-Message-State: AOAM530go6r7ow41yfd7WDv58pRS83DfNIKTEDhIrm6EEb6Jv6LcWgCm rzSXagPVlSo+Vk+qDZQewuvz/Q== X-Google-Smtp-Source: ABdhPJwMHvXJUO6+PV/yrdv1OrvDvNdZRuRp/gFnWCh8ydT7wdMCtYKf8bnfE+Qgmas84tJeeBT0Ag== X-Received: by 2002:a17:902:d717:b0:133:a5f6:6be6 with SMTP id w23-20020a170902d71700b00133a5f66be6mr2850570ply.14.1630587276206; Thu, 02 Sep 2021 05:54:36 -0700 (PDT) Received: from leoy-ThinkPad-X240s ([213.173.35.225]) by smtp.gmail.com with ESMTPSA id n1sm2344644pfv.209.2021.09.02.05.54.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Sep 2021 05:54:35 -0700 (PDT) Date: Thu, 2 Sep 2021 20:54:31 +0800 From: Leo Yan To: Robin Murphy Cc: Mathieu Poirier , Suzuki K Poulose , Mike Leach , Alexander Shishkin , coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3] coresight: tmc-etr: Speed up for bounce buffer in flat mode Message-ID: <20210902125431.GI303522@leoy-ThinkPad-X240s> References: <20210829135409.186732-1-leo.yan@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210902_055437_428966_4749627D X-CRM114-Status: GOOD ( 16.44 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Robin, On Wed, Sep 01, 2021 at 09:03:30PM +0100, Robin Murphy wrote: [...] > > @@ -600,6 +601,7 @@ static int tmc_etr_alloc_flat_buf(struct tmc_drvdata *drvdata, > > { > > struct etr_flat_buf *flat_buf; > > struct device *real_dev = drvdata->csdev->dev.parent; > > + ssize_t aligned_size; > > /* We cannot reuse existing pages for flat buf */ > > if (pages) > > @@ -609,11 +611,18 @@ static int tmc_etr_alloc_flat_buf(struct tmc_drvdata *drvdata, > > if (!flat_buf) > > return -ENOMEM; > > - flat_buf->vaddr = dma_alloc_coherent(real_dev, etr_buf->size, > > - &flat_buf->daddr, GFP_KERNEL); > > - if (!flat_buf->vaddr) { > > - kfree(flat_buf); > > - return -ENOMEM; > > + aligned_size = PAGE_ALIGN(etr_buf->size); > > + flat_buf->pages = alloc_pages_node(node, GFP_KERNEL | __GFP_ZERO, > > + get_order(aligned_size)); > > + if (!flat_buf->pages) > > + goto fail_alloc_pages; > > + > > + flat_buf->vaddr = page_address(flat_buf->pages); > > + flat_buf->daddr = dma_map_page(real_dev, flat_buf->pages, 0, > > + aligned_size, DMA_FROM_DEVICE); > > Use dma_alloc_noncoherent() rather than open-coding this - bare > alloc_pages() has no understanding of DMA masks, and you wouldn't want to > end up in the worst case of dma_map_page() bounce-buffering your bounce > buffer... Will refine the code with dma_alloc_noncoherent(); it's much reliable than the self writing code. Thanks a lot for the suggestion! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel