From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4AA29C83029 for ; Thu, 2 Sep 2021 17:21:02 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1559660FE6 for ; Thu, 2 Sep 2021 17:21:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 1559660FE6 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Jow7DnxxslCDLn6IYC+9ltJmTcxVhTtR8So+QdLJEAc=; b=XQaVuT3ovg/imH dbrtMfpkLaVwVaUv6i3U+v5CWQzRRmaNuo/LgnYskafhJvCjXjFX/wNb6fF1QyxuOSVZmVvSP7Nmp hFw6oQUFOFJGbnniCP3CSKI+h9LRS+HzhyJ0BVkBDntsW8KVSR3woBZqIgrek7b2QlUfeKk8sGCQZ cYW3H0Tpvut3TWOmtD6i/S8NbZirPVzyeeyvaRiMWN8F4ux1xA9LDJUMgvxvRSm5RX2uH02zi+b99 Qqu+gy63O4jRLkdsTNAPNQ6qEhKKVOI2qogj+QkyupUzqwVK5ogqzZsHrSwHZ+yP9cP74LMeZlQMK Il7hDACM97qrz7jjRCBg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mLqMl-00A6S2-Aa; Thu, 02 Sep 2021 17:19:07 +0000 Received: from mail-pf1-x42d.google.com ([2607:f8b0:4864:20::42d]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mLqMh-00A6Rj-I2 for linux-arm-kernel@lists.infradead.org; Thu, 02 Sep 2021 17:19:04 +0000 Received: by mail-pf1-x42d.google.com with SMTP id r13so2173707pff.7 for ; Thu, 02 Sep 2021 10:19:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=necS4VUpe4t7hOX5NZ6mXxMU8h8wBvfjay7U9C07eQQ=; b=VJLDdqzk3qgXNuXYDr1ZSorcfVQ3xeVIK8eVgKzfW+ov5t5VVcrbXTNquA/KMLDwsK q9GrsDuRDs/GxmQh0UrshO6ONiRcJOm0gUfRD28EBJL6JiifFpJLolnUhUGtFVkJdD0C 0GTeHI0FgfIZ8p4ITsXEZRNdnYBhTULje1nDYYgfMUxSL/zo/oJxDogSBZ6UtNt1E7q+ TmBwv8q+RubCc5JZKskX2ukB5Rb4u4zxFvP+bO9NN9aEn22197h7JlfIQW+Mp9xhoA2H 1otIcgNe5u+u5r6+WWAq46kO0vVrBXz3VovtGj4wrAmQ8qtHLZX1jlI9VYF8hT742n9V 7BZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=necS4VUpe4t7hOX5NZ6mXxMU8h8wBvfjay7U9C07eQQ=; b=BxmJQPoGZRnssq8AnZpLRiJStFwINtNgJYO3pde/Hj7fWt6Qx1D6D7rBUkJVjtOsar hGs1Yur9bkutxo8mfMfmnrY6gjIB9bXV0Xp0yZBoBYzFJO5DzCJZ1+iPQTb8OxyUbb1U yuphkbq70kSPCins9jJdeyesWOjhUijRBetwpcgTU/t+jCx1JHWIawk/SMfI4oPn2YNC wzO2cAMdCSVlPgQw6UZlGqbwBjHjZrtpKJJOKuyVgYDuHqgUFNhgvJlXETiY/RnBFZ1B mUpIYtokRIkagvjr7/xa/RIUPSTIStGnEDUcmVXuti568zgS2hq0ohyxWiAcXrMo4QMC 9ASw== X-Gm-Message-State: AOAM530jDnDdfRtVrkkvQg21qpBlrFw+5QaHpYYf3BuFk6YdYs+dcswr yQy8fUbgQNi3yWLMSxmvPF1W2iRTP23Aeg== X-Google-Smtp-Source: ABdhPJw6m0R3eeCOVwfyAds9HNp2lYE8IdVFXoztsykKcDM4eZDfaWpyCE+rO2hwcXIfstyHDVA7rg== X-Received: by 2002:aa7:938c:0:b0:3b2:87fe:a598 with SMTP id t12-20020aa7938c000000b003b287fea598mr4258210pfe.74.1630603141401; Thu, 02 Sep 2021 10:19:01 -0700 (PDT) Received: from p14s (S0106889e681aac74.cg.shawcable.net. [68.147.0.187]) by smtp.gmail.com with ESMTPSA id a11sm3083215pgj.75.2021.09.02.10.18.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Sep 2021 10:18:59 -0700 (PDT) Date: Thu, 2 Sep 2021 11:18:56 -0600 From: Mathieu Poirier To: Tao Zhang Cc: Suzuki K Poulose , Alexander Shishkin , Mike Leach , Leo Yan , Greg Kroah-Hartman , coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Tingwei Zhang , Mao Jinlong , Yuanfang Zhang Subject: Re: [PATCH] coresight: cti: Correct the parameter for pm_runtime_put Message-ID: <20210902171856.GA1078000@p14s> References: <1629365377-5937-1-git-send-email-quic_taozha@quicinc.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1629365377-5937-1-git-send-email-quic_taozha@quicinc.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210902_101903_646608_72A48C09 X-CRM114-Status: GOOD ( 22.36 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Tao, Apologies for the late reply - this patch fell through the cracks. On Thu, Aug 19, 2021 at 05:29:37PM +0800, Tao Zhang wrote: > The input parameter of the function pm_runtime_put should be the > same in the function cti_enable_hw and cti_disable_hw. The correct > parameter to use here should be dev->parent. > > Signed-off-by: Tao Zhang > --- > drivers/hwtracing/coresight/coresight-cti-core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/hwtracing/coresight/coresight-cti-core.c b/drivers/hwtracing/coresight/coresight-cti-core.c > index e2a3620..8988b2e 100644 > --- a/drivers/hwtracing/coresight/coresight-cti-core.c > +++ b/drivers/hwtracing/coresight/coresight-cti-core.c > @@ -175,7 +175,7 @@ static int cti_disable_hw(struct cti_drvdata *drvdata) > coresight_disclaim_device_unlocked(csdev); > CS_LOCK(drvdata->base); > spin_unlock(&drvdata->spinlock); > - pm_runtime_put(dev); > + pm_runtime_put(dev->parent); You are correct - I have added this patch to my next tree. Thanks, Mathieu > return 0; > > /* not disabled this call */ > -- > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, > a Linux Foundation Collaborative Project > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel