Re: [PATCH v2 05/10] iio: adc: at91-sama5d2-adc: add support for separate end of conversion registers

Jonathan Cameron
2021-09-05T10:11:03Z

On Tue, 31 Aug 2021 06:45:01 +0000
<Eugen.Hristev@microchip.com> wrote:

> On 8/24/21 2:54 PM, Eugen Hristev wrote:
> > Some platforms have separated the end-of-conversion information from the
> > usual ISR/IMR/IER/IDR registers, into EOC_ISR/EOC_IMR/EOC_IER/EOC_IDR.
> > To cope with both variants, helpers are being added, that will make
> > code more clear and more easy to read.
> >
> > Signed-off-by: Eugen Hristev <eugen.hristev@microchip.com>
> > ---
>
> Hi Jonathan,
>
> If you can still make changes on your testing branch, I noticed a typo
> in the shortcommit of this patch : 'at91-sama5d2-adc' instead of
> 'at91-sama5d2_adc' , grepping through commits in the future might miss
> this patch, so maybe you can change it ?
Testing is very much rebaseable. I won't push the tree out as something
I'm not happy to rebase until I have a stable base for it (after rc1).

So dropped v2. I'll get to v3 a bit later today probably.

Jonathan

>
> Thanks,
> Eugen