From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7527C433EF for ; Sun, 5 Sep 2021 10:23:09 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 71A5060FBF for ; Sun, 5 Sep 2021 10:23:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 71A5060FBF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=56MZUdc1ZS+gOaEU79h6MKDbQt8G+BzhZg/5lCtm1T0=; b=TtYWP+G6ABprin 3ygKRSeIpvJH4UL/S05AVg6OlnYDHm61XG87uK1QIELafEzEvEufex8HUM83Slwpxz98bNA823O+U goCpC9hfPaLK5XBujOj9Xq0TyF/326yBOJuaO7UmW3/YQ/fXSSruXwHCMEkmIVdAYlzEe0cIBrEAW LIFFg1pKaMvSyxJ1vFWukfdHLpauYmWAz2qzMxYI1ViMNZ1LH1UxiwK5bz8UXdlSFc+vb7rAqBvtW c+IJPMMXthTEBlsN5QdH+IbU7jyRDhR/72hzdB1wjHqk4ce7UYK6gKh1j9ezcC5gQrnjJwRylR2M1 avsTbQ1k+ECTvDfxQQpg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mMpHB-00FaWG-5j; Sun, 05 Sep 2021 10:21:25 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mMpH8-00FaVY-64 for linux-arm-kernel@lists.infradead.org; Sun, 05 Sep 2021 10:21:23 +0000 Received: from jic23-huawei (cpc108967-cmbg20-2-0-cust86.5-4.cable.virginm.net [81.101.6.87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8858760F6D; Sun, 5 Sep 2021 10:21:18 +0000 (UTC) Date: Sun, 5 Sep 2021 11:24:39 +0100 From: Jonathan Cameron To: Subject: Re: [PATCH v3 04/10] iio: adc: at91-sama5d2_adc: convert to platform specific data structures Message-ID: <20210905112439.3f90f5dd@jic23-huawei> In-Reply-To: References: <20210901123013.329792-1-eugen.hristev@microchip.com> <20210901123013.329792-5-eugen.hristev@microchip.com> X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210905_032122_289681_1B204D70 X-CRM114-Status: GOOD ( 14.29 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Ludovic.Desroches@microchip.com, robh+dt@kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org > > @@ -700,9 +786,9 @@ static int at91_adc_read_position(struct at91_adc_state *st, int chan, u16 *val) > > *val = 0; > > if (!st->touch_st.touching) > > return -ENODATA; > > - if (chan == AT91_SAMA5D2_TOUCH_X_CHAN_IDX) > > + if (chan == st->soc_info.platform->touch_chan_x) > > *val = at91_adc_touch_x_pos(st); > > - else if (chan == AT91_SAMA5D2_TOUCH_Y_CHAN_IDX) > > + else if (chan == st->soc_info.platform->touch_chan_y) > > *val = at91_adc_touch_y_pos(st); > > else > > return -ENODATA; > > @@ -715,7 +801,7 @@ static int at91_adc_read_pressure(struct at91_adc_state *st, int chan, u16 *val) > > *val = 0; > > if (!st->touch_st.touching) > > return -ENODATA; > > - if (chan == AT91_SAMA5D2_TOUCH_P_CHAN_IDX) > > + if (chan == st->soc_info.platform->touch_chan_y) > > Could you please tidy up here before applying, there is a slip on my > side, it should be the pressure channel : > if (chan == st->soc_info.platform->touch_chan_p) > > (not the Y channel ) > > Thanks and sorry ! Done _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel