From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 24568C433F5 for ; Tue, 7 Sep 2021 06:13:52 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D3F9561101 for ; Tue, 7 Sep 2021 06:13:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org D3F9561101 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ZmNJVjvvkJySK0v7TCyvLVIBp95bTsOmRSN2Gc6I0yQ=; b=EHwwP5+lszcGFk dVVSGrskPuFvzeEyAaPZtM4pTH3cBHHSd0NQ6XFopDrQ8tfV1nQv3b0P1bzHMJ+hBML2it9bDSJzT DKwv+UI910dxiTR9CPmJdI2HjfwpzDWyggSP/+aJN4PEv/Wx22i1abHUzE9+GQBZ4lmyymf3KOS2k mIQeMdNUDE5iF36XFkjwf4YHOWRBVKWA1LpjolEsXbIMatjErapaClc3oH6tLxcqfaqv51yYAK5qe j8csvMOnlHVt8SIeFjUVd/Fzlbg1UlFtZ5tLaDvKkmbsy/Hs8MUlV82nDr7ViYj12rz1D/HeUrt8y XGttKdnr32pay9DPD9Qg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mNUKS-002XL0-Ts; Tue, 07 Sep 2021 06:11:33 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mNUKP-002XJa-Oz for linux-arm-kernel@lists.infradead.org; Tue, 07 Sep 2021 06:11:31 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id E97756056B; Tue, 7 Sep 2021 06:11:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1630995089; bh=iwU9N70UGDvBd8wGddAqOScYb0ZO+qxtvTi05n0Rhi4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=pwlcT2nod6VxxIrsAPZri7Yc/dcdG0fjp9kvqrFNx02jPivt3QaJ+0zA/3iwmnDF7 N9zcQBRvB+khkeBrx0YvS3sEIgEGAnLYS6LToUK3l/oP+oleHMc5qVRwRFmxz5gXv/ W9RConm41LYZA0pNlvgONx4Jq3pVxxqa99gVJU5cl9lvtxIE4nPTNPw6MrbeKCmfxi fTthldn1GocWQq0oXietT6oz8MGIua4ZRb5TpjJzUXtSo50Smr9gzVl4EruW+SjmBI IqniqH52l2dMNgCmAil3HSx50DbWd73xUxAwtOcviSEdK/a3S8Rl09dK4iQsh+BKjG 2nsbq/HUXhS0A== Date: Tue, 7 Sep 2021 08:11:25 +0200 From: Mauro Carvalho Chehab To: Randy Dunlap Cc: linux-kernel@vger.kernel.org, kernel test robot , linux-media@vger.kernel.org, Andrzej Pietrasiewicz , Jacek Anaszewski , Sylwester Nawrocki , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2] media: s5p-jpeg: rename JPEG marker constants to prevent build warnings Message-ID: <20210907081125.21c311f1@coco.lan> In-Reply-To: <20210907044022.30602-1-rdunlap@infradead.org> References: <20210907044022.30602-1-rdunlap@infradead.org> X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.30; x86_64-redhat-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210906_231129_920889_3FC85133 X-CRM114-Status: GOOD ( 14.75 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Em Mon, 6 Sep 2021 21:40:22 -0700 Randy Dunlap escreveu: > The use of a macro named 'RST' conflicts with one of the same name > in arch/mips/include/asm/mach-rc32434/rb.h. This causes build > warnings on some MIPS builds. > > Change the names of the JPEG marker constants to be in their own > namespace to fix these build warnings and to prevent other similar > problems in the future. > > Fixes these build warnings: > > In file included from ../drivers/media/platform/s5p-jpeg/jpeg-hw-exynos3250.c:14: > ../drivers/media/platform/s5p-jpeg/jpeg-core.h:43: warning: "RST" redefined > 43 | #define RST 0xd0 > | > ../arch/mips/include/asm/mach-rc32434/rb.h:13: note: this is the location of the previous definition > 13 | #define RST (1 << 15) > > In file included from ../drivers/media/platform/s5p-jpeg/jpeg-hw-s5p.c:13: > ../drivers/media/platform/s5p-jpeg/jpeg-core.h:43: warning: "RST" redefined > 43 | #define RST 0xd0 > ../arch/mips/include/asm/mach-rc32434/rb.h:13: note: this is the location of the previous definition > 13 | #define RST (1 << 15) > > In file included from ../drivers/media/platform/s5p-jpeg/jpeg-hw-exynos4.c:12: > ../drivers/media/platform/s5p-jpeg/jpeg-core.h:43: warning: "RST" redefined > 43 | #define RST 0xd0 > ../arch/mips/include/asm/mach-rc32434/rb.h:13: note: this is the location of the previous definition > 13 | #define RST (1 << 15) > > In file included from ../drivers/media/platform/s5p-jpeg/jpeg-core.c:31: > ../drivers/media/platform/s5p-jpeg/jpeg-core.h:43: warning: "RST" redefined > 43 | #define RST 0xd0 > ../arch/mips/include/asm/mach-rc32434/rb.h:13: note: this is the location of the previous definition > 13 | #define RST (1 << 15) > > Also update the kernel-doc so that the word "marker" is not > repeated. > > Fixes: bb677f3ac434 ("[media] Exynos4 JPEG codec v4l2 driver") > Signed-off-by: Randy Dunlap > Reported-by: kernel test robot > Cc: Mauro Carvalho Chehab > Cc: linux-media@vger.kernel.org > Cc: Andrzej Pietrasiewicz > Cc: Jacek Anaszewski > Cc: Sylwester Nawrocki > Cc: linux-arm-kernel@lists.infradead.org > --- > v2: change all JPEG marker macros to be in their own namespace (as > suggested by Mauro) Applied, thanks! Regards, Mauro Thanks, Mauro _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel