From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96AE3C433EF for ; Tue, 7 Sep 2021 15:38:05 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5A9D860F5E for ; Tue, 7 Sep 2021 15:38:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 5A9D860F5E Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=ti.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:CC:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=LqYtPXZn/2NW13BEpHPsvqEPOacuv0IDs1I7hv9RYac=; b=pGJooTPrYdClvM Ibqi0exPmt2A16nlJNX+auNvXMhIFo1YRu1gzGJKmEm/D1GiQpeNuTAJAUapIFzKyyrsVmSRmnVVH HcDcHrYlgHYev/Q2nRw0YQoHBedsTIgFMu/xHpV/b1W11U59T2AwRuZa92UDj6UYUCf02jEjJr3Oo NGdaC1WUBOHZ2Qj/smibi7Kru8V9ws9YngKIWbcuiip/mFtSxstLNuzW1NODfq05fQCUtYVrsnBy2 JaNvxO7Levrn8Y/5v7mS7ue7zPe6XfxTd1eW7/y5o6iM0tOpZ+VlXmVupoT0udRTnJNa5Be0bnhSE Y4/YtuO8+9pGX7kt5heg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mNd8a-0045O1-Tx; Tue, 07 Sep 2021 15:35:53 +0000 Received: from fllv0016.ext.ti.com ([198.47.19.142]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mNd8W-0045NP-VT for linux-arm-kernel@lists.infradead.org; Tue, 07 Sep 2021 15:35:50 +0000 Received: from lelv0266.itg.ti.com ([10.180.67.225]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id 187FZl26094843; Tue, 7 Sep 2021 10:35:47 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1631028947; bh=dIkAlr8MdwBVgAEkJnLIXNbbsnHvLWkb+7zsTqPfSGY=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=HTEdrMwMBpJ+5bMIUVCg20nOmrmh1Arm7XUhds3ThCpOs14en8tA/DPDa+ycQhPqD vvPxe0ZFuvmzjxF5HvnsjzhbidZsbv5pPPaIuE0JK7Mja3Gq5u66r8I1zFFd3fTjLU cQp4b7EJf6klxXukUzStRwe0nNBzYycoj7oH8hdQ= Received: from DLEE105.ent.ti.com (dlee105.ent.ti.com [157.170.170.35]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 187FZllb021672 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 7 Sep 2021 10:35:47 -0500 Received: from DLEE113.ent.ti.com (157.170.170.24) by DLEE105.ent.ti.com (157.170.170.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.14; Tue, 7 Sep 2021 10:35:47 -0500 Received: from lelv0327.itg.ti.com (10.180.67.183) by DLEE113.ent.ti.com (157.170.170.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.14 via Frontend Transport; Tue, 7 Sep 2021 10:35:47 -0500 Received: from localhost (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0327.itg.ti.com (8.15.2/8.15.2) with ESMTP id 187FZlkO099332; Tue, 7 Sep 2021 10:35:47 -0500 Date: Tue, 7 Sep 2021 10:35:47 -0500 From: Nishanth Menon To: Jan Kiszka CC: Tero Kristo , Rob Herring , , , , Bao Cheng Su , Chao Zeng Subject: Re: [PATCH 1/3] arm64: dts: ti: iot2050: Flip mmc device ordering on Advanced devices Message-ID: <20210907153547.53cc2zx23rx72kqf@thyself> References: <8e2e435ef67868cb98382b44c51ddb5c8d045d66.1631024536.git.jan.kiszka@siemens.com> <20210907151301.7fqwmc7hmcyhhybv@carve> <35e0cadf-526c-6402-fb8e-8cdb8b7a0bfe@siemens.com> <20210907152746.fbddtkktvx6hb5ti@cattishly> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20171215 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210907_083549_136452_21E0A4F3 X-CRM114-Status: GOOD ( 21.76 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 17:30-20210907, Jan Kiszka wrote: > On 07.09.21 17:27, Nishanth Menon wrote: > > On 17:20-20210907, Jan Kiszka wrote: > >> On 07.09.21 17:13, Nishanth Menon wrote: > >>> On 16:22-20210907, Jan Kiszka wrote: > >>>> From: Jan Kiszka > >>>> > >>>> This ensures that the SD card will remain mmc0 across Basic and Advanced > >>>> devices, also avoiding surprises for users coming from the downstream > >>>> kernels. > >>>> > >>>> Signed-off-by: Jan Kiszka > >>>> --- > >>>> arch/arm64/boot/dts/ti/k3-am6548-iot2050-advanced.dts | 5 +++++ > >>>> 1 file changed, 5 insertions(+) > >>>> > >>>> diff --git a/arch/arm64/boot/dts/ti/k3-am6548-iot2050-advanced.dts b/arch/arm64/boot/dts/ti/k3-am6548-iot2050-advanced.dts > >>>> index ec9617c13cdb..d1d5278e0b94 100644 > >>>> --- a/arch/arm64/boot/dts/ti/k3-am6548-iot2050-advanced.dts > >>>> +++ b/arch/arm64/boot/dts/ti/k3-am6548-iot2050-advanced.dts > >>>> @@ -18,6 +18,11 @@ / { > >>>> compatible = "siemens,iot2050-advanced", "ti,am654"; > >>>> model = "SIMATIC IOT2050 Advanced"; > >>>> > >>>> + aliases { > >>>> + mmc0 = &sdhci1; > >>>> + mmc1 = &sdhci0; > >>>> + }; > >>> > >>> > >>> Should we do this at SoC level? > >>> > >> > >> Well, I wouldn't mind - but that would also impact your EVMs. For us, > >> this is fine as we are coming from that ordering above with our > >> downstream kernel/dts. > >> > > > > I think it'd probably be a welcome change. overall we've standardized on > > partuuid. > > > > Yeah, it's more about "dd if=emmc.img of=/dev/mmcblk1 - damn, the wrong > one again." > > Let me know what you prefer, and I'll update my patch. Lets do it at SoC level. I will follow it up with a patch for other K3 SoCs as well. Unless someone has a strong opinion on this approach - if so, speak up with reasons. -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel