From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D453C433EF for ; Tue, 7 Sep 2021 18:00:26 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1075C60F14 for ; Tue, 7 Sep 2021 18:00:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 1075C60F14 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=S5xj+ycEOYjiVli06B8famFWNsVxeuGXgKa8SgMRjuA=; b=SdXzYBlegM52LE H9mdeKiovac0ziefaq8Y1nAx22EYhjxku7TB4F3rFeDurfJhv7YuayQXcG29aoR4CFlMhA9ckxIXi MaaSwk3Xel6qtUL/yO76yULal2BYHP7t56rpa+gZ+zkOAwWQmkM/WQeMluL1y052H2Mvdf/Fr/k4D INru/wVpXeTc58eEZpmuQnF4e3iNQOzRWDEHySsUvawLo9f+dtCLZHHvwO1Q0xSdSGjGmn0euXocx FyVYRB7W75GYs6SrrfdGSNdR/5Oog+ou5+5O1r1njVsIW4O/drj6n0RRBxE7+wQnvs3Q5pvDWAk16 s5ja03ME9T6NTwnpZ7CQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mNfMc-004P81-7f; Tue, 07 Sep 2021 17:58:30 +0000 Received: from mail-ot1-x32c.google.com ([2607:f8b0:4864:20::32c]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mNfMY-004P7A-Hy for linux-arm-kernel@lists.infradead.org; Tue, 07 Sep 2021 17:58:27 +0000 Received: by mail-ot1-x32c.google.com with SMTP id i8-20020a056830402800b0051afc3e373aso130420ots.5 for ; Tue, 07 Sep 2021 10:58:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Hl2Csvq846iKyuS39mKTxO6Jzoq1ExZ8Eura3xQjYvM=; b=OM9NZKY2jZgZJfh4/UmCLw38Qlz8QNV1v75OFPQmQmRuckesTd0mxecCfK7gk7hqzt 1DazSrPOEfOU1KmZ/gCnFhpfDSsRN2a3RNENrmIkfguMVQAutrBjIVkI8eI9oi/MLZv2 QSYRX9fLWGsOFYA6YAQYu5lVpuxgY8tuXzMNQVmGfEXt0N9MYdwYCwrFd3UX3TxIDO4K BLUlHiXxlTciWQcNlwIrYk4zrpmuFcfX25yzcq3Vvevalzlq0hCKkLTBik8StqcgcfzX Pq+ed0menXMO/OmrwEUlts0Jf67qLe1DwoRPIupYgN0c5d5+l0MlmqCzESn8avoEdiE+ +eIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to; bh=Hl2Csvq846iKyuS39mKTxO6Jzoq1ExZ8Eura3xQjYvM=; b=DzcxUinY7ZwKFSGGmRf5iOJjMkRd0nzUNVwI6IgzXaWreoSYKWTV1F94ZXUIcxYTuv iAP52IYKH8kcwYHbW1wUtEhQ+XNuPV0CRTdamaTUppsoCKvEk14Q+uQ6tLcC/WaIacPU elqouWqaLqcgukuZ/KXb9+X3izUR9ehTtLwZoFlPAxgNbx6PR7j7oxX46qnEHsCY1pTl X532G9S4DuAeHaje7L5q0w114wFerbu/HD42sdZwzYvU84+xuHFXsRLuTeOfHOhoVX+K pSCxEaqUk5jdSEhAmTsgVnoTla4KqZPzFWwnuW17c4kdtnNxnqwc46CHUfh/EsShcPSH ZmzQ== X-Gm-Message-State: AOAM533n0+f44BftzHiF6q4XxNxearkpl66V3N1ZMgnmTxOKn9CAYaI9 JfppEJ1ds4jm+3WuRRCwV8w= X-Google-Smtp-Source: ABdhPJxhXyI+zeNbqvhHfUkj+1PsmnOF/C08n+LAOLflDMVGnJz4gAqeor2uJGg2P6ZWRRrlt5TF2A== X-Received: by 2002:a9d:5a81:: with SMTP id w1mr12973775oth.307.1631037504911; Tue, 07 Sep 2021 10:58:24 -0700 (PDT) Received: from server.roeck-us.net ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id k24sm2521611otp.31.2021.09.07.10.58.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Sep 2021 10:58:24 -0700 (PDT) Date: Tue, 7 Sep 2021 10:58:23 -0700 From: Guenter Roeck To: Doug Anderson Cc: Mathieu Poirier , Jian Cai , Mike Leach , Matthias Kaehlcke , Manoj Gupta , Luis Lozano , coresight@lists.linaro.org, Linux ARM , clang-built-linux , Suzuki K Poulose , Leo Yan , Alexander Shishkin , Greg Kroah-Hartman , LKML Subject: Re: [PATCH v2] coresight: syscfg: fix compiler warnings Message-ID: <20210907175823.GB235361@roeck-us.net> References: <20210830172820.2840433-1-jiancai@google.com> <20210906150625.GA1228692@p14s> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210907_105826_644046_58E2B24A X-CRM114-Status: GOOD ( 23.33 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Sep 07, 2021 at 10:51:53AM -0700, Doug Anderson wrote: > Hi, > > On Mon, Sep 6, 2021 at 8:06 AM Mathieu Poirier > wrote: > > > > On Mon, Aug 30, 2021 at 10:28:19AM -0700, Jian Cai wrote: > > > This fixes warnings with -Wimplicit-function-declaration, e.g. > > > > > > drivers/hwtracing/coresight/coresight-syscfg.c:455:15: error: > > > implicit declaration of function 'kzalloc' [-Werror, > > > -Wimplicit-function-declaration] > > > csdev_item = kzalloc(sizeof(struct cscfg_registered_csdev), > > > GFP_KERNEL); > > > > > > Fixes: 85e2414c518a ("coresight: syscfg: Initial coresight system configuration") > > > Reviewed-by: Guenter Roeck > > > Signed-off-by: Jian Cai > > > --- > > > > > > Changes v1 -> v2: > > > Format the commit message and add Fixes and Reviewed-by tag. > > > > > > drivers/hwtracing/coresight/coresight-syscfg.c | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > > I have applied this patch to my local tree. I will push it to the coresight-next > > branch when 5.15-rc1 is published next week. > > Out of curiosity, does the fact that it'll be in coresight-next mean > that this will target v5.15 or v5.16? I usually think of "-next" > branches as targeting one major version later, so I'd assume v5.16? > ...but it would be nice if this warning could get fixed somewhere in > v5.15. > Normally "when 5.15-rc1 is published" would imply v5.16. Note that warnings are now reported as errors in mainline, since -Werror is now enabled by default. Guenter _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel