From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D4E34C433F5 for ; Wed, 8 Sep 2021 10:55:05 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9B0E361163 for ; Wed, 8 Sep 2021 10:55:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 9B0E361163 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=FEaDKb9wpbfFjxYk5gn09fyN3u6vfRdu+73v2sNKmv0=; b=xouT+KvYUvWYjW 9OlDYBjxFWy/Ywc7awYtqAtcoVUErt4uH+0PnrhFz1kWmaPTdHWj7CuDRzTAp3hljXtLQNu7QVhiB 2JN2SJVATvooy3GHrMuEHSl4TUNXb4OdCYjpoUyZ2E6aG1QB9Q93v1vH/Iy0MHkjk04coIdQaglH/ AvC7v/nExJkiop80sWQ4P8nk2vUfSnU24FafpqCqk0gSrkkO2/gzBo9eT8xU0b+MvOGCLggatpCpw VcL2g361oRCzKhLuW+XM1hfRiiyBjmC8L9UJotgjK0htO5NeHuXvsuLFqQrlRBBaIItnmGc9VlfQN qMQx1LUgwAOtvC501ncQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mNvCL-006Rf8-1K; Wed, 08 Sep 2021 10:52:57 +0000 Received: from mail-lj1-x234.google.com ([2a00:1450:4864:20::234]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mNvCH-006ReD-Ck for linux-arm-kernel@lists.infradead.org; Wed, 08 Sep 2021 10:52:55 +0000 Received: by mail-lj1-x234.google.com with SMTP id y6so2769875lje.2 for ; Wed, 08 Sep 2021 03:52:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=SCa5sUcg3hd31K9Jh0v/b9ezKnAfrViWPcQLkGDjQ+4=; b=oCkzDEUShK5lI6n91PzLUskjiJzDmMHgbLjz+KXzkc3Rfw26w3sRoW8v962TNFfa4M LsrrvsBQeSkrcbTeOeRR4l8qvU6E/8I2wBFPYE6JUUQcYNr+aebrSAXpirXTJmM1x1nX ZEl9Pi2vuebkV5Tt0mat0PwmMWj2KFR1AMJT8WCEXuE1wxBUfgcSbkDXEJ2cLXlKkwjJ AVMKcRonmm3JkuZjdZybhr3eYQSlH5CC3n66VmGnipizSPmq33qJFWDib6RxUYg3IVg1 0yVgTa1YzQxeU4xMujoXFRDUsET4S612uh/mofJ43hKBtxo7TM9wOGzq6SK+it8jLiz1 CFDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=SCa5sUcg3hd31K9Jh0v/b9ezKnAfrViWPcQLkGDjQ+4=; b=k7Gtkjxfhs4AQK/7XyRX9y7v7H8agvu4vkXupPFcKn/vPzUdPN2tNQOJB859p/jeBF gHk5BYUON8rUyhTpSCMp3DyeWmT1IGt184u2LhUAZ6x0fHo07FjJ3a9Y1WIr4TXSrIsx A/djKQH3qT9mDCrPQfWl6wi4aonsEHkNfbj9JPpUeve0bDV4ZbJOdNmPpTnwCMDkaCYO oVFCUubaXIJibIuhHQCNdz5VbDPhgQqOoILAck5NhGWjUIAeb+t8ha4CSBPxmQVXeRSX wr9C4ajEsk6BaRC2NK/zzcpH8SXYRs9rurccag9tNygCMeF+o2bI21IpL3vtmQSxCWId 20GA== X-Gm-Message-State: AOAM531G/sZ+QOM/UsJ+TKY2jZ36evTtUklNIxi68RDS50wMiD1zoGJ8 nFV3Isk4r8OJTfInopddZn4= X-Google-Smtp-Source: ABdhPJzwOrSuphL+vd9b2Iy/O3YtR+9hdvovE6aK5/918675iAVWeZPr9K75U2+6lQiLHq5djr8icA== X-Received: by 2002:a2e:99d9:: with SMTP id l25mr2262345ljj.217.1631098371710; Wed, 08 Sep 2021 03:52:51 -0700 (PDT) Received: from home.paul.comp (paulfertser.info. [2001:470:26:54b:226:9eff:fe70:80c2]) by smtp.gmail.com with ESMTPSA id o7sm201332lji.17.2021.09.08.03.52.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Sep 2021 03:52:51 -0700 (PDT) Received: from home.paul.comp (home.paul.comp [IPv6:0:0:0:0:0:0:0:1]) by home.paul.comp (8.15.2/8.15.2/Debian-14~deb10u1) with ESMTP id 188Aqmlt015750; Wed, 8 Sep 2021 13:52:49 +0300 Received: (from paul@localhost) by home.paul.comp (8.15.2/8.15.2/Submit) id 188Aqkv8015749; Wed, 8 Sep 2021 13:52:46 +0300 Date: Wed, 8 Sep 2021 13:52:45 +0300 From: Paul Fertser To: ChiaWei Wang Cc: "robh+dt@kernel.org" , "joel@jms.id.au" , "andrew@aj.id.au" , "lee.jones@linaro.org" , "osk@google.com" , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-aspeed@lists.ozlabs.org" , "linux-kernel@vger.kernel.org" , "openbmc@lists.ozlabs.org" , Konstantin Klubnichkin Subject: Re: [PATCH v2 0/3] arm: aspeed: Add UART routing support Message-ID: <20210908105245.GB23326@home.paul.comp> References: <20210902021817.17506-1-chiawei_wang@aspeedtech.com> <20210908094248.GZ23326@home.paul.comp> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210908_035253_483922_5D87E6CD X-CRM114-Status: GOOD ( 22.68 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Sep 08, 2021 at 10:18:35AM +0000, ChiaWei Wang wrote: > > Does UART1 need some explicit disabling for VUART IRQs to work? It looks like > > setting LPC address and IRQ number in VUART is enough to override the > > register part but probably not for the interrupt? > > You may need to confirm that the Host does not enable the SIO SUART1 > device. This will conflict with VUART as both SUART and VAURT are > competing for the port address 0x3f8 and SIRQ 4. Do you really mean the Host here, that is, software that controls LPC master when ASpeed is used as an LPC slave? Linux driver is not doing anything special with the UART1, it's just trying to use it as if it was a hardware 16550A physical IC on I/O bus. Or do you mean the BMC software shouldn't be enabling SUART1 by making sure its clock is disabled in SCU0C? Is there anything else needed? I've tried reading the ast2500 datasheet many times but this detail seem to be missing. Is there some appnote on the topic probably? In this case do we have some way to make it an obvious error to enable both SUART1 and VUART in DTS? If they're conflicting surely there should be a way to express that? Thank you for looking into this! -- Be free, use free (http://www.gnu.org/philosophy/free-sw.html) software! mailto:fercerpav@gmail.com _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel