From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1341BC433F5 for ; Thu, 9 Sep 2021 07:06:56 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C976C60E0B for ; Thu, 9 Sep 2021 07:06:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org C976C60E0B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=DgyjoxyEEb439pkapzsloWhrsBq1eTZliS5DCHcwm2w=; b=Ulo8ONFrI9VZdA xdhDgX2kVud9vN3mQw9P99sE2xPqEdPupaBlVXvdmeq1o9DEuzA/1/qwMNtMJbnHQ2/iasbnLxnd5 /pn2nEU0l/oJt2cvbQ931nv45FU3FsTPg6va/kykSPLZ8r+2vBK66HXNP26WeRko46vV2BoZOzPVf woixcSYsCShfKI2wZsjGR31VpxOjFx80qtmMdDBXFoL7racCJtWwdm2X6epa0oK9uKmBeB6XxNZ3g 5fjwPSyWlR20srPAnTNv5Zc8BagPQov+7DEMDX8JcbMsbev2IPqnhRBwmo81v7vqB1QLMloR8Gkzo J13fMZqQumLz3Rn+RXSA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mOE6v-008Q52-LK; Thu, 09 Sep 2021 07:04:37 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mOE6s-008Q4c-44 for linux-arm-kernel@lists.infradead.org; Thu, 09 Sep 2021 07:04:35 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1631171073; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=l2l5r4SBCHwEiq0ScaB4dWcgzj5hh1v8SYuZuO29rHo=; b=JQg0hWdqMt8c0gs+TnrlcGs0gllLgjO6JSIQPWcDvwCiTM8z8++8MhHxuwFsZL4nyzbz3v H5kEGid6hDG0Y6SJ2fc6uLMaemocY3SXm15++zCgIxkMQJR3LZztX9mMi3JeRIlawPFPYM lz71HHLc9PLq07nUYtg5iPn9CVM1MEg= Received: from mail-ej1-f70.google.com (mail-ej1-f70.google.com [209.85.218.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-374-L1MOfFZROiKCH9e-Ko8oIQ-1; Thu, 09 Sep 2021 03:04:32 -0400 X-MC-Unique: L1MOfFZROiKCH9e-Ko8oIQ-1 Received: by mail-ej1-f70.google.com with SMTP id jw25-20020a17090776b900b005ca775a2a00so351405ejc.1 for ; Thu, 09 Sep 2021 00:04:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=l2l5r4SBCHwEiq0ScaB4dWcgzj5hh1v8SYuZuO29rHo=; b=VymVHU4dtGFrqcCBNiR+zSGdUZ/fLVwO47WdSQDpYcT6G24NRCjbCUe/3bk3andd98 1OEgFjYjtiJks/pdUnfQoIJzwojsDx0/xGgB10vgymkfPzARBif5/9/qcBqFRU4QQXfl K1rPOcAAvLoRQV8QmQ8ZFkrbRSz97jD1eIP5g3I8R9qLutzTiGTShQtsvxXdG6LolTIh TThizIH9UnZWq1lchjMhfSw/aqo9ZCMphPV2Iz2/kkIyIkvT69/CcaKPsyP/SMSciNTF Oxy8fahctRBraiaHnodfTZAmomMxpPTaMSx3AsmOkroLytYVae7B1JFOzd6DV6v/zZze F/Jg== X-Gm-Message-State: AOAM530U7yFnu8ggWZWxTD3ITWPMV3IijG0nLAmTi/X62KKXDDZOXqlq JyGTY43TMa5TjIGNADYbiRom0tPsL4FybBc61pkFqyDPxtLEoZgJRPK+Cgm5Y5xPnhw6mSxNHFt i3+6l328wC6yIaBb//0BvvoqBKUT+hLgCqTc= X-Received: by 2002:a17:906:7302:: with SMTP id di2mr1869664ejc.409.1631171070889; Thu, 09 Sep 2021 00:04:30 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxaTI3qYEno3ZJd14sTF6cADqRVW3Joo5jc8lsKG9esd951qp14KjQPeWPkFFvJv/w4BJzeLw== X-Received: by 2002:a17:906:7302:: with SMTP id di2mr1869651ejc.409.1631171070762; Thu, 09 Sep 2021 00:04:30 -0700 (PDT) Received: from gator (cst2-174-132.cust.vodafone.cz. [31.30.174.132]) by smtp.gmail.com with ESMTPSA id cr9sm499745edb.17.2021.09.09.00.04.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Sep 2021 00:04:30 -0700 (PDT) Date: Thu, 9 Sep 2021 09:04:23 +0200 From: Andrew Jones To: Raghavendra Rao Ananta Cc: Paolo Bonzini , Marc Zyngier , James Morse , Alexandru Elisei , Suzuki K Poulose , Catalin Marinas , Will Deacon , Peter Shier , Ricardo Koller , Oliver Upton , Reiji Watanabe , Jing Zhang , linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org, kvm@vger.kernel.org Subject: Re: [PATCH v4 04/18] KVM: arm64: selftests: Introduce ARM64_SYS_KVM_REG Message-ID: <20210909070423.5z4eg7wkmswpdi33@gator> References: <20210909013818.1191270-1-rananta@google.com> <20210909013818.1191270-5-rananta@google.com> MIME-Version: 1.0 In-Reply-To: <20210909013818.1191270-5-rananta@google.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=drjones@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210909_000434_279718_2E473705 X-CRM114-Status: GOOD ( 18.53 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Sep 09, 2021 at 01:38:04AM +0000, Raghavendra Rao Ananta wrote: > With the inclusion of sysreg.h, that brings in system register > encodings, it would be redundant to re-define register encodings > again in processor.h to use it with ARM64_SYS_REG for the KVM > functions such as set_reg() or get_reg(). Hence, add helper macro, > ARM64_SYS_KVM_REG, that converts SYS_* definitions in sysreg.h > into ARM64_SYS_REG definitions. > > Signed-off-by: Raghavendra Rao Ananta > --- > .../selftests/kvm/include/aarch64/processor.h | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > > diff --git a/tools/testing/selftests/kvm/include/aarch64/processor.h b/tools/testing/selftests/kvm/include/aarch64/processor.h > index bed4ffa70905..ac8b63f8aab7 100644 > --- a/tools/testing/selftests/kvm/include/aarch64/processor.h > +++ b/tools/testing/selftests/kvm/include/aarch64/processor.h > @@ -26,6 +26,20 @@ > > #define ID_AA64DFR0_EL1 3, 0, 0, 5, 0 > > +/* > + * ARM64_SYS_KVM_REG(sys_reg_id): Helper macro to convert > + * SYS_* register definitions in sysreg.h to use in KVM > + * calls such as get_reg() and set_reg(). > + */ > +#define ARM64_SYS_KVM_REG(sys_reg_id) \ > +({ \ > + ARM64_SYS_REG(sys_reg_Op0(sys_reg_id), \ > + sys_reg_Op1(sys_reg_id), \ > + sys_reg_CRn(sys_reg_id), \ > + sys_reg_CRm(sys_reg_id), \ > + sys_reg_Op2(sys_reg_id)); \ > +}) I don't think we need the ({ }), do we? Anyway, Reviewed-by: Andrew Jones Thanks, drew > + > /* > * Default MAIR > * index attribute > -- > 2.33.0.153.gba50c8fa24-goog > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel