From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73ABAC433FE for ; Fri, 10 Sep 2021 00:19:56 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 40F77610A3 for ; Fri, 10 Sep 2021 00:19:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 40F77610A3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ffWQ4m2acafePXqoPsCAX434hHfn9n4Ub1hPaCbJPP0=; b=EDdWVQzSATBZQy iQ/jXWsOmicT16FMFhwZ+LJhMe8AJDtGZYsAJRYdiKiLrjE2yYo1+thAqWW1cmxgAdeDV6ozY2vzh 7qgmQbsQMHZRLo5zcsWU6ShHG9ceNB+32DkVWOk6++Y7d9d8bUo7Cw4yUiAy2f5kKNuRgU+oxAlHF A0oTleKe76OTJAXiTFl5D0WVP2TOJmvRbgNPAjGF0kkzMTpSYnDKJxjSUWSUCDep8IblY565I6toF ZOZRSobS7JwIhZFXuICkXxxR+LvA4Plfu9kjVtH725tIy25y789pvq17mjiElofzrd9xPPR9CO1F7 FHmiCuoOQhLYOGEEqrDg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mOUFP-00BE0M-48; Fri, 10 Sep 2021 00:18:28 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mOUEF-00BDK4-Dy for linux-arm-kernel@lists.infradead.org; Fri, 10 Sep 2021 00:17:17 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 3B839611C5; Fri, 10 Sep 2021 00:17:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1631233035; bh=8UHya4BeRSSQoQtCkxlbxEoRKENCHenX+bLVQL2y0dk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=mbBhkJeVjnR4xKKgHlWLUvbfIqFxzQLfm6p9sMsWECqH8FgPQ1kzBoKLWjcfKYfrs hyr+yCaViGNZ4dWmAFciShchO2uJxTYuX1yIEZDYPzL1AU1xo6S4x5jeTbylRRh7ah uQZJGud3uGdtWeKi5MIbzngv9Oiid8X3sygaar5v/36l0fizsfIINKp/o2lfM7S6ql gjn9oNNJmrF42qUCGDzc2Jg/5hKzvyKuZrRntSSlA73naCDUzHi4e6NULrXN6eJdMV cqnN75W7eRQncA05C3SOP9ex53FBT2xmrXklJsRvkqrFWAp2zQB62BJFYGcon1Br/e Dq7w4WWUD+6iQ== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Evgeny Novikov , Jiri Kosina , Sasha Levin , linux-input@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org Subject: [PATCH AUTOSEL 5.14 55/99] HID: thrustmaster: Fix memory leak in thrustmaster_interrupts() Date: Thu, 9 Sep 2021 20:15:14 -0400 Message-Id: <20210910001558.173296-55-sashal@kernel.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210910001558.173296-1-sashal@kernel.org> References: <20210910001558.173296-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210909_171715_660021_7C30BF41 X-CRM114-Status: UNSURE ( 9.12 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Evgeny Novikov [ Upstream commit c3800eed22d21c66912b4461a403b4448ed88d95 ] thrustmaster_interrupts() does not free memory for send_buf when usb_interrupt_msg() fails. This is fixed by the given patch. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Evgeny Novikov Signed-off-by: Jiri Kosina Signed-off-by: Sasha Levin --- drivers/hid/hid-thrustmaster.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/hid/hid-thrustmaster.c b/drivers/hid/hid-thrustmaster.c index 9cb4248f95af..d44550aa8805 100644 --- a/drivers/hid/hid-thrustmaster.c +++ b/drivers/hid/hid-thrustmaster.c @@ -173,6 +173,7 @@ static void thrustmaster_interrupts(struct hid_device *hdev) if (ret) { hid_err(hdev, "setup data couldn't be sent\n"); + kfree(send_buf); return; } } -- 2.30.2 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel