From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 20981C433EF for ; Fri, 10 Sep 2021 00:27:13 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D59486103E for ; Fri, 10 Sep 2021 00:27:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org D59486103E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=PVjqjYtT+4BdKOhKuZFcSYI5mPTYFuBHR1dh3dKFFzc=; b=210b/iE8ZPw3+M 5s83I7Kw56z9MpbzWzi1W7JWMzxBWvIrkJupdNNaAV7CxevBlloiLzuEgdTHrm3fJgotuskK2RgQS okijr7eAoKvItebc5vka/Ssxv6nYxBoQ+Yv70wCHrrNJ8a8LfMAb2K5tLK25dR5cSs8B0bqO562rA 3pb3daTqa3NJuq5whEi3U/g2F/kZWO9GR7PBJE41RqO/nsTlSicptua0w1pxLqPDR9J77debWWSGt VwlBgAzsj/9Ej2nQJDxKMKeV0HDx33SWUa4r+WBihwkBWf9IY8ElExzZonynmJCcUJq6jmUQG07Mf xtyxPgY2lS07OJCk2PqA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mOULj-00BHVf-Vf; Fri, 10 Sep 2021 00:25:02 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mOUGO-00BEff-47 for linux-arm-kernel@lists.infradead.org; Fri, 10 Sep 2021 00:19:29 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id E1DA061167; Fri, 10 Sep 2021 00:19:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1631233167; bh=OFE96SrViNGgdmp3zfqPBD3pHqDhksQvjOmzGukE/FE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=TvrJCRhhQfDfRsEYFoKFdVcDkGW6M9s56kHSCzyKod+1YsoeieHYQvblyVXumtqbT EbpYAYrBvQIoSGQV6ftap5I9JQGR0yXAKYYa85kT2J+7yZydvaifNF6e6DIs6tuZOX Swo//S89MTIn51mFKd1NrhyI4w6KsLyVuqVzOqkRiCE2SQQ2VJDQup6m5+8Z3zrstg Tpkdx9KNKHp8LouSMNZMLm/kn0kVlKoaHsq2wL8MQ5wn6Y66Qga50J1wM0m1UfTcPa W2BauEmX/DG3H30nK4uwVZIq3A72rowdYDd0k3K1Qo3aw43Oyig97VZpOZ9nlPWWWw WGFV0r47GzCmg== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Evgeny Novikov , Jiri Kosina , Sasha Levin , linux-input@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org Subject: [PATCH AUTOSEL 5.13 47/88] HID: thrustmaster: Fix memory leaks in probe Date: Thu, 9 Sep 2021 20:17:39 -0400 Message-Id: <20210910001820.174272-47-sashal@kernel.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210910001820.174272-1-sashal@kernel.org> References: <20210910001820.174272-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210909_171928_263567_CC5FBA45 X-CRM114-Status: GOOD ( 11.73 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Evgeny Novikov [ Upstream commit d0f1d5ae23803bd82647a337fa508fa8615defc5 ] When thrustmaster_probe() handles errors of usb_submit_urb() it does not free allocated resources and fails. The patch fixes that. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Evgeny Novikov Signed-off-by: Jiri Kosina Signed-off-by: Sasha Levin --- drivers/hid/hid-thrustmaster.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/hid/hid-thrustmaster.c b/drivers/hid/hid-thrustmaster.c index f643b1cb112d..eede9d676bd4 100644 --- a/drivers/hid/hid-thrustmaster.c +++ b/drivers/hid/hid-thrustmaster.c @@ -335,11 +335,14 @@ static int thrustmaster_probe(struct hid_device *hdev, const struct hid_device_i ); ret = usb_submit_urb(tm_wheel->urb, GFP_ATOMIC); - if (ret) + if (ret) { hid_err(hdev, "Error %d while submitting the URB. I am unable to initialize this wheel...\n", ret); + goto error6; + } return ret; +error6: kfree(tm_wheel->change_request); error5: kfree(tm_wheel->response); error4: kfree(tm_wheel->model_request); error3: usb_free_urb(tm_wheel->urb); -- 2.30.2 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel