From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1AB7EC433EF for ; Sat, 11 Sep 2021 11:31:38 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C6BFF610A3 for ; Sat, 11 Sep 2021 11:31:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org C6BFF610A3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=oDoCeSHbGh7pSi5QiiERIhgGIt6RJ6jBtGX/l8Nkl8M=; b=u3d4FFD2O6ZzQo fJTEnsOWmhhn0D6II5ZW0nlRZ1N7EMTid65h4qDFsTRfLXUtgaIyrZ6gMTbgGievW+m3/Cd+93rpq sSCONgxfjMotmOVFyq+coUS6nR8RpAtKao+z7Pue49e5XH0FOQ73GAnijwIhGzGSWpGo9d+tF6fK3 7u9edArPCC7E3mdw3Iw/Id5Pk362XMAqGQAO/fJZQx2SC9egYe/XpqiN11gp/SBhEoH2gHW3mlWMd SbtQnDqfHKNKYUbjoWsGAMXixfkPOGYao4sgNJSZrPjb8iABAgugk+6XN7CEDZA4NqXTR6lTc4GqA Y3WsR3pkhGzKz18rQ9tw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mP1CF-00EiFB-DW; Sat, 11 Sep 2021 11:29:23 +0000 Received: from mail-pg1-x52f.google.com ([2607:f8b0:4864:20::52f]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mP1CB-00EiEm-49; Sat, 11 Sep 2021 11:29:20 +0000 Received: by mail-pg1-x52f.google.com with SMTP id q68so4379473pga.9; Sat, 11 Sep 2021 04:29:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=nE6Vpn2ifraVOUHXGmEpuLZh+Ikao8iz2hSDRjcDdNI=; b=VX+XTfVBN4HIOzLzKYjvnziCEiqpZ5gaTBn+PaJkv34akMtiFiEAIYt2k+7sKh3piV iMcdTCd6WKHuA5iAVDwRngLZIoXugdar1femUuyIpYC1f7RKlsbNJyesm2s2IMzFNPTC yBVwYf9nnATqvbo9UUQPGz/7C5G0fJJtsJPNn49zH895MtXqboiZTGhMHq7scP19wLVW 4wQOT4a1ykOdBGVOsr1uqRLEABMfI3jEDtkqBf6bK9Ij15jHnFQAYDzUCWylRB5OZyOb iLIOBILDRlQHw7+jutgjHbDKStgcMV0wuLzUzIIkO9XVOww8QiGGJLWZ2yPPhFYlxC6x I71g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=nE6Vpn2ifraVOUHXGmEpuLZh+Ikao8iz2hSDRjcDdNI=; b=QJZ2H0Ldg+il33VWxGCPo6ycEtSQGOwZ2ZjYw/klKWarQ8b4u8NfPiEYKM2Bwj6z/5 XprN7yMI/1iR0JNUEweW4Unddgjr2vvV1Of2VTjaJvxoUE/t9xiKyf5Av07Z22GP9HQj lfjVj9X2Omwg0zJ6dIBkPg1bnlcSDOK4yDNpkK+Yv112F4Ax3pxkBGtRM+C5AvCnfqxS GuY9H/KPJ4S38+08yNQDUcbKYfKg5M08yJQ9MvQpiRmYQea4Y8aZ3E8MwV/ELU6m97Y3 xXUXHG7CG+NuKfcSEtM0RsIcBAez+h08O4cUeaA+dhFGw9vXg1a5lHZAt/AURvTfs0FF HFSw== X-Gm-Message-State: AOAM531GSzQWi+f0PCAufYr8+2ZCFA9JjVOSuy7ChBOOoc1zeN1CTiPJ QPlLGmCiT5hGSjBHAf4F9iM= X-Google-Smtp-Source: ABdhPJz3FdAEaCj7tJJNY31BmDCvgnxcHybUr0YzUiI9N/Qa0F32mc6/ynsC5sQX9aV6iya0MEwBIg== X-Received: by 2002:a63:1309:: with SMTP id i9mr2179080pgl.192.1631359758380; Sat, 11 Sep 2021 04:29:18 -0700 (PDT) Received: from ojas ([122.161.51.62]) by smtp.gmail.com with ESMTPSA id m21sm1570271pjl.14.2021.09.11.04.29.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 11 Sep 2021 04:29:18 -0700 (PDT) Date: Sat, 11 Sep 2021 16:59:11 +0530 From: Ojaswin Mujoo To: Greg Kroah-Hartman Cc: linux-staging@lists.linux.dev, Nicolas Saenz Julienne , Stefan Wahren , Arnd Bergmann , Dan Carpenter , Phil Elwell , bcm-kernel-feedback-list@broadcom.com, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] staging: vchiq: convert to use a miscdevice Message-ID: <20210911112911.GA17777@ojas> References: <20210907115045.2206083-1-gregkh@linuxfoundation.org> <20210910114004.GA23656@ojas> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210911_042919_219649_196F8F00 X-CRM114-Status: GOOD ( 29.36 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Sep 10, 2021 at 02:05:19PM +0200, Greg Kroah-Hartman wrote: > On Fri, Sep 10, 2021 at 05:10:04PM +0530, Ojaswin Mujoo wrote: > > On Tue, Sep 07, 2021 at 01:50:45PM +0200, Greg Kroah-Hartman wrote: > > > Using a struct class, a cdev, and another device just for a single minor > > > device is total overkill. Just use a dynamic misc device instead, > > > saving lots of logic and memory. > > > > Hello Greg, > > > > I got some time to test this out at my end. This seems to work correctly > > however there's a small change in permissions applied to /dev/vchiq that > > is causing tests to break. > > > > * Permissions before the patch * > > $ ls -l /dev/vchiq > > crw-rw---- 1 root video 235, 0 May 7 17:33 vchiq > > > > * Permissions after the patch * > > $ ls -l /dev/vchiq > > crw------- 1 root root 10, 125 May 7 17:30 vchiq > > > > As seen above, after the patch, the cdev is only accessible by root user, > > which is causing the tests ($ vchiq_test -f 10) to fail when run as > > non-root. > > Ah, that's not under the kernel's control, but as you point out, it's a > udev issue. > > > I believe assigning the permission and "video" group to /dev/vchiq is > > handled by udev, in the downstream pi OS, as seen in this line in > > /lib/udev/rules.d/10-local-rpi.rules file: > > > > SUBSYSTEM=="vchiq", GROUP="video", MODE="0660" > > > > I'm not completely sure how the SUBSYSTEM part is passed to udev from > > the kernel modules, however seems like the miscdevice is not notifying > > udev correctly (?). > > No, the SUBSYSTEM for this device has changed from "vchiq" to "misc". > > Having a whole subsystem for just one character device is crazy, which > is why I did the kernel change. > > Try changing the line in the udev file to: > > NAME=="vchiq", GROUP="video", MODE="0660" > > (SUBSYSTEM changes to NAME) and see if that works both on the newer > kernel, and on the older ones as > well. Hello, thanks for the explanation and pointers. The "NAME==vchiq" change doesn't seem to work but I was able to get it correctly working by using "KERNEL=vchiq" instead: KERNEL=="vchiq", GROUP="video", MODE="0660" I tested this with and without this patch and it works as expected. Regards, Ojaswin > > thanks, > > greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel