Re: [PATCH 19/22] soc: sunxi: mbus: Add A31 ISP compatibles to the list

Maxime Ripard
2021-09-13T08:34:54Z

[-- Attachment #1.1: Type: text/plain, Size: 924 bytes --]

On Mon, Sep 13, 2021 at 09:45:22AM +0200, Paul Kocialkowski wrote:
> Hi Samuel,
>
> On Fri 10 Sep 21, 21:36, Samuel Holland wrote:
> > On 9/10/21 1:41 PM, Paul Kocialkowski wrote:
> > > The A31 ISP sits on the mbus and requires the usual bus address
> > > adaptation. Add its compatibles to the list.
> >
> > My understanding is that this driver only exists to work around old DT
> > bindings where the interconnects/interconnect-names = "dma-mem"
> > properties are not required (and so they are historically missing from
> > the device trees).
> >
> > For new bindings, it would be better to use those properties and not add
> > to this list.
>
> Oh okay, I didn't really look into it and just did the same thing that was
> done for the CSI controller. Thanks for the heads up!

This code was done to maintain backward compatibility. New DT should
indeed use the interconnects property.

Maxime

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]