Re: [PATCH 03/22] dt-bindings: sun6i-a31-mipi-dphy: Add optional direction property

Paul Kocialkowski
2021-09-14T07:41:22Z

[-- Attachment #1.1: Type: text/plain, Size: 1924 bytes --]

Hi,

On Mon 13 Sep 21, 10:00, Maxime Ripard wrote:
> On Fri, Sep 10, 2021 at 08:41:28PM +0200, Paul Kocialkowski wrote:
> > The Allwinner A31 MIPI D-PHY block supports both tx and rx directions,
> > although each instance of the block is meant to be used in one
> > direction only. There will typically be one instance for MIPI DSI and
> > one for MIPI CSI-2 (it seems unlikely to ever see a shared instance).
> >
> > Describe the direction with a new allwinner,direction property.
> > For backwards compatibility, the property is optional and tx mode
> > should be assumed by default.
> >
> > Signed-off-by: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
> > ---
> > .../bindings/phy/allwinner,sun6i-a31-mipi-dphy.yaml | 12 ++++++++++++
> > 1 file changed, 12 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/phy/allwinner,sun6i-a31-mipi-dphy.yaml b/Documentation/devicetree/bindings/phy/allwinner,sun6i-a31-mipi-dphy.yaml
> > index d0b541a461f3..303bbaf3b915 100644
> > --- a/Documentation/devicetree/bindings/phy/allwinner,sun6i-a31-mipi-dphy.yaml
> > +++ b/Documentation/devicetree/bindings/phy/allwinner,sun6i-a31-mipi-dphy.yaml
> > @@ -37,6 +37,18 @@ properties:
> > resets:
> > maxItems: 1
> >
> > + allwinner,direction:
> > + $ref: '/schemas/types.yaml#/definitions/string'
> > + description: |
> > + Direction of the D-PHY:
> > + - "rx" for receiving (e.g. when used with MIPI CSI-2);
> > + - "tx" for transmitting (e.g. when used with MIPI DSI).
> > +
> > + When the property is missing, "tx" direction is assumed.
>
> You can provide this using default

Understood.

> > + oneOf:
> > + - const: tx
> > + - const: rx
> > +
>
> enum?

Ah yes, enum feels like a better fit!

Thanks,

Paul

--
Paul Kocialkowski, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]